This implementation works for all cases under java-1.5 or - * later. However, in java-1.4, some charsets don't have a java-nio + * later. However, in java-1.4, some charsets don't have a java.nio * implementation, most notably the default ZIP encoding Cp437.
* *The methods of this class are reentrant.
diff --git a/src/main/org/apache/tools/zip/Simple8BitZipEncoding.java b/src/main/org/apache/tools/zip/Simple8BitZipEncoding.java index a845e763a..b23e4c233 100644 --- a/src/main/org/apache/tools/zip/Simple8BitZipEncoding.java +++ b/src/main/org/apache/tools/zip/Simple8BitZipEncoding.java @@ -21,7 +21,6 @@ package org.apache.tools.zip; import java.io.IOException; import java.nio.ByteBuffer; -import java.nio.charset.Charset; import java.util.ArrayList; import java.util.Collections; import java.util.List; diff --git a/src/main/org/apache/tools/zip/ZipEncoding.java b/src/main/org/apache/tools/zip/ZipEncoding.java index 5dc88e4b4..53ea2db33 100644 --- a/src/main/org/apache/tools/zip/ZipEncoding.java +++ b/src/main/org/apache/tools/zip/ZipEncoding.java @@ -21,7 +21,6 @@ package org.apache.tools.zip; import java.io.IOException; import java.nio.ByteBuffer; -import java.nio.charset.Charset; /** * An interface for encoders that do a pretty encoding of ZIP @@ -35,12 +34,12 @@ import java.nio.charset.Charset; *The main reason for defining an own encoding layer comes from * the problems with {@link java.lang.String#getBytes(String) * String.getBytes}, which encodes unknown characters as ASCII - * quotation marks ('?'), which is per definition an invalid filename - * character under some operating systems (Windows, e.g.) leading to - * ignored ZIP entries.
+ * quotation marks ('?'). Quotation marks are per definition an + * invalid filename on some operating systems like Windows, which + * leads to ignored ZIP entries. * *All implementations should implement this interface in a - * reentrant way.<(p> + * reentrant way.
*/ interface ZipEncoding { /**