Browse Source

First pass of JavaDoc work just to get rid of warnings.

When this is complete, whole source tree should JavaDoc (with 1.4)
with no warnings. (With JDK1.3.1 the 1.4-regexp stuff generates
warnings, but that's all.)


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271545 13f79535-47bb-0310-9956-ffa450edef68
master
Jon Skeet 23 years ago
parent
commit
69846bc441
13 changed files with 29 additions and 28 deletions
  1. +13
    -9
      src/main/org/apache/tools/ant/TaskContainer.java
  2. +0
    -1
      src/main/org/apache/tools/ant/listener/MailLogger.java
  3. +3
    -1
      src/main/org/apache/tools/ant/taskdefs/KeySubst.java
  4. +0
    -1
      src/main/org/apache/tools/ant/taskdefs/LoadFile.java
  5. +1
    -1
      src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java
  6. +2
    -2
      src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLResultAggregator.java
  7. +1
    -1
      src/main/org/apache/tools/ant/taskdefs/optional/junit/Xalan1Executor.java
  8. +3
    -3
      src/main/org/apache/tools/ant/types/CommandlineJava.java
  9. +0
    -3
      src/main/org/apache/tools/ant/types/FilterSet.java
  10. +1
    -1
      src/main/org/apache/tools/ant/types/RegularExpression.java
  11. +1
    -1
      src/main/org/apache/tools/ant/types/Substitution.java
  12. +0
    -1
      src/main/org/apache/tools/ant/util/PackageNameMapper.java
  13. +4
    -3
      src/main/org/apache/tools/ant/util/regexp/RegexpFactory.java

+ 13
- 9
src/main/org/apache/tools/ant/TaskContainer.java View File

@@ -1,7 +1,7 @@
/* /*
* The Apache Software License, Version 1.1 * The Apache Software License, Version 1.1
* *
* Copyright (c) 2001 The Apache Software Foundation. All rights
* Copyright (c) 2001-2002 The Apache Software Foundation. All rights
* reserved. * reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@@ -55,20 +55,24 @@
package org.apache.tools.ant; package org.apache.tools.ant;


/** /**
* Interface for objects which can contain tasks
*
* <p>It is recommended that implementations call {@link Task#perform
* perform} instead of {@link Task#execute execute} for the tasks they
* contain, as this method ensures that {@link BuildEvent BuildEvents}
* will be generated.</p>
* Interface for objects which can contain tasks.
* <p>
* It is recommended that implementations call perform rather than
* execute for the tasks they contain, as this method ensures that the
* appropriate BuildEvents will be generated.
* *
* @see Task#perform
* @see Task#execute
* @see BuildEvent
*
* @author <a href="mailto:conor@apache.org">Conor MacNeill</a> * @author <a href="mailto:conor@apache.org">Conor MacNeill</a>
*/ */
public interface TaskContainer { public interface TaskContainer {
/** /**
* Add a task to this task container
* Adds a task to this task container
* *
* @param task the task to be added to this container
* @param task The task to be added to this container.
* Must not be <code>null</code>.
*/ */
void addTask(Task task); void addTask(Task task);
} }


+ 0
- 1
src/main/org/apache/tools/ant/listener/MailLogger.java View File

@@ -95,7 +95,6 @@ import org.apache.tools.mail.MailMessage;
* file will override Ant properties. * file will override Ant properties.
* *
*@author Erik Hatcher <a href="mailto:ehatcher@apache.org">ehatcher@apache.org</a> *@author Erik Hatcher <a href="mailto:ehatcher@apache.org">ehatcher@apache.org</a>
*@created December 12, 2001
*/ */
public class MailLogger extends DefaultLogger { public class MailLogger extends DefaultLogger {




+ 3
- 1
src/main/org/apache/tools/ant/taskdefs/KeySubst.java View File

@@ -140,6 +140,8 @@ public class KeySubst extends Task {
this.sep = sep; this.sep = sep;
} }
/** /**
* Sets the keys.
*
Format string is like this: Format string is like this:
<p> <p>
name=value*name2=value name=value*name2=value
@@ -184,7 +186,7 @@ public class KeySubst extends Task {
/** /**
Does replacement on text using the hashtable of keys. Does replacement on text using the hashtable of keys.
@returns the string with the replacements in it.
@return the string with the replacements in it.
*/ */
public static String replace ( String origString, Hashtable keys ) public static String replace ( String origString, Hashtable keys )
throws BuildException throws BuildException


+ 0
- 1
src/main/org/apache/tools/ant/taskdefs/LoadFile.java View File

@@ -64,7 +64,6 @@ import java.io.*;
* Load a file into a property * Load a file into a property
* *
* @author Steve Loughran * @author Steve Loughran
* @created 10 December 2001
*/ */
public class LoadFile extends Task { public class LoadFile extends Task {




+ 1
- 1
src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java View File

@@ -357,7 +357,7 @@ public class JUnitTask extends Task {
} }


/** /**
* Use a completely new environment
* Use a completely new environment.
* *
* <p>Will be ignored if we are not forking a new VM. * <p>Will be ignored if we are not forking a new VM.
* *


+ 2
- 2
src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLResultAggregator.java View File

@@ -105,7 +105,7 @@ public class XMLResultAggregator extends Task implements XMLConstants {


protected Vector transformers = new Vector(); protected Vector transformers = new Vector();


/** the default directory: <tt>.</tt>. It is resolved from the project directory */
/** The default directory: <tt>&#046;</tt>. It is resolved from the project directory */
public final static String DEFAULT_DIR = "."; public final static String DEFAULT_DIR = ".";


/** the default file name: <tt>TESTS-TestSuites.xml</tt> */ /** the default file name: <tt>TESTS-TestSuites.xml</tt> */
@@ -307,8 +307,8 @@ public class XMLResultAggregator extends Task implements XMLConstants {
/** /**
* Create a new document builder. Will issue an <tt>ExceptionInitializerError</tt> * Create a new document builder. Will issue an <tt>ExceptionInitializerError</tt>
* if something is going wrong. It is fatal anyway. * if something is going wrong. It is fatal anyway.
* To-do: factorize this somewhere else. It is duplicated code.
* @return a new document builder to create a DOM * @return a new document builder to create a DOM
* @todo factorize this somewhere else. It is duplicated code.
*/ */
private static DocumentBuilder getDocumentBuilder() { private static DocumentBuilder getDocumentBuilder() {
try { try {


+ 1
- 1
src/main/org/apache/tools/ant/taskdefs/optional/junit/Xalan1Executor.java View File

@@ -63,7 +63,7 @@ import org.apache.xalan.xslt.XSLTResultTarget;
/** /**
* Xalan 1 executor. It will need a lot of things in the classpath: * Xalan 1 executor. It will need a lot of things in the classpath:
* xerces for the serialization, xalan and bsf for the extension. * xerces for the serialization, xalan and bsf for the extension.
* @todo do everything via reflection to avoid compile problems ?
* To-do: do everything via reflection to avoid compile problems ?
*/ */
public class Xalan1Executor extends XalanExecutor { public class Xalan1Executor extends XalanExecutor {
void execute() throws Exception { void execute() throws Exception {


+ 3
- 3
src/main/org/apache/tools/ant/types/CommandlineJava.java View File

@@ -64,9 +64,9 @@ import org.apache.tools.ant.taskdefs.condition.Os;


/** /**
* A representation of a Java command line that is nothing more * A representation of a Java command line that is nothing more
* than a composite of 2 <tt>Commandline</tt>. 1 for the vm/options and
* 1 for the classname/arguments. It provides specific methods for
* a java command line.
* than a composite of 2 <tt>Commandline</tt>. One is used for the
* vm/options and one for the classname/arguments. It provides
* specific methods for a java command line.
* *
* @author thomas.haas@softwired-inc.com * @author thomas.haas@softwired-inc.com
* @author <a href="mailto:sbailliez@apache.org">Stephane Bailliez</a> * @author <a href="mailto:sbailliez@apache.org">Stephane Bailliez</a>


+ 0
- 3
src/main/org/apache/tools/ant/types/FilterSet.java View File

@@ -75,7 +75,6 @@ import org.apache.tools.ant.Project;
* A filter set may have begintoken and endtokens defined. * A filter set may have begintoken and endtokens defined.
* *
* @author <A href="mailto:gholam@xtra.co.nz"> Michael McCallum </A> * @author <A href="mailto:gholam@xtra.co.nz"> Michael McCallum </A>
* @created 14 March 2001
*/ */
public class FilterSet extends DataType implements Cloneable { public class FilterSet extends DataType implements Cloneable {
@@ -83,7 +82,6 @@ public class FilterSet extends DataType implements Cloneable {
* Individual filter component of filterset * Individual filter component of filterset
* *
* @author Michael McCallum * @author Michael McCallum
* @created 14 March 2001
*/ */
public static class Filter { public static class Filter {
/** Token which will be replaced in the filter operation */ /** Token which will be replaced in the filter operation */
@@ -150,7 +148,6 @@ public class FilterSet extends DataType implements Cloneable {
* The filtersfile nested element. * The filtersfile nested element.
* *
* @author Michael McCallum * @author Michael McCallum
* @created Thursday, April 19, 2001
*/ */
public class FiltersFile { public class FiltersFile {


+ 1
- 1
src/main/org/apache/tools/ant/types/RegularExpression.java View File

@@ -87,7 +87,7 @@ import org.apache.tools.ant.util.regexp.RegexpFactory;
* /&gt; * /&gt;
* </pre> * </pre>
* *
* @see org.apache.oro.regex.Perl5Compiler
* @see org.apache.oro.text.regex.Perl5Compiler
* @see org.apache.regexp.RE * @see org.apache.regexp.RE
* @see java.util.regex.Pattern * @see java.util.regex.Pattern
* *


+ 1
- 1
src/main/org/apache/tools/ant/types/Substitution.java View File

@@ -68,7 +68,7 @@ import org.apache.tools.ant.types.DataType;
* /&gt; * /&gt;
* </pre> * </pre>
* *
* @see org.apache.oro.text.regex.Perl5Substitition
* @see org.apache.oro.text.regex.Perl5Substitution
* @author Matthew Inger <a href="mailto:mattinger@mindless.com">mattinger@mindless.com</a> * @author Matthew Inger <a href="mailto:mattinger@mindless.com">mattinger@mindless.com</a>
*/ */
public class Substitution extends DataType public class Substitution extends DataType


+ 0
- 1
src/main/org/apache/tools/ant/util/PackageNameMapper.java View File

@@ -65,7 +65,6 @@ import java.io.File;
* </pre> * </pre>
* *
*@author Erik Hatcher *@author Erik Hatcher
*@created December 29, 2001
*/ */
public class PackageNameMapper extends GlobPatternMapper { public class PackageNameMapper extends GlobPatternMapper {
/** /**


+ 4
- 3
src/main/org/apache/tools/ant/util/regexp/RegexpFactory.java View File

@@ -112,11 +112,12 @@ public class RegexpFactory extends RegexpMatcherFactory
} }


/** /**
* Wrapper over {@seee RegexpMatcherFactory#createInstance
* createInstance} that ensures that we are dealing with a Regexp
* implementation.
* Wrapper over RegexpMatcherFactory.createInstance that ensures that
* we are dealing with a Regexp implementation.
* *
* @since 1.3 * @since 1.3
*
* @see RegexpMatcherFactory#createInstance(String)
*/ */
protected Regexp createRegexpInstance(String classname) protected Regexp createRegexpInstance(String classname)
throws BuildException { throws BuildException {


Loading…
Cancel
Save