Browse Source

Fix bug 40882.

Note that the new test added to EchoTest.java would fail as indicated in the 
defect without the change to DefaultLogger.java.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@470639 13f79535-47bb-0310-9956-ffa450edef68
master
Steven M. Cohen 18 years ago
parent
commit
658b738914
2 changed files with 44 additions and 4 deletions
  1. +8
    -3
      src/main/org/apache/tools/ant/DefaultLogger.java
  2. +36
    -1
      src/tests/junit/org/apache/tools/ant/taskdefs/EchoTest.java

+ 8
- 3
src/main/org/apache/tools/ant/DefaultLogger.java View File

@@ -252,14 +252,19 @@ public class DefaultLogger implements BuildLogger {
new StringReader(event.getMessage())); new StringReader(event.getMessage()));
String line = r.readLine(); String line = r.readLine();
boolean first = true; boolean first = true;
while (line != null) {
if (!first) {
do {
if (first) {
if (line == null) {
message.append(label);
break;
}
} else {
message.append(StringUtils.LINE_SEP); message.append(StringUtils.LINE_SEP);
} }
first = false; first = false;
message.append(label).append(line); message.append(label).append(line);
line = r.readLine(); line = r.readLine();
}
} while (line != null);
} catch (IOException e) { } catch (IOException e) {
// shouldn't be possible // shouldn't be possible
message.append(label).append(event.getMessage()); message.append(label).append(event.getMessage());


+ 36
- 1
src/tests/junit/org/apache/tools/ant/taskdefs/EchoTest.java View File

@@ -18,7 +18,12 @@


package org.apache.tools.ant.taskdefs; package org.apache.tools.ant.taskdefs;


import java.io.ByteArrayOutputStream;
import java.io.PrintStream;

import org.apache.tools.ant.BuildFileTest; import org.apache.tools.ant.BuildFileTest;
import org.apache.tools.ant.DefaultLogger;
import org.apache.tools.ant.Project;


/** /**
*/ */
@@ -39,8 +44,16 @@ public class EchoTest extends BuildFileTest {
// Output an empty String // Output an empty String
public void test1() { public void test1() {
expectLog("test1", ""); expectLog("test1", "");
expectOutput("test1","");
} }

public void testLogBlankEcho() {
EchoTestLogger logger = new EchoTestLogger();
getProject().addBuildListener(logger);
getProject().executeTarget("test1");
assertEquals(" [echo] ", logger.lastLoggedMessage );
}
// Output 'OUTPUT OF ECHO' // Output 'OUTPUT OF ECHO'
public void test2() { public void test2() {
expectLog("test2", "OUTPUT OF ECHO"); expectLog("test2", "OUTPUT OF ECHO");
@@ -74,4 +87,26 @@ public class EchoTest extends BuildFileTest {
public void testUTF8Encoding() throws Exception { public void testUTF8Encoding() throws Exception {
executeTarget("testUTF8Encoding"); executeTarget("testUTF8Encoding");
} }
private class EchoTestLogger extends DefaultLogger {
String lastLoggedMessage;
/**
*
*/
public EchoTestLogger() {
super();
this.setMessageOutputLevel(Project.MSG_DEBUG);
this.setOutputPrintStream(new PrintStream(new ByteArrayOutputStream(256)));
this.setErrorPrintStream(new PrintStream(new ByteArrayOutputStream(256)));
}
/*
* @param message
*/
protected void log(String message) {
this.lastLoggedMessage = message;
}
}
} }

Loading…
Cancel
Save