From 65190d753db9ed4e1953cf506c2f8cf6392d9f9e Mon Sep 17 00:00:00 2001
From: Steve Loughran <stevel@apache.org>
Date: Sun, 15 May 2005 21:13:06 +0000
Subject: [PATCH] scp doc tweakage.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@278267 13f79535-47bb-0310-9956-ffa450edef68
---
 docs/manual/OptionalTasks/scp.html | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/docs/manual/OptionalTasks/scp.html b/docs/manual/OptionalTasks/scp.html
index 81557a767..3f129a42c 100644
--- a/docs/manual/OptionalTasks/scp.html
+++ b/docs/manual/OptionalTasks/scp.html
@@ -13,7 +13,7 @@
 
 <p><em>since Ant 1.6</em></p>
 
-<p>Copies a file or FileSet to or from a remote machine running SSH daemon.
+<p>Copies a file or FileSet to or from a (remote) machine running an SSH daemon.
 FileSet <i>only</i> works for copying files from the local machine to a
 remote machine.</p>
 
@@ -210,15 +210,22 @@ authentication.</b></p>
 
 <p><strong>Security Note:</strong>  Hard coding passwords and/or usernames
 in scp task can be a serious security hole.  Consider using variable
-substitution and include the password on the command line.  For example:<br>
+substitution and include the password on the command line.  For example:
+<p>
 <pre>
     &lt;scp todir=&quot;${username}:${password}@host:/dir&quot; ...&gt;
 </pre>
-Invoke ant with the following command line:
+Invoking ant with the following command line:
 <pre>
     ant -Dusername=me -Dpassword=mypassword target1 target2
 </pre>
-</p>
+
+Is slightly better, but the username/password is exposed to all users on an Unix
+system (via the ps command). The best approach is to use the
+<code>&lt;input&gt;</code> task and/or retrieve the password from a (secured)
+.properties file.
+
+<p>
 
 <p><strong>Unix Note:</strong> File permissions are not retained when files
 are copied; they end up with the default <code>UMASK</code> permissions