Tidy javadoc and use isEmpty()

src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java

@@ -170,9 +170,9 @@ public class AntClassLoaderTest {
     }
 
     /**
-     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=47593">
-     *     bug 47593, request to log the name of corrupt zip files from which
-     *     classes cannot be loaded</a>
+     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=47593">bug 47593</a>
+     *     request to log the name of corrupt zip files from which
+     *     classes cannot be loaded
      */
     @Test
     public void testInvalidZipException() {
@@ -204,8 +204,7 @@ public class AntClassLoaderTest {
      * Asserts that getResources won't return resources that cannot be
      * seen by AntClassLoader but by ClassLoader.this.parent.
      *
-     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=46752">
-     *     https://issues.apache.org/bugzilla/show_bug.cgi?id=46752</a>
+     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=46752">bug 46752</a>
      */
     @SuppressWarnings("resource")
     @Test

src/tests/junit/org/apache/tools/ant/IncludeTest.java

@@ -86,6 +86,7 @@ public class IncludeTest {
 
     @Test
     public void testTaskErrorInIncluding() {
+        // TODO the test breaks in IDE
         thrown.expect(BuildException.class);
         thrown.expect(hasProperty("location",
                 both(hasProperty("fileName", containsString("build.xml")))
@@ -104,6 +105,7 @@ public class IncludeTest {
 
     @Test
     public void testTaskErrorInIncluded() {
+        // TODO the test breaks in IDE
         thrown.expect(BuildException.class);
         thrown.expect(hasProperty("location",
                 both(hasProperty("fileName", containsString("included_file.xml")))

src/tests/junit/org/apache/tools/ant/ProjectTest.java

@@ -309,8 +309,7 @@ public class ProjectTest {
     }
 
     /**
-     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=47623">
-     *     https://issues.apache.org/bugzilla/show_bug.cgi?id=47623</a>
+     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=47623">bug 47623</a>
      */
     @Test
     public void testNullThrowableMessageLog() {

src/tests/junit/org/apache/tools/ant/TaskContainerTest.java

@@ -48,20 +48,18 @@ public class TaskContainerTest {
     public void testTaskdef() {
         buildRule.executeTarget("testTaskdef");
         assertThat("attribute worked", buildRule.getLog(),
-                containsString(("As attribute: it worked")));
-        assertThat("nested text worked", buildRule.getLog(),
-                containsString(("As nested text: it worked")));
+                containsString("As attribute: it worked"));
         assertThat("nested text worked", buildRule.getLog(),
-                containsString(("As nested task: it worked")));
+                containsString("As nested text: it worked"));
     }
 
     @Test
     public void testCaseInsensitive() {
         buildRule.executeTarget("testCaseInsensitive");
         assertThat("works outside of container", buildRule.getLog(),
-                containsString(("hello ")));
+                containsString("hello "));
         assertThat("works inside of container", buildRule.getLog(),
-                containsString(("world")));
+                containsString("world"));
     }
 
 }

src/tests/junit/org/apache/tools/ant/UnknownElementTest.java

@@ -49,8 +49,7 @@ public class UnknownElementTest {
     /**
      * Not really a UnknownElement test but rather one of "what
      * information is available in taskFinished".
-     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=26197">
-     *     https://issues.apache.org/bugzilla/show_bug.cgi?id=26197</a>
+     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=26197">bug 26197</a>
      */
     @Test
     @Ignore("Previously disabled through naming convention")

src/tests/junit/org/apache/tools/ant/XmlLoggerTest.java

@@ -23,9 +23,12 @@ import org.junit.Test;
 
 public class XmlLoggerTest {
 
+    /**
+     * "NPE in XmlLogger.buildFinished"
+     *
+     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=56850">bug 56850</a>
+     */
     @Test
-    // see https://issues.apache.org/bugzilla/show_bug.cgi?id=56850
-    // "NPE in XmlLogger.buildFinished"
     public void test() {
         final XmlLogger logger = new XmlLogger();
         final Cvs task = new Cvs();

src/tests/junit/org/apache/tools/ant/taskdefs/AntlibTest.java

@@ -58,7 +58,7 @@ public class AntlibTest {
     /**
      * Confirms that all matching resources will be used, so that you
      * can collect several antlibs in one Definer call.
-     * @see "http://issues.apache.org/bugzilla/show_bug.cgi?id=24024"
+     * @see <a href="http://issues.apache.org/bugzilla/show_bug.cgi?id=24024">bug 24024</a>
      */
     @Test
     public void testAntlibResource() {

src/tests/junit/org/apache/tools/ant/taskdefs/ParallelTest.java

@@ -164,7 +164,7 @@ public class ParallelTest {
     }
 
     /**
-     * @see "https://issues.apache.org/bugzilla/show_bug.cgi?id=55539"
+     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=55539">bug 55539</a>
      */
     @Test
     public void testSingleExit() {
@@ -177,7 +177,7 @@ public class ParallelTest {
     }
 
     /**
-     * @see "https://issues.apache.org/bugzilla/show_bug.cgi?id=55539"
+     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=55539">bug 55539</a>
      */
     @Test
     public void testExitAndOtherException() {

src/tests/junit/org/apache/tools/ant/taskdefs/SubAntTest.java

@@ -144,7 +144,7 @@ public class SubAntTest {
         }
 
         public void targetStarted(BuildEvent event) {
-            if (event.getTarget().getName().equals("")) {
+            if (event.getTarget().getName().isEmpty()) {
                 return;
             }
             if (error == null) {

src/tests/junit/org/apache/tools/ant/taskdefs/optional/vss/MSVSSTest.java

@@ -36,6 +36,7 @@ import org.junit.Rule;
 import org.junit.Test;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.fail;
 
 /**
@@ -445,7 +446,7 @@ public class MSVSSTest implements MSVSSConstants {
 
         while (testIndex < testLength) {
             try {
-                if (sGeneratedCmdLine[genIndex].equals("")) {
+                if (sGeneratedCmdLine[genIndex].isEmpty()) {
                     genIndex++;
                     continue;
                 }
@@ -462,13 +463,11 @@ public class MSVSSTest implements MSVSSConstants {
         // Count the number of empty strings
         int cnt = 0;
         for (String argument : sGeneratedCmdLine) {
-            if (argument.equals("")) {
+            if (argument.isEmpty()) {
                 cnt++;
             }
         }
-        if (genLength - cnt > sTestCmdLine.length) {
-            // We have extra elements
-            fail("extra args");
-        }
+        // We have extra elements
+        assertFalse("extra args", genLength - cnt > sTestCmdLine.length);
     }
 }

src/tests/junit/org/apache/tools/ant/util/DateUtilsTest.java

@@ -43,7 +43,9 @@ public class DateUtilsTest {
         assertEquals("2 minutes 1 second", text);
     }
 
-    // https://issues.apache.org/bugzilla/show_bug.cgi?id=44659
+    /**
+     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=44659">bug 44659</a>
+     */
     @Test
     public void testLongElapsedTime() {
         assertEquals("2926 minutes 13 seconds",

src/tests/junit/org/apache/tools/zip/ZipEntryTest.java

@@ -32,7 +32,6 @@ import static org.junit.Assert.fail;
  */
 public class ZipEntryTest {
 
-
     /**
      * test handling of extra fields
      */
@@ -203,8 +202,7 @@ public class ZipEntryTest {
 
     /**
      * Test case for
-     * <a href="https://issues.apache.org/jira/browse/COMPRESS-94"
-     * >COMPRESS-94</a>.
+     * <a href="https://issues.apache.org/jira/browse/COMPRESS-94">COMPRESS-94</a>
      */
     @Test
     public void testNotEquals() {