From 608b65a3e3663c63c63032d058b1c4a4498ed93c Mon Sep 17 00:00:00 2001 From: Stefan Bodewig Date: Sat, 9 Dec 2017 22:04:30 +0100 Subject: [PATCH] close streams to make files deletable on windows --- .../taskdefs/optional/i18n/TranslateTest.java | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/optional/i18n/TranslateTest.java b/src/tests/junit/org/apache/tools/ant/taskdefs/optional/i18n/TranslateTest.java index e58e5ce99..15564a7fb 100644 --- a/src/tests/junit/org/apache/tools/ant/taskdefs/optional/i18n/TranslateTest.java +++ b/src/tests/junit/org/apache/tools/ant/taskdefs/optional/i18n/TranslateTest.java @@ -71,16 +71,24 @@ public class TranslateTest { @SuppressWarnings("resource") FileInputStream fis1 = new FileInputStream(file1); - @SuppressWarnings("resource") - FileInputStream fis2 = new FileInputStream(file2); - int read = 0; - while ((read = fis1.read(buffer1)) != -1) { - fis2.read(buffer2); - for (int i = 0; i < read; ++i) { - if (buffer1[i] != buffer2[i]) { - return false; + try { + @SuppressWarnings("resource") + FileInputStream fis2 = new FileInputStream(file2); + try { + int read = 0; + while ((read = fis1.read(buffer1)) != -1) { + fis2.read(buffer2); + for (int i = 0; i < read; ++i) { + if (buffer1[i] != buffer2[i]) { + return false; + } + } } + } finally { + fis2.close(); } + } finally { + fis1.close(); } return true; }