From 5a4fe63383258162c3374aebd048dee87efb4fd6 Mon Sep 17 00:00:00 2001 From: Matthew Jason Benson Date: Tue, 9 Aug 2005 15:30:34 +0000 Subject: [PATCH] Fix comparison w/ exposed NPE PR: 36093 Obtained from: Dave Brosius git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@278513 13f79535-47bb-0310-9956-ffa450edef68 --- src/main/org/apache/tools/ant/taskdefs/SignJar.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/org/apache/tools/ant/taskdefs/SignJar.java b/src/main/org/apache/tools/ant/taskdefs/SignJar.java index 402469b6b..220aed6b1 100644 --- a/src/main/org/apache/tools/ant/taskdefs/SignJar.java +++ b/src/main/org/apache/tools/ant/taskdefs/SignJar.java @@ -447,7 +447,7 @@ public class SignJar extends AbstractJarSignerTask { * @return true if the signedjarFile is considered up to date */ protected boolean isUpToDate(File jarFile, File signedjarFile) { - if (null == jarFile && !jarFile.exists()) { + if (null == jarFile || !jarFile.exists()) { //these are pathological cases, but retained in case somebody //subclassed us. return false;