From 561706f38cb5df71cf79785f4c6e5607de4dafa7 Mon Sep 17 00:00:00 2001 From: Peter Reilly Date: Thu, 27 Mar 2008 17:09:53 +0000 Subject: [PATCH] Bugzilla 44689: NPE with multiple targets and id's in task git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@641903 13f79535-47bb-0310-9956-ffa450edef68 --- src/main/org/apache/tools/ant/UnknownElement.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/main/org/apache/tools/ant/UnknownElement.java b/src/main/org/apache/tools/ant/UnknownElement.java index 927324359..6aa9eb41c 100644 --- a/src/main/org/apache/tools/ant/UnknownElement.java +++ b/src/main/org/apache/tools/ant/UnknownElement.java @@ -288,11 +288,14 @@ public class UnknownElement extends Task { ((Task) realThing).execute(); } } finally { - // Finished executing the task, null it to allow + // Finished executing the task + // null it (unless it has an ID) to allow // GC do its job // If this UE is used again, a new "realthing" will be made - realThing = null; - getWrapper().setProxy(null); + if (getWrapper().getId() == null) { + realThing = null; + getWrapper().setProxy(null); + } } }