diff --git a/src/etc/checkstyle/checkstyle-frames-sortby-check.xsl b/src/etc/checkstyle/checkstyle-frames-sortby-check.xsl index 060f87885..1f02b9067 100644 --- a/src/etc/checkstyle/checkstyle-frames-sortby-check.xsl +++ b/src/etc/checkstyle/checkstyle-frames-sortby-check.xsl @@ -22,7 +22,7 @@ --> - + @@ -43,7 +43,7 @@ - + @@ -76,15 +76,15 @@ + Generates the navigation bar. + --> - + + -->
@@ -120,13 +120,13 @@
-
+ @@ -157,7 +157,7 @@ Generates the data rows for the current check module. Ignores errors in the current file from other modules. @param node the file with the errors - @param filter full qualified module name + @param filter full qualified module name --> @@ -180,68 +180,68 @@ - - body { + body { font:normal 80% arial,helvetica,sanserif; - color: black; - background-color: white; - margin: 0; - padding: 1em; + color: black; + background-color: white; + margin: 0; + padding: 1em; min-width: 41em; - } - h1 { + } + h1 { font-weight:bold; font-size:140%; - margin: 0 0 0.7em; - padding: 0.3em; - text-align: center; - background-color: #eee; - border: 2px ridge silver; - } - html>body h1 { + margin: 0 0 0.7em; + padding: 0.3em; + text-align: center; + background-color: #eee; + border: 2px ridge silver; + } + html>body h1 { border-color: gray; - } - - ul#navigation { - font-size: 0.83em; - float: left; width: 18em; - margin: 0 0 1.2em; padding: 0; - border: 1px dashed silver; - } - ul#navigation li { - list-style: none; - margin: 0; padding: 0.2em; - } - ul#navigation a { - display: block; - padding: 0.2em; - font-weight: bold; - } - ul#navigation a:link { - color: black; background-color: #eee; - } - ul#navigation a:visited { - color: #666; background-color: #eee; - } - ul#navigation a:hover { - color: red; background-color: white; - } - ul#navigation a:active { - color: white; background-color: gray; } - div#content { - margin: 0 1em 1em 16em; - padding: 0 1em; - } - * html div#content { - height: 1em; /* Workaround 3-Pixel-Bug of Internet Explorers */ - } - div#content h2 { + ul#navigation { + font-size: 0.83em; + float: left; width: 18em; + margin: 0 0 1.2em; padding: 0; + border: 1px dashed silver; + } + ul#navigation li { + list-style: none; + margin: 0; padding: 0.2em; + } + ul#navigation a { + display: block; + padding: 0.2em; + font-weight: bold; + } + ul#navigation a:link { + color: black; background-color: #eee; + } + ul#navigation a:visited { + color: #666; background-color: #eee; + } + ul#navigation a:hover { + color: red; background-color: white; + } + ul#navigation a:active { + color: white; background-color: gray; + } + + div#content { + margin: 0 1em 1em 16em; + padding: 0 1em; + } + * html div#content { + height: 1em; /* Workaround 3-Pixel-Bug of Internet Explorers */ + } + div#content h2 { font-size:100%; font-weight:bold; background: #525D76; @@ -251,11 +251,11 @@ margin-right: 2px; margin-left: 2px; margin-bottom: 0; - } - div#content p { - font-size: 1em; - margin: 1em 0; - } + } + div#content p { + font-size: 1em; + margin: 1em 0; + } table { width:100%; border-collapse:collapse; @@ -275,62 +275,62 @@ table tr:nth-child(even) td { background: #fff; } - + - - /* + /* * Hides all "hideable" div-containers */ function hideAll() { allElements = document.getElementsByTagName("div"); - for (i = 0; i < allElements.length; i++) { - if (allElements[i].className=="hideable") { - allElements[i].style.display="none"; - } - } - return; - } - - /* + for (i = 0; i < allElements.length; i++) { + if (allElements[i].className=="hideable") { + allElements[i].style.display="none"; + } + } + return; + } + + /* * Shows one div-container and hides the other. * @param id id of the element to show */ - function change(id) { - hideAll(); - e = document.getElementById(id); - if (e.style.display=="none") { - e.style.display=""; - } - window.scrollTo(0, 0); - return; - } - - /* + function change(id) { + hideAll(); + e = document.getElementById(id); + if (e.style.display=="none") { + e.style.display=""; + } + window.scrollTo(0, 0); + return; + } + + /* * Shows only the first data row. * Used in body:onload so the user could directly see some messages. */ function openFirst() { hideAll(); - for (i = 0; i < allElements.length; i++) { - if (allElements[i].className=="hideable") { + for (i = 0; i < allElements.length; i++) { + if (allElements[i].className=="hideable") { allElements[i].style.display=""; - return; - } - } - return; + return; + } + } + return; } diff --git a/src/etc/jdepend-frames.xsl b/src/etc/jdepend-frames.xsl index 802873450..45af8dbc6 100644 --- a/src/etc/jdepend-frames.xsl +++ b/src/etc/jdepend-frames.xsl @@ -19,7 +19,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - + --> -

There are no cyclic dependancies.

+

There are no cyclic dependencies.

#CY

@@ -373,10 +373,10 @@

The range for this metric is 0 to 1, with A=0 indicating a completely concrete package and A=1 indicating a completely abstract package.

Instability

The ratio of efferent coupling (Ce) to total coupling (Ce / (Ce + Ca)). This metric is an indicator of the package's resilience to change.

-

The range for this metric is 0 to 1, with I=0 indicating a completely stable package and I=1 indicating a completely instable package.

+

The range for this metric is 0 to 1, with I=0 indicating a completely stable package and I=1 indicating a completely unstable package.

Distance

The perpendicular distance of a package from the idealized line A + I = 1. This metric is an indicator of the package's balance between abstractness and stability.

-

A package squarely on the main sequence is optimally balanced with respect to its abstractness and stability. Ideal packages are either completely abstract and stable (x=0, y=1) or completely concrete and instable (x=1, y=0).

+

A package squarely on the main sequence is optimally balanced with respect to its abstractness and stability. Ideal packages are either completely abstract and stable (x=0, y=1) or completely concrete and unstable (x=1, y=0).

The range for this metric is 0 to 1, with D=0 indicating a package that is coincident with the main sequence and D=1 indicating a package that is as far from the main sequence as possible.

@@ -416,7 +416,7 @@ Creates an html file that contains a link to all package links in overview-packa - + @@ -465,7 +465,7 @@ Creates an html file that contains a link to all package links in overview-cycle - + @@ -476,7 +476,7 @@ Creates an html file that contains a link to all package links in overview-cycle - +
Designed for use with JDepend and Ant.Designed for use with JDepend and Ant.

diff --git a/src/etc/jdepend.xsl b/src/etc/jdepend.xsl index b3a3778bb..abec6c56d 100644 --- a/src/etc/jdepend.xsl +++ b/src/etc/jdepend.xsl @@ -18,13 +18,13 @@ limitations under the License. --> - + JDepend Analysis - + - - + - +

JDepend Analysis

Designed for use with JDepend and Ant.

-
- +
+

Summary

@@ -100,7 +99,7 @@ [cycles] [explanations]
- + @@ -112,7 +111,6 @@ - @@ -132,8 +130,6 @@ - - @@ -148,7 +144,7 @@
PackageAbstractness Instability Distance
- +

Packages

@@ -157,12 +153,12 @@ [cycles] [explanations]
- +

PK

- + @@ -170,7 +166,7 @@
Afferent Couplings: Efferent Couplings: Instability: Distance:
- + @@ -221,7 +217,7 @@
Abstract Classes
- +

Cycles

@@ -230,7 +226,7 @@ [cycles] [explanations]
- +

There are no cyclic dependancies.

@@ -240,7 +236,7 @@

- +

Explanations

@@ -249,26 +245,26 @@ [cycles] [explanations]
- +

The following explanations are for quick reference and are lifted directly from the original JDepend documentation.

- +

Number of Classes

The number of concrete and abstract classes (and interfaces) in the package is an indicator of the extensibility of the package.

Afferent Couplings

The number of other packages that depend upon classes within the package is an indicator of the package's responsibility.

Efferent Couplings

The number of other packages that the classes in the package depend upon is an indicator of the package's independence.

-

Abstractness

+

Abstractness

The ratio of the number of abstract classes (and interfaces) in the analyzed package to the total number of classes in the analyzed package.

The range for this metric is 0 to 1, with A=0 indicating a completely concrete package and A=1 indicating a completely abstract package.

Instability

The ratio of efferent coupling (Ce) to total coupling (Ce / (Ce + Ca)). This metric is an indicator of the package's resilience to change.

-

The range for this metric is 0 to 1, with I=0 indicating a completely stable package and I=1 indicating a completely instable package.

+

The range for this metric is 0 to 1, with I=0 indicating a completely stable package and I=1 indicating a completely unstable package.

Distance

The perpendicular distance of a package from the idealized line A + I = 1. This metric is an indicator of the package's balance between abstractness and stability.

-

A package squarely on the main sequence is optimally balanced with respect to its abstractness and stability. Ideal packages are either completely abstract and stable (x=0, y=1) or completely concrete and instable (x=1, y=0).

+

A package squarely on the main sequence is optimally balanced with respect to its abstractness and stability. Ideal packages are either completely abstract and stable (x=0, y=1) or completely concrete and unstable (x=1, y=0).

The range for this metric is 0 to 1, with D=0 indicating a package that is coincident with the main sequence and D=1 indicating a package that is as far from the main sequence as possible.

- +
diff --git a/src/etc/testcases/taskdefs/exec/exec.xml b/src/etc/testcases/taskdefs/exec/exec.xml index 20e56565f..a04c62100 100644 --- a/src/etc/testcases/taskdefs/exec/exec.xml +++ b/src/etc/testcases/taskdefs/exec/exec.xml @@ -20,9 +20,9 @@ - + - + diff --git a/src/etc/testcases/taskdefs/optional/unix/symlink.xml b/src/etc/testcases/taskdefs/optional/unix/symlink.xml index 134f29f18..2a55fe08c 100644 --- a/src/etc/testcases/taskdefs/optional/unix/symlink.xml +++ b/src/etc/testcases/taskdefs/optional/unix/symlink.xml @@ -19,11 +19,11 @@ - + - + - + - - - - @@ -78,7 +78,7 @@ - @@ -96,19 +96,19 @@ - - - + - - @@ -239,7 +239,7 @@ - - @@ -321,7 +321,7 @@ property="test.recreate.dirlink.recreated"/> - @@ -329,13 +329,13 @@ - diff --git a/src/etc/testcases/taskdefs/optional/xml/endpiece-noSchema-invalid.xml b/src/etc/testcases/taskdefs/optional/xml/endpiece-noSchema-invalid.xml index ec5808549..7cfa0f5e6 100644 --- a/src/etc/testcases/taskdefs/optional/xml/endpiece-noSchema-invalid.xml +++ b/src/etc/testcases/taskdefs/optional/xml/endpiece-noSchema-invalid.xml @@ -16,15 +16,14 @@ limitations under the License. --> -
- With a little luck, the network will pick me up. + With a little luck, the network will pick me up. This is Ripley - last survivor of The Nostromo - signing off.
- + -
diff --git a/src/etc/testcases/taskdefs/optional/xml/endpiece-noSchema.xml b/src/etc/testcases/taskdefs/optional/xml/endpiece-noSchema.xml index 7ae559d90..99f9606d9 100644 --- a/src/etc/testcases/taskdefs/optional/xml/endpiece-noSchema.xml +++ b/src/etc/testcases/taskdefs/optional/xml/endpiece-noSchema.xml @@ -16,13 +16,12 @@ limitations under the License. --> -
- With a little luck, the network will pick me up. + With a little luck, the network will pick me up. This is Ripley - last survivor of The Nostromo - signing off.
-
diff --git a/src/etc/testcases/types/assertions.xml b/src/etc/testcases/types/assertions.xml index a849a0b94..dfe0de408 100644 --- a/src/etc/testcases/types/assertions.xml +++ b/src/etc/testcases/types/assertions.xml @@ -27,175 +27,171 @@ includes="*.java" source="${source}" debug="true" - destdir="${output}" - /> + destdir="${output}"/>
- + - - - + + + + classname="${classname}" + classpathref="assert.classpath"> - + - + - - - + + + - + - + - - - + classname="${classname}" + classpathref="assert.classpath"> + + + - + - + - - - - - + classname="${classname}" + classpathref="assert.classpath"> + + + + + - + - + - - - - + classname="${classname}" + classpathref="assert.classpath"> + + + + - - + + - - - - - + + + + + + classname="${classname}" + classpathref="assert.classpath"> - + + classname="${classname}" + classpathref="assert.classpath"> - + - + + classname="${classname}" + classpathref="assert.classpath"> - + - - + + - - - - - + + + + + + classname="${classname}" + classpathref="assert.classpath"> - - + + - - - + + - + - - - - + + + + - + + so there is some defect in pass-on of assertions that + is causing the problem --> - + - + - - + + diff --git a/src/etc/testcases/types/selectors.xml b/src/etc/testcases/types/selectors.xml index 5a80d04a0..301c048bf 100644 --- a/src/etc/testcases/types/selectors.xml +++ b/src/etc/testcases/types/selectors.xml @@ -25,40 +25,40 @@ + value="${output}/selectortest"/> + value="${output}/regexpseltestsrc"/> + value="${output}/regexpseltestdest"/> + value="${output}/selectortest2"/> - - - - - + + + + + + tofile="${test.dir}/asf-logo.gif.md5"/> + tofile="${test.dir}/asf-logo.gif.bz2"/> + tofile="${test.dir}/asf-logo.gif.gz"/> + tofile="${test.dir}/copy.filterset.filtered"/> + tofile="${test.dir}/zip/asf-logo.gif.zip"/> + tofile="${test.dir}/tar/asf-logo.gif.tar"/> + tofile="${test.dir}/tar/asf-logo-huge.tar.gz"/> + tofile="${test.dir}/tar/gz/asf-logo.gif.tar.gz"/> + tofile="${test.dir}/tar/bz2/asf-logo.gif.tar.bz2"/> + tofile="${test.dir}/tar/bz2/asf-logo-huge.tar.bz2"/> @@ -69,23 +69,23 @@ + datetime="01/01/2001 12:00 AM"/> + datetime="04/15/2002 2:30 PM"/> + datetime="05/10/2002 2:30 PM"/> + datetime="05/10/2002 2:29 PM"/> + datetime="05/10/2002 2:29 AM"/> - - - - - + + + + + @@ -97,18 +97,18 @@ - - + + - - + + - - + + @@ -185,7 +185,7 @@ - + @@ -193,7 +193,7 @@ - + @@ -203,7 +203,7 @@ - + @@ -251,11 +251,9 @@ - + @@ -267,15 +265,15 @@ - + - - - + + + @@ -292,7 +290,7 @@ - + @@ -309,7 +307,7 @@ - + @@ -337,20 +335,20 @@ - + - + - - + + diff --git a/src/main/org/apache/tools/ant/Diagnostics.java b/src/main/org/apache/tools/ant/Diagnostics.java index 7434433cf..ca97a85e2 100644 --- a/src/main/org/apache/tools/ant/Diagnostics.java +++ b/src/main/org/apache/tools/ant/Diagnostics.java @@ -588,7 +588,7 @@ public final class Diagnostics { long drift = filetime - now; tempFile.delete(); - out.print("Temp dir is writeable"); + out.print("Temp dir is writable"); if (total != TEST_FILE_SIZE * KILOBYTE) { out.println(", but seems to be full. Wrote " + (TEST_FILE_SIZE * KILOBYTE) diff --git a/src/main/org/apache/tools/ant/taskdefs/Ant.java b/src/main/org/apache/tools/ant/taskdefs/Ant.java index f9079ab7e..a07923287 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Ant.java +++ b/src/main/org/apache/tools/ant/taskdefs/Ant.java @@ -574,7 +574,7 @@ public class Ant extends Task { log("Adding clone of reference " + oldKey, Project.MSG_DEBUG); } } catch (Exception e) { - // not Clonable + // not Cloneable } if (copy instanceof ProjectComponent) { diff --git a/src/main/org/apache/tools/ant/taskdefs/Checksum.java b/src/main/org/apache/tools/ant/taskdefs/Checksum.java index 1692392d8..a488d7eba 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Checksum.java +++ b/src/main/org/apache/tools/ant/taskdefs/Checksum.java @@ -663,7 +663,7 @@ public class Checksum extends MatchingTask implements Condition { /** * Get the default value - CHECKSUM. - * @return the defaul value. + * @return the default value. */ public static FormatElement getDefault() { FormatElement e = new FormatElement(); diff --git a/src/main/org/apache/tools/ant/taskdefs/Exec.java b/src/main/org/apache/tools/ant/taskdefs/Exec.java index 75a9f70b4..7486957ed 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Exec.java +++ b/src/main/org/apache/tools/ant/taskdefs/Exec.java @@ -217,7 +217,7 @@ public class Exec extends Task { /** * Log an output message. - * @param line the line to putput + * @param line the line to output * @param messageLevel the level of logging - ignored * if output is going to a file */ diff --git a/src/main/org/apache/tools/ant/taskdefs/SignJar.java b/src/main/org/apache/tools/ant/taskdefs/SignJar.java index 16d6993b9..95b27dbc3 100644 --- a/src/main/org/apache/tools/ant/taskdefs/SignJar.java +++ b/src/main/org/apache/tools/ant/taskdefs/SignJar.java @@ -602,7 +602,7 @@ public class SignJar extends AbstractJarSignerTask { * either file doesn't exist, or the destfile has an out of date timestamp, * then the return value is false.

* - *

If we are signing ourself, the check {@link #isSigned(File)} is used to + *

If we are signing ourselves, the check {@link #isSigned(File)} is used to * trigger the process.

* * @param jarFile the unsigned jar file diff --git a/src/main/org/apache/tools/ant/taskdefs/Zip.java b/src/main/org/apache/tools/ant/taskdefs/Zip.java index 65bfdec9e..225e038b8 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Zip.java +++ b/src/main/org/apache/tools/ant/taskdefs/Zip.java @@ -2136,7 +2136,7 @@ public class Zip extends MatchingTask { /** * Policy for creation of Unicode extra fields: never, always or - * not-encodeable. + * not-encodable. * * @since Ant 1.8.0 */ diff --git a/src/main/org/apache/tools/ant/taskdefs/condition/IsReachable.java b/src/main/org/apache/tools/ant/taskdefs/condition/IsReachable.java index e78d94bdf..9143b5f63 100644 --- a/src/main/org/apache/tools/ant/taskdefs/condition/IsReachable.java +++ b/src/main/org/apache/tools/ant/taskdefs/condition/IsReachable.java @@ -78,7 +78,7 @@ public class IsReachable extends ProjectComponent implements Condition { /** Error message when url and host are specified. */ public static final String ERROR_BOTH_TARGETS = "Both url and host have been specified"; - /** Error message when no reachably test avail. */ + /** Error message when no reachability test avail. */ public static final String MSG_NO_REACHABLE_TEST = "cannot do a proper reachability test on this Java version"; /** Error message when an invalid url is used. */ @@ -121,7 +121,7 @@ public class IsReachable extends ProjectComponent implements Condition { } /** - * emptyness test + * emptiness test * * @param string param to check * diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java index 7a34876c8..f341c1519 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java @@ -389,7 +389,7 @@ public class GenericDeploymentTool implements EJBDeploymentTool { try { handler = getDescriptorHandler(config.srcDir); - // Retreive the files to be added to JAR from EJB descriptor + // Retrieve the files to be added to JAR from EJB descriptor Hashtable ejbFiles = parseEjbFiles(descriptorFileName, saxParser); // Add any support classes specified in the build file @@ -688,7 +688,7 @@ public class GenericDeploymentTool implements EJBDeploymentTool { * If the file does not exist the global manifest from the config is used * otherwise the default Ant manifest will be used. * - * @param prefix the prefix where to llook for the manifest file based on + * @param prefix the prefix where to look for the manifest file based on * the naming convention. * * @return the manifest file or null if the manifest file does not exist diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/JonasDeploymentTool.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/JonasDeploymentTool.java index 33e125176..1f81e559f 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/JonasDeploymentTool.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/JonasDeploymentTool.java @@ -768,7 +768,7 @@ public class JonasDeploymentTool extends GenericDeploymentTool { } /* ----------------------------------------------------------------------------------- */ - /* utilitary methods */ + /* utility methods */ /* ----------------------------------------------------------------------------------- */ /** @@ -798,7 +798,7 @@ public class JonasDeploymentTool extends GenericDeploymentTool { /** * Add a file to the a given hashtable. If the file is a directory, add - * recursivly all the files inside to the hashtable. + * recursively all the files inside to the hashtable. * * @param file the file to add. * @param rootDir the current sub-directory to scan. diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java b/src/main/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java index e5893206b..767d07ace 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java @@ -153,7 +153,7 @@ public class WLJspc extends MatchingTask { args[j++] = "-docroot"; args[j++] = sourceDirectory.getAbsolutePath().trim(); args[j++] = "-keepgenerated"; - //Call compiler as class... dont want to fork again + //Call compiler as class... don't want to fork again //Use classic compiler -- can be parameterised? args[j++] = "-compilerclass"; args[j++] = "sun.tools.javac.Main"; diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java index 028397e87..21ae7babe 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java @@ -106,7 +106,7 @@ public class JUnitLauncherTask extends Task { if (this.classPath == null) { // create a "wrapper" path which can hold on to multiple // paths that get passed to this method (if at all the task in the build is - // configured with multiple classpaht elements) + // configured with multiple classpath elements) this.classPath = new Path(getProject()); } this.classPath.add(path); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/TestRequest.java b/src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/TestRequest.java index 0f2f67755..a8fac657b 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/TestRequest.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/TestRequest.java @@ -31,7 +31,7 @@ import java.util.List; final class TestRequest implements AutoCloseable { private final TestDefinition ownerTest; private final LauncherDiscoveryRequestBuilder discoveryRequest; - private final List closables = new ArrayList<>(); + private final List closeables = new ArrayList<>(); private final List interestedInSysOut = new ArrayList<>(); private final List interestedInSysErr = new ArrayList<>(); @@ -53,7 +53,7 @@ final class TestRequest implements AutoCloseable { if (closeable == null) { return; } - this.closables.add(closeable); + this.closeables.add(closeable); } void addSysOutInterest(final TestResultFormatter out) { @@ -81,10 +81,10 @@ final class TestRequest implements AutoCloseable { } public void close() throws Exception { - if (this.closables.isEmpty()) { + if (this.closeables.isEmpty()) { return; } - for (final Closeable closeable : closables) { + for (final Closeable closeable : closeables) { closeable.close(); } } diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java index 901ff06a8..1cc4dae0f 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java @@ -827,7 +827,7 @@ public class FTP extends Task implements FTPTaskConfig { if (!isCaseSensitive() && (remoteSystemCaseSensitive || !remoteSensitivityChecked)) { currentPathElement = - findPathElementCaseUnsensitive(this.curpwd, + findPathElementCaseInsensitive(this.curpwd, currentPathElement); if (currentPathElement == null) { return; @@ -854,7 +854,7 @@ public class FTP extends Task implements FTPTaskConfig { * @param soughtPathElement what is being sought * @return the first file found or null if not found */ - private String findPathElementCaseUnsensitive(String parentPath, + private String findPathElementCaseInsensitive(String parentPath, String soughtPathElement) { // we are already in the right path, so the second parameter // is false diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java index 0d877aaec..b8610181a 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java @@ -729,7 +729,7 @@ public class FTPTaskMirrorImpl implements FTPTaskMirror { if (!this.client.changeWorkingDirectory(currentPathElement)) { if (!isCaseSensitive() && (remoteSystemCaseSensitive || !remoteSensitivityChecked)) { - currentPathElement = findPathElementCaseUnsensitive(this.curpwd, + currentPathElement = findPathElementCaseInsensitive(this.curpwd, currentPathElement); if (currentPathElement == null) { return; @@ -752,7 +752,7 @@ public class FTPTaskMirrorImpl implements FTPTaskMirror { * @param soughtPathElement what is being sought * @return the first file found or null if not found */ - private String findPathElementCaseUnsensitive(String parentPath, + private String findPathElementCaseInsensitive(String parentPath, String soughtPathElement) { // we are already in the right path, so the second parameter // is false diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java b/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java index 908639388..7ac945372 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java @@ -772,7 +772,7 @@ public abstract class MSVSS extends Task implements MSVSSConstants { } /** - * Extension of EnumeratedAttribute to hold the values for writable filess. + * Extension of EnumeratedAttribute to hold the values for writable files. */ public static class WritableFiles extends EnumeratedAttribute { /** diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSSCHECKIN.java b/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSSCHECKIN.java index f9521aa07..c83cb446d 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSSCHECKIN.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSSCHECKIN.java @@ -95,7 +95,7 @@ public class MSVSSCHECKIN extends MSVSS { } /** - * Autoresponce behaviour. Valid options are Y and N. + * Autoresponse behaviour. Valid options are Y and N. * * @param response The auto response value. */ diff --git a/src/main/org/apache/tools/ant/types/XMLCatalog.java b/src/main/org/apache/tools/ant/types/XMLCatalog.java index 528ba606d..9642a17db 100644 --- a/src/main/org/apache/tools/ant/types/XMLCatalog.java +++ b/src/main/org/apache/tools/ant/types/XMLCatalog.java @@ -118,7 +118,7 @@ import org.xml.sax.XMLReader; public class XMLCatalog extends DataType implements EntityResolver, URIResolver { - /** helper for some File.toURL connversions */ + /** helper for some File.toURL conversions */ private static final FileUtils FILE_UTILS = FileUtils.getFileUtils(); //-- Fields ---------------------------------------------------------------- diff --git a/src/main/org/apache/tools/ant/util/FileUtils.java b/src/main/org/apache/tools/ant/util/FileUtils.java index 7764cebc5..e3316e5cd 100644 --- a/src/main/org/apache/tools/ant/util/FileUtils.java +++ b/src/main/org/apache/tools/ant/util/FileUtils.java @@ -1228,7 +1228,7 @@ public class FileUtils { * @return true if path starts with leading; false otherwise. * @since Ant 1.10.5 * @throws IOException if resolveSymlinks is true and invoking - * getCanonicaPath on either argument throws an exception + * getCanonicalPath on either argument throws an exception */ public boolean isLeadingPath(File leading, File path, boolean resolveSymlinks) throws IOException { diff --git a/src/main/org/apache/tools/ant/util/ProxySetup.java b/src/main/org/apache/tools/ant/util/ProxySetup.java index 60f9eb7cf..6757308d7 100644 --- a/src/main/org/apache/tools/ant/util/ProxySetup.java +++ b/src/main/org/apache/tools/ant/util/ProxySetup.java @@ -105,7 +105,7 @@ public class ProxySetup { owner.log(message, Project.MSG_DEBUG); System.setProperty(USE_SYSTEM_PROXIES, proxies); } catch (SecurityException e) { - //log security exceptions and continue; it aint that + //log security exceptions and continue; it ain't that //important and may be quite common running Ant embedded. owner.log("Security Exception when " + message); } diff --git a/src/main/org/apache/tools/zip/ZipOutputStream.java b/src/main/org/apache/tools/zip/ZipOutputStream.java index 025407b41..ac3567412 100644 --- a/src/main/org/apache/tools/zip/ZipOutputStream.java +++ b/src/main/org/apache/tools/zip/ZipOutputStream.java @@ -660,10 +660,10 @@ public class ZipOutputStream extends FilterOutputStream { } private boolean isZip64Required(ZipEntry entry1, Zip64Mode requestedMode) { - return requestedMode == Zip64Mode.Always || isTooLageForZip32(entry1); + return requestedMode == Zip64Mode.Always || isTooLargeForZip32(entry1); } - private boolean isTooLageForZip32(ZipEntry zipArchiveEntry) { + private boolean isTooLargeForZip32(ZipEntry zipArchiveEntry) { return zipArchiveEntry.getSize() >= ZIP64_MAGIC || zipArchiveEntry.getCompressedSize() >= ZIP64_MAGIC; } diff --git a/src/script/antenv.cmd b/src/script/antenv.cmd index 7913801d1..6743a850a 100644 --- a/src/script/antenv.cmd +++ b/src/script/antenv.cmd @@ -61,7 +61,7 @@ if classes \= '' then classpath = prepend(classpath classes) classpath = prepend(classpath ANT_HOME || '\lib\ant-launcher.jar') 'SET CLASSPATH=' || classpath -/* Setting classpathes, options and arguments */ +/* Setting classpaths, options and arguments */ envset = _getenv_('envset') if cp\='' then interpret 'call "' || envset || '"' '"; CLASSPATH"' '"' || cp || '"' if lcp\='' then interpret 'call "' || envset || '"' '"; LOCALCLASSPATH"' '"' || lcp || '"' diff --git a/src/script/envset.cmd b/src/script/envset.cmd index 3b074193e..2332c6122 100644 --- a/src/script/envset.cmd +++ b/src/script/envset.cmd @@ -37,7 +37,7 @@ not interpreted the parameters are changed to name=expanded_name Other options have optional equal sign. If it is found, only the part after -the equal sign will be oprionally expanded. +the equal sign will be optionally expanded. If the parameter is the minus sign, the next parameter will not be expanded. If the parameter is a single dot, it will be replaced with the value of the diff --git a/src/tests/antunit/taskdefs/echoxml-test.xml b/src/tests/antunit/taskdefs/echoxml-test.xml index d461d3d83..0c097bd24 100644 --- a/src/tests/antunit/taskdefs/echoxml-test.xml +++ b/src/tests/antunit/taskdefs/echoxml-test.xml @@ -79,7 +79,7 @@ - + diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/UnzipTest.java b/src/tests/junit/org/apache/tools/ant/taskdefs/UnzipTest.java index 355fe9c71..2782b4f14 100644 --- a/src/tests/junit/org/apache/tools/ant/taskdefs/UnzipTest.java +++ b/src/tests/junit/org/apache/tools/ant/taskdefs/UnzipTest.java @@ -197,7 +197,7 @@ public class UnzipTest { /** * assert that a file exists, relative to the project - * @param message message if there is no mpatch + * @param message message if there is no match * @param filename filename to resolve against the project */ private void assertFileExists(String message, String filename) { diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/optional/TraXLiaisonTest.java b/src/tests/junit/org/apache/tools/ant/taskdefs/optional/TraXLiaisonTest.java index 704a4c0c3..cfc047c75 100644 --- a/src/tests/junit/org/apache/tools/ant/taskdefs/optional/TraXLiaisonTest.java +++ b/src/tests/junit/org/apache/tools/ant/taskdefs/optional/TraXLiaisonTest.java @@ -141,7 +141,7 @@ public class TraXLiaisonTest extends AbstractXSLTLiaisonTest implements XSLTLogg liaison.setStylesheet(xsl); liaison.addParam("param", "value"); File in = getFile("/taskdefs/optional/xsltliaison-in.xml"); - // test for 10 consecutives transform + // test for 10 consecutive transforms for (int i = 0; i < 50; i++) { File out = new File("xsltliaison" + i + ".tmp"); try { diff --git a/src/tests/junit/org/apache/tools/ant/util/ReaderInputStreamTest.java b/src/tests/junit/org/apache/tools/ant/util/ReaderInputStreamTest.java index 332af76ad..41d505e7a 100644 --- a/src/tests/junit/org/apache/tools/ant/util/ReaderInputStreamTest.java +++ b/src/tests/junit/org/apache/tools/ant/util/ReaderInputStreamTest.java @@ -81,9 +81,9 @@ public class ReaderInputStreamTest { } @Test - public void testPreample() { + public void testPreamble() { byte[] bytes = "".getBytes(StandardCharsets.UTF_16); - System.out.println("Preample len is " + bytes.length); + System.out.println("Preamble len is " + bytes.length); } @Test