From 52579e96823f78d8588c70e92d5cded416cbeb9a Mon Sep 17 00:00:00 2001
From: Conor MacNeill <conor@apache.org>
Date: Thu, 17 May 2001 09:56:22 +0000
Subject: [PATCH] Quote the -group parameter to Javadoc

Submitted by:	Jay Glanville <dickon@nortelnetworks.com>


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@269026 13f79535-47bb-0310-9956-ffa450edef68
---
 .../org/apache/tools/ant/taskdefs/Javadoc.java  | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/main/org/apache/tools/ant/taskdefs/Javadoc.java b/src/main/org/apache/tools/ant/taskdefs/Javadoc.java
index 9bda6acf5..088e9479d 100644
--- a/src/main/org/apache/tools/ant/taskdefs/Javadoc.java
+++ b/src/main/org/apache/tools/ant/taskdefs/Javadoc.java
@@ -173,6 +173,9 @@ public class Javadoc extends Task {
         public String getName() {
             return name;
         }
+        public String toString() {
+            return getName();
+        }
     }
 
     public static class SourceFile {
@@ -661,16 +664,14 @@ public class Javadoc extends Task {
         }
 
         public String getPackages() {
-            String p = null;
+            StringBuffer p = new StringBuffer( "\"" );
             for (int i = 0; i < packages.size(); i++) {
-                PackageName pn = (PackageName)packages.elementAt(i);
-                if (p == null || p.equals("")) {
-                    p = pn.getName();
-                } else {
-                    p += ":" + pn.getName();
-                }
+                p.append( packages.elementAt( i ).toString() );
+                if ( i > 0 )
+                    p.append( ":" );
             }
-            return p;
+            p.append( "\"" );
+            return p.toString();
         }
     }