Make Zip#createEmptyZip be called again when empty zips need to be created

(similar for overrides in superclasses)


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@278143 13f79535-47bb-0310-9956-ffa450edef68

WHATSNEW

@@ -362,6 +362,9 @@ Fixed bugs:
 
 * FTP task, getTimeDiff method was returning wrong value. Bugzilla 30595.
 
+* make sure that Zip and its derivates call the createEmptyZip method when
+ there are no resources to zip/jar/...
+
 * Zip task was not zipping when only empty directories were found.
   Bugzilla 30365.
 

src/main/org/apache/tools/ant/taskdefs/Zip.java

@@ -474,6 +474,10 @@ public class Zip extends MatchingTask {
                 return;
             }
 
+            if (!zipFile.exists() && state.isWithoutAnyResources()) {
+                createEmptyZip(zipFile);
+                return;
+            }
             Resource[][] addThem = state.getResourcesToAdd();
 
             if (doUpdate) {
@@ -1384,5 +1388,22 @@ public class Zip extends MatchingTask {
         public Resource[][] getResourcesToAdd() {
             return resourcesToAdd;
         }
+        /**
+         * find out if there are absolutely no resources to add
+         * @return true if there are no resources to add
+         */
+        public boolean isWithoutAnyResources() {
+            if (resourcesToAdd == null)  {
+                return true;
+            }
+            for (int counter = 0; counter < resourcesToAdd.length; counter++) {
+                if (resourcesToAdd[counter] != null) {
+                    if (resourcesToAdd[counter].length > 0) {
+                        return false;
+                    }
+                }
+            }
+            return true;
+        }
     }
 }

src/testcases/org/apache/tools/ant/taskdefs/JarTest.java

@@ -258,7 +258,7 @@ public class JarTest extends BuildFileTest {
         }
     }
     public void testManifestOnlyJar() {
-        executeTarget("testManifestOnlyJar");
+        expectLogContaining("testManifestOnlyJar", "Building MANIFEST-only jar: ");
         File manifestFile = getProject().resolveFile(tempDir + "META-INF" + File.separator + "MANIFEST.MF");
         assertTrue(manifestFile.exists());
     }

src/testcases/org/apache/tools/ant/taskdefs/ZipTest.java

@@ -141,7 +141,7 @@ public class ZipTest extends BuildFileTest {
                    getProject().resolveFile("test3.zip").exists());
     }
     public void testZipEmptyCreate() {
-        executeTarget("zipEmptyCreate");
+        expectLogContaining("zipEmptyCreate", "Note: creating empty");
         assertTrue("archive should be created",
                    getProject().resolveFile("test3.zip").exists());
     }