diff --git a/build.xml b/build.xml
index 52b92977b..1b42c8fde 100644
--- a/build.xml
+++ b/build.xml
@@ -278,6 +278,8 @@
+
@@ -767,6 +769,11 @@
+
+
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java b/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java
index 2894b6534..14ae31ff4 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java
@@ -69,6 +69,7 @@ import java.io.FileWriter;
import java.io.IOException;
import java.io.LineNumberReader;
import java.io.PrintWriter;
+import java.util.Random;
import java.util.Vector;
/***
@@ -214,7 +215,7 @@ public class ReplaceRegExp extends Task
public void addFileset(FileSet set)
{
- filesets.add(set);
+ filesets.addElement(set);
}
public RegularExpression createRegularExpression()
@@ -258,8 +259,8 @@ public class ReplaceRegExp extends Task
protected void doReplace(File f, int options)
throws IOException
{
- File parentDir = new File(f.getAbsolutePath()).getParentFile();
- File temp = File.createTempFile("replace", ".txt", parentDir);
+ File parentDir = new File(new File(f.getAbsolutePath()).getParent());
+ File temp = createTempFile(parentDir);
FileReader r = null;
FileWriter w = null;
@@ -418,6 +419,14 @@ public class ReplaceRegExp extends Task
}
}
}
+
+ /**
+ * Creates a temporary file.
+ */
+ private File createTempFile(File dir) {
+ return new File(dir, "replace" + (new Random(System.currentTimeMillis())).nextLong()+".txt");
+ }
+
}
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java
index f816a9eb0..f2d83d9dd 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java
@@ -63,8 +63,6 @@ import java.net.MalformedURLException;
import java.net.URL;
import java.util.Vector;
import java.util.Hashtable;
-import java.util.ArrayList;
-import java.util.Iterator;
import java.util.Enumeration;
import org.apache.tools.ant.AntClassLoader;
import org.apache.tools.ant.BuildException;
@@ -127,7 +125,7 @@ public class XMLValidateTask extends Task {
/**
* The list of configured DTD locations
*/
- public ArrayList dtdLocations = new ArrayList();
+ public Vector dtdLocations = new Vector();
/**
* Specify how parser error are to be handled.
@@ -227,7 +225,7 @@ public class XMLValidateTask extends Task {
*/
public DTDLocation createDTD() {
DTDLocation dtdLocation = new DTDLocation();
- dtdLocations.add(dtdLocation);
+ dtdLocations.addElement(dtdLocation);
return dtdLocation;
}
@@ -235,8 +233,8 @@ public class XMLValidateTask extends Task {
protected EntityResolver getEntityResolver() {
LocalResolver resolver = new LocalResolver();
- for (Iterator i = dtdLocations.iterator(); i.hasNext();) {
- DTDLocation location = (DTDLocation)i.next();
+ for (Enumeration i = dtdLocations.elements(); i.hasMoreElements();) {
+ DTDLocation location = (DTDLocation)i.nextElement();
resolver.registerDTD(location);
}
return resolver;