From 4965535328781e63aacbf211d2e96a8462ea133a Mon Sep 17 00:00:00 2001 From: Stefan Bodewig Date: Sun, 20 Jul 2014 06:04:24 +0200 Subject: [PATCH] properly close stream in test --- .../org/apache/tools/ant/taskdefs/ManifestTest.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestTest.java b/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestTest.java index aa9432c3a..76e14b3b6 100644 --- a/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestTest.java +++ b/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestTest.java @@ -288,16 +288,22 @@ public class ManifestTest { value = mainSection.getAttributeValue(NOT_LONG_NAME); assertEquals("NOT_LONG_NAME_VALUE_MISMATCH", VALUE, value); - BufferedReader in = new BufferedReader(new FileReader(expandedManifest)); - Set set = new HashSet(); + FileReader fin = new FileReader(expandedManifest); + try { + BufferedReader in = new BufferedReader(fin); + String read = in.readLine(); while (read != null) { set.add(read); read = in.readLine(); } - + in.close(); + } finally { + fin.close(); + } + assertTrue("Manifest file should have contained string ", set .remove(" NOT_LONG")); assertTrue("Manifest file should have contained string ", set