Browse Source

Wrap FileWriter with BufferedWriter for better performance when the write() method is invoked in a loop

master
bd2019us Jaikiran Pai 6 years ago
parent
commit
4803eb24ae
3 changed files with 7 additions and 1 deletions
  1. +1
    -0
      CONTRIBUTORS
  2. +4
    -0
      contributors.xml
  3. +2
    -1
      src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java

+ 1
- 0
CONTRIBUTORS View File

@@ -453,6 +453,7 @@ Wolfgang Glas
Wolfgang Werner
Xavier Hanin
Xavier Witdouck
Xia Li
Yohann Roussel
Yuji Yamano
Yves Martin


+ 4
- 0
contributors.xml View File

@@ -1863,6 +1863,10 @@
<first>Xavier</first>
<last>Witdouck</last>
</name>
<name>
<first>Xia</first>
<last>Li</last>
</name>
<name>
<first>Yohann</first>
<last>Roussel</last>


+ 2
- 1
src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java View File

@@ -18,6 +18,7 @@

package org.apache.tools.ant.taskdefs.optional.ssh;

import java.io.BufferedWriter;
import java.io.BufferedReader;
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
@@ -481,7 +482,7 @@ public class SSHExec extends SSHBase {
*/
private void writeToFile(final String from, final boolean append, final File to)
throws IOException {
try (FileWriter out = new FileWriter(to.getAbsolutePath(), append)) {
try (BufferedWriter out = new BufferedWriter(new FileWriter(to.getAbsolutePath(), append))) {
final StringReader in = new StringReader(from);
final char[] buffer = new char[BUFFER_SIZE];
while (true) {


Loading…
Cancel
Save