diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Exit.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Exit.java deleted file mode 100644 index ca3013bc3..000000000 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Exit.java +++ /dev/null @@ -1,84 +0,0 @@ -/* - * Copyright (C) The Apache Software Foundation. All rights reserved. - * - * This software is published under the terms of the Apache Software License - * version 1.1, a copy of which has been included with this distribution in - * the LICENSE file. - */ -package org.apache.tools.ant.taskdefs; - -import org.apache.myrmidon.api.TaskException; -import org.apache.tools.ant.Task; - -/** - * Just exit the active build, giving an additional message if available. - * - * @author Nico Seessle - */ -public class Exit extends Task -{ - private String ifCondition, unlessCondition; - private String message; - - public void setIf( String c ) - { - ifCondition = c; - } - - public void setMessage( String value ) - { - this.message = value; - } - - public void setUnless( String c ) - { - unlessCondition = c; - } - - /** - * Set a multiline message. - * - * @param msg The feature to be added to the Text attribute - */ - public void addText( String msg ) - throws TaskException - { - message += project.replaceProperties( msg ); - } - - public void execute() - throws TaskException - { - if( testIfCondition() && testUnlessCondition() ) - { - if( message != null && message.length() > 0 ) - { - throw new TaskException( message ); - } - else - { - throw new TaskException( "No message" ); - } - } - } - - private boolean testIfCondition() - { - if( ifCondition == null || "".equals( ifCondition ) ) - { - return true; - } - - return project.getProperty( ifCondition ) != null; - } - - private boolean testUnlessCondition() - { - if( unlessCondition == null || "".equals( unlessCondition ) ) - { - return true; - } - return project.getProperty( unlessCondition ) == null; - } - -} diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecTask.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ExecTask.java similarity index 99% rename from proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecTask.java rename to proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ExecTask.java index d7fa0dc92..bdce3e39d 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecTask.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ExecTask.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.BufferedReader; import java.io.ByteArrayOutputStream; @@ -31,7 +31,6 @@ import org.apache.tools.ant.types.Environment; */ public class ExecTask extends Task { - private static String lSep = System.getProperty( "line.separator" ); protected boolean failOnError = false; protected boolean newEnvironment = false; @@ -370,7 +369,7 @@ public class ExecTask extends Task * @param result Description of Parameter */ protected void maybeSetResultPropertyValue( int result ) - throws TaskException + throws TaskException { String res = Integer.toString( result ); if( resultProperty != null ) diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Execute.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/Execute.java similarity index 99% rename from proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Execute.java rename to proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/Execute.java index 3dd4df01d..f916ba9dd 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Execute.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/Execute.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.BufferedReader; import java.io.ByteArrayOutputStream; @@ -239,7 +239,7 @@ public class Execute // Since we "look ahead" before adding, there's one last env var. procEnvironment.addElement( var ); } - catch( java.io.IOException exc ) + catch( IOException exc ) { exc.printStackTrace(); // Just try to see how much we got @@ -272,7 +272,7 @@ public class Execute throw new TaskException( cmdline[ 0 ] + " failed with return code " + retval ); } } - catch( java.io.IOException exc ) + catch( IOException exc ) { throw new TaskException( "Could not launch " + cmdline[ 0 ] + ": " + exc ); } diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecuteStreamHandler.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ExecuteStreamHandler.java similarity index 97% rename from proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecuteStreamHandler.java rename to proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ExecuteStreamHandler.java index 6e398d251..e0083a325 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecuteStreamHandler.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ExecuteStreamHandler.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.IOException; import java.io.InputStream; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecuteWatchdog.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ExecuteWatchdog.java similarity index 99% rename from proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecuteWatchdog.java rename to proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ExecuteWatchdog.java index 4edcfc65f..71ee84a29 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecuteWatchdog.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ExecuteWatchdog.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import org.apache.myrmidon.api.TaskException; diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/LogOutputStream.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/LogOutputStream.java similarity index 98% rename from proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/LogOutputStream.java rename to proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/LogOutputStream.java index f3684dd40..18e0f2a1d 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/LogOutputStream.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/LogOutputStream.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.ByteArrayOutputStream; import java.io.IOException; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/LogStreamHandler.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/LogStreamHandler.java similarity index 96% rename from proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/LogStreamHandler.java rename to proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/LogStreamHandler.java index 5941e300d..a9612f6d9 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/LogStreamHandler.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/LogStreamHandler.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.IOException; import org.apache.myrmidon.api.TaskException; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ProcessDestroyer.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ProcessDestroyer.java similarity index 98% rename from proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ProcessDestroyer.java rename to proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ProcessDestroyer.java index 04d0f1b06..790743d87 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ProcessDestroyer.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/ProcessDestroyer.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.lang.reflect.Method; import java.util.Enumeration; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/PumpStreamHandler.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/PumpStreamHandler.java similarity index 98% rename from proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/PumpStreamHandler.java rename to proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/PumpStreamHandler.java index 7acbd9394..3631dc27c 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/PumpStreamHandler.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/PumpStreamHandler.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.IOException; import java.io.InputStream; diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/StreamPumper.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/StreamPumper.java similarity index 97% rename from proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/StreamPumper.java rename to proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/StreamPumper.java index 1af5ffe86..58a05458b 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/StreamPumper.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec/StreamPumper.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.IOException; import java.io.InputStream; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Exit.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Exit.java deleted file mode 100644 index ca3013bc3..000000000 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Exit.java +++ /dev/null @@ -1,84 +0,0 @@ -/* - * Copyright (C) The Apache Software Foundation. All rights reserved. - * - * This software is published under the terms of the Apache Software License - * version 1.1, a copy of which has been included with this distribution in - * the LICENSE file. - */ -package org.apache.tools.ant.taskdefs; - -import org.apache.myrmidon.api.TaskException; -import org.apache.tools.ant.Task; - -/** - * Just exit the active build, giving an additional message if available. - * - * @author Nico Seessle - */ -public class Exit extends Task -{ - private String ifCondition, unlessCondition; - private String message; - - public void setIf( String c ) - { - ifCondition = c; - } - - public void setMessage( String value ) - { - this.message = value; - } - - public void setUnless( String c ) - { - unlessCondition = c; - } - - /** - * Set a multiline message. - * - * @param msg The feature to be added to the Text attribute - */ - public void addText( String msg ) - throws TaskException - { - message += project.replaceProperties( msg ); - } - - public void execute() - throws TaskException - { - if( testIfCondition() && testUnlessCondition() ) - { - if( message != null && message.length() > 0 ) - { - throw new TaskException( message ); - } - else - { - throw new TaskException( "No message" ); - } - } - } - - private boolean testIfCondition() - { - if( ifCondition == null || "".equals( ifCondition ) ) - { - return true; - } - - return project.getProperty( ifCondition ) != null; - } - - private boolean testUnlessCondition() - { - if( unlessCondition == null || "".equals( unlessCondition ) ) - { - return true; - } - return project.getProperty( unlessCondition ) == null; - } - -} diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecTask.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ExecTask.java similarity index 99% rename from proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecTask.java rename to proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ExecTask.java index d7fa0dc92..bdce3e39d 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecTask.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ExecTask.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.BufferedReader; import java.io.ByteArrayOutputStream; @@ -31,7 +31,6 @@ import org.apache.tools.ant.types.Environment; */ public class ExecTask extends Task { - private static String lSep = System.getProperty( "line.separator" ); protected boolean failOnError = false; protected boolean newEnvironment = false; @@ -370,7 +369,7 @@ public class ExecTask extends Task * @param result Description of Parameter */ protected void maybeSetResultPropertyValue( int result ) - throws TaskException + throws TaskException { String res = Integer.toString( result ); if( resultProperty != null ) diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Execute.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/Execute.java similarity index 99% rename from proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Execute.java rename to proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/Execute.java index 3dd4df01d..f916ba9dd 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Execute.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/Execute.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.BufferedReader; import java.io.ByteArrayOutputStream; @@ -239,7 +239,7 @@ public class Execute // Since we "look ahead" before adding, there's one last env var. procEnvironment.addElement( var ); } - catch( java.io.IOException exc ) + catch( IOException exc ) { exc.printStackTrace(); // Just try to see how much we got @@ -272,7 +272,7 @@ public class Execute throw new TaskException( cmdline[ 0 ] + " failed with return code " + retval ); } } - catch( java.io.IOException exc ) + catch( IOException exc ) { throw new TaskException( "Could not launch " + cmdline[ 0 ] + ": " + exc ); } diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecuteStreamHandler.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ExecuteStreamHandler.java similarity index 97% rename from proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecuteStreamHandler.java rename to proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ExecuteStreamHandler.java index 6e398d251..e0083a325 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecuteStreamHandler.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ExecuteStreamHandler.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.IOException; import java.io.InputStream; diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecuteWatchdog.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ExecuteWatchdog.java similarity index 99% rename from proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecuteWatchdog.java rename to proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ExecuteWatchdog.java index 4edcfc65f..71ee84a29 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecuteWatchdog.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ExecuteWatchdog.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import org.apache.myrmidon.api.TaskException; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/LogOutputStream.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/LogOutputStream.java similarity index 98% rename from proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/LogOutputStream.java rename to proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/LogOutputStream.java index f3684dd40..18e0f2a1d 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/LogOutputStream.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/LogOutputStream.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.ByteArrayOutputStream; import java.io.IOException; diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/LogStreamHandler.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/LogStreamHandler.java similarity index 96% rename from proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/LogStreamHandler.java rename to proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/LogStreamHandler.java index 5941e300d..a9612f6d9 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/LogStreamHandler.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/LogStreamHandler.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.IOException; import org.apache.myrmidon.api.TaskException; diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ProcessDestroyer.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ProcessDestroyer.java similarity index 98% rename from proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ProcessDestroyer.java rename to proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ProcessDestroyer.java index 04d0f1b06..790743d87 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ProcessDestroyer.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/ProcessDestroyer.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.lang.reflect.Method; import java.util.Enumeration; diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/PumpStreamHandler.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/PumpStreamHandler.java similarity index 98% rename from proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/PumpStreamHandler.java rename to proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/PumpStreamHandler.java index 7acbd9394..3631dc27c 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/PumpStreamHandler.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/PumpStreamHandler.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.IOException; import java.io.InputStream; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/StreamPumper.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/StreamPumper.java similarity index 97% rename from proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/StreamPumper.java rename to proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/StreamPumper.java index 1af5ffe86..58a05458b 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/StreamPumper.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec/StreamPumper.java @@ -5,7 +5,7 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.tools.ant.taskdefs; +package org.apache.tools.ant.taskdefs.exec; import java.io.IOException; import java.io.InputStream;