Browse Source

fix failonerror="false" includeemptydirs="true"; reported by Alexey.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@358653 13f79535-47bb-0310-9956-ffa450edef68
master
Matthew Jason Benson 19 years ago
parent
commit
456488aec5
3 changed files with 22 additions and 2 deletions
  1. +14
    -0
      src/etc/testcases/taskdefs/delete.xml
  2. +2
    -2
      src/main/org/apache/tools/ant/taskdefs/Delete.java
  3. +6
    -0
      src/testcases/org/apache/tools/ant/taskdefs/DeleteTest.java

+ 14
- 0
src/etc/testcases/taskdefs/delete.xml View File

@@ -115,6 +115,20 @@
</delete>
</target>

<target name="test12">
<delete failonerror="false" includeemptydirs="true">
<fileset dir="thisdenotesadirectorythatwillneverexistblah" />
</delete>
</target>

<target name="test13" depends="init">
<delete includeemptydirs="true">
<fileset dir="${dir}" />
<fileset dir="${dir}" />
</delete>
<expectabsent />
</target>

<target name="cleanup" depends="test4" />

</project>

+ 2
- 2
src/main/org/apache/tools/ant/taskdefs/Delete.java View File

@@ -552,12 +552,12 @@ public class Delete extends MatchingTask {
for (int i = 0; i < filesets.size(); i++) {
FileSet fs = (FileSet) filesets.get(i);
resourcesToDelete.add(fs);
if (includeEmpty) {
if (includeEmpty && fs.getDir().isDirectory()) {
filesetDirs.add(new ReverseDirs(fs.getDir(),
fs.getDirectoryScanner().getIncludedDirectories()));
}
}
if (usedMatchingTask && dir != null) {
if (usedMatchingTask && dir != null && dir.isDirectory()) {
//add the files from the default fileset:
FileSet implicit = getImplicitFileSet();
resourcesToDelete.add(implicit);


+ 6
- 0
src/testcases/org/apache/tools/ant/taskdefs/DeleteTest.java View File

@@ -67,4 +67,10 @@ public class DeleteTest extends BuildFileTest {
public void test11() {
executeTarget("test11");
}
public void test12() {
executeTarget("test12");
}
public void test13() {
executeTarget("test13");
}
}

Loading…
Cancel
Save