From 30cf43949ad6bab8bc7e0ce87a543cbcf754ad7e Mon Sep 17 00:00:00 2001
From: Conor MacNeill <conor@apache.org>
Date: Sat, 7 Jul 2001 10:19:31 +0000
Subject: [PATCH] Only delete the target file when it is in fact a file - don't
 delete directories.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@269282 13f79535-47bb-0310-9956-ffa450edef68
---
 src/etc/testcases/taskdefs/copyfile.xml                      | 1 +
 src/main/org/apache/tools/ant/Project.java                   | 2 +-
 .../org/apache/tools/ant/taskdefs/CopyfileTest.java          | 5 -----
 3 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/etc/testcases/taskdefs/copyfile.xml b/src/etc/testcases/taskdefs/copyfile.xml
index 6685d825e..34d3cd435 100644
--- a/src/etc/testcases/taskdefs/copyfile.xml
+++ b/src/etc/testcases/taskdefs/copyfile.xml
@@ -25,6 +25,7 @@
   </target>
 
   <target name="test6">
+    <delete file="testdir"/>
     <mkdir dir="testdir" />
     <copyfile src="copyfile.xml" 
               dest="testdir"
diff --git a/src/main/org/apache/tools/ant/Project.java b/src/main/org/apache/tools/ant/Project.java
index d4892b4d3..d2ef9d989 100644
--- a/src/main/org/apache/tools/ant/Project.java
+++ b/src/main/org/apache/tools/ant/Project.java
@@ -755,7 +755,7 @@ public class Project {
         if (overwrite || !destFile.exists() ||
             destFile.lastModified() < sourceFile.lastModified()) {
 
-            if (destFile.exists()) {
+            if (destFile.exists() && destFile.isFile()) {
                 destFile.delete();
             }
 
diff --git a/src/testcases/org/apache/tools/ant/taskdefs/CopyfileTest.java b/src/testcases/org/apache/tools/ant/taskdefs/CopyfileTest.java
index 7c26e4f5b..2c20e2a92 100644
--- a/src/testcases/org/apache/tools/ant/taskdefs/CopyfileTest.java
+++ b/src/testcases/org/apache/tools/ant/taskdefs/CopyfileTest.java
@@ -102,9 +102,4 @@ public class CopyfileTest extends TaskdefsTest {
             fail("Copy failed");
         }
     }
-/*
-    public void test6() { 
-        expectBuildException("test6", "target is directory");
-    }
-*/
 }