diff --git a/src/main/org/apache/tools/ant/types/Path.java b/src/main/org/apache/tools/ant/types/Path.java index a64faae54..ff48c3d3c 100644 --- a/src/main/org/apache/tools/ant/types/Path.java +++ b/src/main/org/apache/tools/ant/types/Path.java @@ -574,7 +574,7 @@ public class Path extends DataType implements Cloneable { * Add the Java Runtime classes to this Path instance. */ public void addJavaRuntime() { - if ("Kaffe".equals(System.getProperty("java.vm.name"))) { + if (JavaEnvUtils.isKaffe()) { // newer versions of Kaffe (1.1.1+) won't have this, // but this will be sorted by FileSet anyway. File kaffeShare = new File(System.getProperty("java.home") diff --git a/src/main/org/apache/tools/ant/util/JavaEnvUtils.java b/src/main/org/apache/tools/ant/util/JavaEnvUtils.java index 51f9a665e..8bddb3f69 100644 --- a/src/main/org/apache/tools/ant/util/JavaEnvUtils.java +++ b/src/main/org/apache/tools/ant/util/JavaEnvUtils.java @@ -67,6 +67,9 @@ public class JavaEnvUtils { /** Version constant for Java 1.5 */ public static final String JAVA_1_5 = "1.5"; + /** Whether this is the Kaffe VM */ + private static boolean kaffeDetected; + /** array of packages in the runtime */ private static Vector jrePackages; @@ -103,6 +106,13 @@ public class JavaEnvUtils { // swallow as we've hit the max class version that // we have } + kaffeDetected = false; + try { + Class.forName("kaffe.util.NotImplemented"); + kaffeDetected = true; + } catch (Throwable t) { + // swallow as this simply doesn't seem to be Kaffe + } } /** @@ -125,6 +135,16 @@ public class JavaEnvUtils { return javaVersion.equals(version); } + /** + * Checks whether the current Java VM is Kaffe. + * @return true if the current Java VM is Kaffe. + * @since Ant 1.6.3 + * @see http://www.kaffe.org/ + */ + public static boolean isKaffe() { + return kaffeDetected; + } + /** * Finds an executable that is part of a JRE installation based on * the java.home system property. diff --git a/src/testcases/org/apache/tools/ant/filters/ConcatFilterTest.java b/src/testcases/org/apache/tools/ant/filters/ConcatFilterTest.java index db6f67b9c..1e365635d 100644 --- a/src/testcases/org/apache/tools/ant/filters/ConcatFilterTest.java +++ b/src/testcases/org/apache/tools/ant/filters/ConcatFilterTest.java @@ -142,7 +142,7 @@ public class ConcatFilterTest extends BuildFileTest { try { File file = getProject().resolveFile(filename); java.io.FileReader rdr = new java.io.FileReader(file); - content = fu.readFully(rdr); + content = FileUtils.readFully(rdr); rdr.close(); rdr = null; } catch (Exception e) { diff --git a/src/testcases/org/apache/tools/ant/filters/DynamicFilterTest.java b/src/testcases/org/apache/tools/ant/filters/DynamicFilterTest.java index 313793aa6..2c8ba9a49 100644 --- a/src/testcases/org/apache/tools/ant/filters/DynamicFilterTest.java +++ b/src/testcases/org/apache/tools/ant/filters/DynamicFilterTest.java @@ -68,7 +68,7 @@ public class DynamicFilterTest extends BuildFileTest { Reader r = null; try { r = new FileReader(getProject().resolveFile(filename)); - return FileUtils.newFileUtils().readFully(r); + return FileUtils.readFully(r); } finally { try {r.close();} catch (Throwable ignore) {} diff --git a/src/testcases/org/apache/tools/ant/filters/TokenFilterTest.java b/src/testcases/org/apache/tools/ant/filters/TokenFilterTest.java index 57b19ac23..1c5ebb14a 100644 --- a/src/testcases/org/apache/tools/ant/filters/TokenFilterTest.java +++ b/src/testcases/org/apache/tools/ant/filters/TokenFilterTest.java @@ -248,7 +248,7 @@ public class TokenFilterTest extends BuildFileTest { Reader r = null; try { r = new FileReader(getProject().resolveFile(filename)); - return FileUtils.newFileUtils().readFully(r); + return FileUtils.readFully(r); } finally { try {r.close();} catch (Throwable ignore) {} diff --git a/src/testcases/org/apache/tools/ant/taskdefs/CVSPassTest.java b/src/testcases/org/apache/tools/ant/taskdefs/CVSPassTest.java index fe79b5736..e71cc3a8d 100644 --- a/src/testcases/org/apache/tools/ant/taskdefs/CVSPassTest.java +++ b/src/testcases/org/apache/tools/ant/taskdefs/CVSPassTest.java @@ -27,11 +27,11 @@ import org.apache.tools.ant.BuildFileTest; */ public class CVSPassTest extends BuildFileTest { private final String EOL = System.getProperty("line.separator"); - private final String JAKARTA_URL = + private static final String JAKARTA_URL = ":pserver:anoncvs@jakarta.apache.org:/home/cvspublic Ay=0=h]]>" + "") > 0); } finally { diff --git a/src/testcases/org/apache/tools/ant/taskdefs/optional/sos/SOSTest.java b/src/testcases/org/apache/tools/ant/taskdefs/optional/sos/SOSTest.java index c30d75176..8553bdc72 100644 --- a/src/testcases/org/apache/tools/ant/taskdefs/optional/sos/SOSTest.java +++ b/src/testcases/org/apache/tools/ant/taskdefs/optional/sos/SOSTest.java @@ -30,7 +30,6 @@ import org.apache.tools.ant.types.Path; */ public class SOSTest extends BuildFileTest { - private Project project; private Commandline commandline; private static final String VSS_SERVER_PATH = "\\\\server\\vss\\srcsafe.ini"; diff --git a/src/testcases/org/apache/tools/ant/taskdefs/optional/vss/MSVSSTest.java b/src/testcases/org/apache/tools/ant/taskdefs/optional/vss/MSVSSTest.java index f54c1386a..c8aea56e7 100644 --- a/src/testcases/org/apache/tools/ant/taskdefs/optional/vss/MSVSSTest.java +++ b/src/testcases/org/apache/tools/ant/taskdefs/optional/vss/MSVSSTest.java @@ -35,7 +35,6 @@ import org.apache.tools.ant.types.Path; */ public class MSVSSTest extends BuildFileTest implements MSVSSConstants { - private Project project; private Commandline commandline; private static final String VSS_SERVER_PATH = "\\\\server\\vss\\srcsafe.ini"; diff --git a/src/testcases/org/apache/tools/ant/types/selectors/ModifiedSelectorTest.java b/src/testcases/org/apache/tools/ant/types/selectors/ModifiedSelectorTest.java index 9d021a436..afb09cfdd 100644 --- a/src/testcases/org/apache/tools/ant/types/selectors/ModifiedSelectorTest.java +++ b/src/testcases/org/apache/tools/ant/types/selectors/ModifiedSelectorTest.java @@ -330,7 +330,6 @@ public class ModifiedSelectorTest extends BaseSelectorTest { /** Checks whether a cache file is created. */ public void testCreatePropertiesCacheDirect() { - File basedir = getSelector().getProject().getBaseDir(); File cachefile = new File(basedir, "cachefile.properties"); PropertiesfileCache cache = new PropertiesfileCache(); @@ -348,7 +347,6 @@ public class ModifiedSelectorTest extends BaseSelectorTest { /** Checks whether a cache file is created. */ public void testCreatePropertiesCacheViaModifiedSelector() { - File basedir = getSelector().getProject().getBaseDir(); File cachefile = new File(basedir, "cachefile.properties"); try { @@ -826,7 +824,6 @@ public class ModifiedSelectorTest extends BaseSelectorTest { public void doScenarioTest(String target, String cachefilename) { BFT bft = new BFT(); bft.setUp(); - File basedir = bft.getProject().getBaseDir(); File cachefile = new File(basedir, cachefilename); try { // do the actions