Merge pull request #154 from arturobernalg/feature/string_builder

Change StringBuffer in favor of StringBuilder.

src/main/org/apache/tools/ant/filters/BaseFilterReader.java

@@ -173,7 +173,7 @@ public abstract class BaseFilterReader extends FilterReader {
             return null;
         }
 
-        StringBuffer line = new StringBuffer();
+        final StringBuilder line = new StringBuilder();
 
         while (ch != -1) {
             line.append((char) ch);

src/main/org/apache/tools/ant/filters/TokenFilter.java

@@ -370,7 +370,7 @@ public class TokenFilter extends BaseFilterReader
             if (from == null) {
                 throw new BuildException("Missing from in stringreplace");
             }
-            StringBuffer ret = new StringBuffer();
+            final StringBuilder ret = new StringBuilder();
             int start = 0;
             int found = line.indexOf(from);
             while (found >= 0) {
@@ -620,7 +620,7 @@ public class TokenFilter extends BaseFilterReader
          * @return the converted string
          */
         public String filter(String string) {
-            StringBuffer output = new StringBuffer(string.length());
+            StringBuilder output = new StringBuilder(string.length());
             for (int i = 0; i < string.length(); ++i) {
                 char ch = string.charAt(i);
                 if (!(isDeleteCharacter(ch))) {

src/main/org/apache/tools/ant/taskdefs/KeySubst.java

@@ -167,7 +167,7 @@ public class KeySubst extends Task {
      */
     public static String replace(String origString, Hashtable<String, String> keys)
         throws BuildException {
-        StringBuffer finalString = new StringBuffer();
+        final StringBuilder finalString = new StringBuilder();
         int index = 0;
         int i = 0;
         String key = null;

src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java

@@ -188,7 +188,7 @@ public class RecorderEntry implements BuildLogger, SubBuildListener {
     public void messageLogged(BuildEvent event) {
         log("--- MESSAGE LOGGED", Project.MSG_DEBUG);
 
-        StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
 
         if (event.getTask() != null) {
             String name = event.getTask().getTaskName();

src/main/org/apache/tools/ant/taskdefs/Redirector.java

@@ -704,7 +704,7 @@ public class Redirector {
                 }
                 ((ConcatFileInputStream) inputStream).setManagingComponent(managingTask);
             } else if (inputString != null) {
-                final StringBuffer buf = new StringBuffer("Using input ");
+                final StringBuilder buf = new StringBuilder("Using input ");
                 if (logInputString) {
                     buf.append('"').append(inputString).append('"');
                 } else {

src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java

@@ -550,7 +550,7 @@ public class TraXLiaison implements XSLTLiaison4, ErrorListener, XSLTLoggerAware
             return;
         }
 
-        final StringBuffer msg = new StringBuffer();
+        final StringBuilder msg = new StringBuilder();
         final SourceLocator locator = e.getLocator();
         if (locator != null) {
             final String systemid = locator.getSystemId();

src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java

@@ -745,7 +745,7 @@ public abstract class MSVSS extends Task implements MSVSSConstants {
      * @return The command line as a string with out the password
      */
     private String formatCommandLine(Commandline cmd) {
-        StringBuffer sBuff = new StringBuffer(cmd.toString());
+        final StringBuilder sBuff = new StringBuilder(cmd.toString());
         int indexUser = sBuff.substring(0).indexOf(FLAG_LOGIN);
         if (indexUser > 0) {
             int indexPass = sBuff.substring(0).indexOf(",", indexUser);

src/main/org/apache/tools/ant/util/FileUtils.java

@@ -822,7 +822,7 @@ public class FileUtils {
             //remove the initial separator; the root has it.
             next = (ca[next] == sep) ? next + 1 : next;
 
-            StringBuffer sbPath = new StringBuffer();
+            final StringBuilder sbPath = new StringBuilder();
             // Eliminate consecutive slashes after the drive spec:
             for (int i = next; i < ca.length; i++) {
                 if (ca[i] != sep || ca[i - 1] != sep) {