From 26eb04c78c10f42a794c3a31202fdb7802541715 Mon Sep 17 00:00:00 2001
From: Stefan Bodewig <bodewig@apache.org>
Date: Mon, 1 Sep 2003 09:53:05 +0000
Subject: [PATCH] label and lock/unlock cannot be used at the same time in
 <stcheckout>.

PR: 22829
Submitted by:	Steve Cohen <scohen at apache dot org>


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@275157 13f79535-47bb-0310-9956-ffa450edef68
---
 docs/manual/OptionalTasks/starteam.html                      | 4 ++--
 .../ant/taskdefs/optional/starteam/StarTeamCheckout.java     | 5 +++++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/docs/manual/OptionalTasks/starteam.html b/docs/manual/OptionalTasks/starteam.html
index 46244b73b..0e17deaf7 100644
--- a/docs/manual/OptionalTasks/starteam.html
+++ b/docs/manual/OptionalTasks/starteam.html
@@ -145,7 +145,7 @@ See also <A href="#common-params">the required common StarTeam parameters</A>.<b
   </tr>
   <tr>
     <td valign="top">label</td>
-    <td valign="top">Check out files as of this label.  The label must exist in starteam or an exception will be thrown.  If not specified, the most recent version of each file will be checked out.</td>
+    <td valign="top">Check out files as of this label.  The label must exist in starteam or an exception will be thrown.  If either <code>locked</code> or <code>unlocked</code> is true, an exception will be thrown.  If not specified, the most recent version of each file will be checked out.</td>
     <td align="center" valign="top">no</td>
   </tr>
   <tr>
@@ -163,7 +163,7 @@ that StarTeam is maintaining for the file.   If false, status will be used to de
     <td valign="top">locked</td>
     <td valign="top">If true, file will be locked against changes by other 
 users.  If false (default) has no effect. 
-    <td align="center" valign="center" rowspan="2">Either or neither, but not both, may be true.</td>
+    <td align="center" valign="center" rowspan="2">Either or neither, but not both, may be true. Neither may be true if a <code>label</code> is specified.</td>
   </tr>
   <tr>
     <td valign="top">unlocked</td>
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java b/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java
index e07f29a15..ea38ea0ad 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java
@@ -261,6 +261,11 @@ public class StarTeamCheckout extends TreeBasedTask {
                 Project.MSG_WARN);
             this.createDirs = false;
         }
+        if (lockStatus != Item.LockType.UNCHANGED && null != getLabel()) {
+            log("Neither locked nor unlocked may be true when checking out a labeled version.", 
+                Project.MSG_ERR);
+            throw new BuildException("Lock status may not be changed when checking out a non-current version.");
+        }
     }
 
     /**