From 260563c19644e93bd4d2af47a4b21b054c3b0f18 Mon Sep 17 00:00:00 2001
From: Peter Reilly <peterreilly@apache.org>
Date: Wed, 1 Dec 2004 16:58:19 +0000
Subject: [PATCH] checkstyle

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277100 13f79535-47bb-0310-9956-ffa450edef68
---
 .../apache/tools/ant/taskdefs/optional/perforce/P4Resolve.java | 2 +-
 .../org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java    | 2 +-
 .../tools/ant/taskdefs/optional/starteam/StarTeamCheckin.java  | 3 +++
 .../tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java | 2 +-
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Resolve.java b/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Resolve.java
index e73f9392a..595e39440 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Resolve.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Resolve.java
@@ -73,7 +73,7 @@ public class P4Resolve extends P4Base {
                 break;
             }
         }
-        if (found == false) {
+        if (!found) {
             throw new BuildException("Unacceptable value for resolve mode");
         }
         this.resolvemode = resolvemode;
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java
index dd6a4b2a6..91dd7609c 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java
@@ -40,7 +40,7 @@ import com.jcraft.jsch.Session;
  */
 public class SSHExec extends SSHBase {
 
-    private final int BUFFER_SIZE = 1024;
+    private static final int BUFFER_SIZE = 1024;
 
     /** the command to execute via ssh */
     private String command = null;
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckin.java b/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckin.java
index b9236de4b..f784cf2a8 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckin.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckin.java
@@ -37,6 +37,9 @@ import org.apache.tools.ant.BuildException;
  */
 public class StarTeamCheckin extends TreeBasedTask {
 
+    /**
+     * Constructor for StarTeamCheckin.
+     */
     public StarTeamCheckin() {
         // we want this to have a false default, unlike for Checkin.
         setRecursive(false);
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java b/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java
index a8342cfa3..d3d5bb5c1 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java
@@ -211,7 +211,7 @@ public class StarTeamCheckout extends TreeBasedTask {
      * @param raw    the unconfigured <code>View</code>
      *
      * @return the snapshot <code>View</code> appropriately configured.
-     * @exception BuildException
+     * @exception BuildException on error
      */
     protected View createSnapshotView(View raw) throws BuildException {