diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Resolve.java b/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Resolve.java
index e73f9392a..595e39440 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Resolve.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Resolve.java
@@ -73,7 +73,7 @@ public class P4Resolve extends P4Base {
break;
}
}
- if (found == false) {
+ if (!found) {
throw new BuildException("Unacceptable value for resolve mode");
}
this.resolvemode = resolvemode;
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java
index dd6a4b2a6..91dd7609c 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java
@@ -40,7 +40,7 @@ import com.jcraft.jsch.Session;
*/
public class SSHExec extends SSHBase {
- private final int BUFFER_SIZE = 1024;
+ private static final int BUFFER_SIZE = 1024;
/** the command to execute via ssh */
private String command = null;
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckin.java b/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckin.java
index b9236de4b..f784cf2a8 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckin.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckin.java
@@ -37,6 +37,9 @@ import org.apache.tools.ant.BuildException;
*/
public class StarTeamCheckin extends TreeBasedTask {
+ /**
+ * Constructor for StarTeamCheckin.
+ */
public StarTeamCheckin() {
// we want this to have a false default, unlike for Checkin.
setRecursive(false);
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java b/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java
index a8342cfa3..d3d5bb5c1 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/starteam/StarTeamCheckout.java
@@ -211,7 +211,7 @@ public class StarTeamCheckout extends TreeBasedTask {
* @param raw the unconfigured View
*
* @return the snapshot View appropriately configured.
- * @exception BuildException
+ * @exception BuildException on error
*/
protected View createSnapshotView(View raw) throws BuildException {