Browse Source

Don't use deprecated code. Submitted by: Kevin Jackson <kevin dot jackson at it dot fts dash vn dot com>

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@276999 13f79535-47bb-0310-9956-ffa450edef68
master
Stefan Bodewig 20 years ago
parent
commit
24f365284e
3 changed files with 77 additions and 6 deletions
  1. +1
    -0
      CONTRIBUTORS
  2. +9
    -6
      src/main/org/apache/tools/zip/ZipOutputStream.java
  3. +67
    -0
      src/testcases/org/apache/tools/zip/ZipOutputStreamTest.java

+ 1
- 0
CONTRIBUTORS View File

@@ -105,6 +105,7 @@ Juerg Wanner
Keiron Liddle
Keith Visco
Kevin Greiner
Kevin Jackson
Kevin Ross
Kevin Z Grey
Kirk Wylie


+ 9
- 6
src/main/org/apache/tools/zip/ZipOutputStream.java View File

@@ -24,6 +24,7 @@ import java.io.IOException;
import java.io.OutputStream;
import java.io.RandomAccessFile;
import java.io.UnsupportedEncodingException;
import java.util.Calendar;
import java.util.Date;
import java.util.Hashtable;
import java.util.Vector;
@@ -769,17 +770,19 @@ public class ZipOutputStream extends FilterOutputStream {
* @since 1.1
*/
protected static ZipLong toDosTime(Date time) {
int year = time.getYear() + 1900;
int month = time.getMonth() + 1;
Calendar cal = Calendar.getInstance();
cal.setTime(time);
int year = cal.get(Calendar.YEAR);
int month = cal.get(Calendar.MONTH) + 1;
if (year < 1980) {
return DOS_TIME_MIN;
}
long value = ((year - 1980) << 25)
| (month << 21)
| (time.getDate() << 16)
| (time.getHours() << 11)
| (time.getMinutes() << 5)
| (time.getSeconds() >> 1);
| (cal.get(Calendar.DAY_OF_MONTH) << 16)
| (cal.get(Calendar.HOUR_OF_DAY) << 11)
| (cal.get(Calendar.MINUTE) << 5)
| (cal.get(Calendar.SECOND) >> 1);

byte[] result = new byte[4];
result[0] = (byte) ((value & 0xFF));


+ 67
- 0
src/testcases/org/apache/tools/zip/ZipOutputStreamTest.java View File

@@ -0,0 +1,67 @@
/*
* Copyright 2004 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/

package org.apache.tools.zip;

import junit.framework.Test;
import junit.framework.TestCase;
import junit.framework.TestSuite;

import java.util.Date;

public class ZipOutputStreamTest extends TestCase {
private Date time;
private ZipLong zl;
/**
* Constructor
*/
public ZipOutputStreamTest(String name) {
super(name);
}
protected void setUp() throws Exception {
time = new Date();
byte[] result = new byte[4];
int year = time.getYear() + 1900;
int month = time.getMonth() + 1;
long value = ((year - 1980) << 25)
| (month << 21)
| (time.getDate() << 16)
| (time.getHours() << 11)
| (time.getMinutes() << 5)
| (time.getSeconds() >> 1);

result[0] = (byte) ((value & 0xFF));
result[1] = (byte) ((value & 0xFF00) >> 8);
result[2] = (byte) ((value & 0xFF0000) >> 16);
result[3] = (byte) ((value & 0xFF000000L) >> 24);
zl = new ZipLong(result);
}

protected void tearDown() throws Exception {
super.tearDown();
}
public void testZipLong() throws Exception {
ZipLong test = ZipOutputStream.toDosTime(time);
assertEquals(test.getValue(), zl.getValue());
}

}

Loading…
Cancel
Save