Add in Jose's <define> nested element for <macrodef>

manual and testcases to follow...


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277354 13f79535-47bb-0310-9956-ffa450edef68

src/main/org/apache/tools/ant/taskdefs/MacroDef.java

@@ -226,20 +226,50 @@ public class MacroDef extends AntlibDefinition  {
         }
         if (attribute.getName().equals(textName)) {
             throw new BuildException(
-                "the attribute name \"" + attribute.getName()
+                "the name \"" + attribute.getName()
                 + "\" has already been used by the text element");
         }
         for (int i = 0; i < attributes.size(); ++i) {
-            if (((Attribute) attributes.get(i)).getName().equals(
-                    attribute.getName())) {
+            Attribute att = (Attribute) attributes.get(i);
+            if (att.getName().equals(attribute.getName())) {
                 throw new BuildException(
-                    "the attribute " + attribute.getName()
-                    + " has already been specified");
+                    "the name \"" + attribute.getName()
+                        + "\" has already been used in "
+                        + (att instanceof DefineAttribute ? "a define element"
+                           : "another attribute element"));
             }
         }
         attributes.add(attribute);
     }
 
+    /**
+     * Add a define element.
+     *
+     * @param def a define nested element.
+     */
+    public void addConfiguredDefine(DefineAttribute def) {
+        if (def.getName() == null) {
+            throw new BuildException(
+                "the define nested element needed a \"name\" attribute");
+        }
+        if (def.getName().equals(textName)) {
+            throw new BuildException(
+                "the name \"" + def.getName()
+                + "\" has already been used by the text element");
+        }
+        for (int i = 0; i < attributes.size(); ++i) {
+            Attribute att = (Attribute) attributes.get(i);
+            if (att.getName().equals(def.getName())) {
+                throw new BuildException(
+                    "the name \"" + def.getName()
+                    + "\" has already been used in "
+                    + (att instanceof DefineAttribute ? "another define element"
+                       : "an attribute element"));
+            }
+        }
+        attributes.add(def);
+    }
+
     /**
      * Add an element element.
      *
@@ -391,6 +421,46 @@ public class MacroDef extends AntlibDefinition  {
         }
     }
 
+    /**
+     * A nested define element for the MacroDef task.
+     * It provides an attribute with a guatanteed unique value on every instantiation of the macro.
+     * @since ant 1.7
+     */
+    public static class DefineAttribute extends Attribute {
+        private static long count = 0;
+        private String prefix = "";
+
+        /**
+         * Set a prefix for the generated name
+         * @param prefixValue the prefix to use.
+         */
+        public void setPrefix(String prefixValue) {
+            prefix = prefixValue;
+        }
+
+        /**
+         * Set the default value.
+         * This is not allowed for the define nested element.
+         * @param defaultValue not used
+         */
+        public void setDefault(String defaultValue) {
+            throw new BuildException(
+                "Illegal attribute \"default\" for define element");
+        }
+
+        /**
+         * Get the default value for this attibute.
+         * This returns the name "prefix#this classname#<a counter>.
+         * @return the generated name
+         */
+        public String getDefault() {
+            synchronized (DefineAttribute.class) {
+                // Make sure counter is managed globally
+                return prefix + "#" + DefineAttribute.class.getName() + "#" + (++count);
+            }
+        }
+    }
+
     /**
      * A nested text element for the MacroDef task.
      * @since ant 1.6.1

src/main/org/apache/tools/ant/taskdefs/MacroInstance.java

@@ -335,6 +335,9 @@ public class MacroInstance extends Task implements DynamicAttribute, TaskContain
             if (value == null) {
                 value = attribute.getDefault();
                 value = macroSubs(value, localProperties);
+            } else if (attribute instanceof MacroDef.DefineAttribute) {
+                // Do not process given value, will fail as unknown attribute
+                continue;
             }
             if (value == null) {
                 throw new BuildException(