diff --git a/WHATSNEW b/WHATSNEW index 9abc496a5..a9315472b 100644 --- a/WHATSNEW +++ b/WHATSNEW @@ -1,4 +1,18 @@ +Changes from Ant 1.2 to the current sources +=========================================== + +Other changes: +-------------- + +* New tasks: propertyfile + +Fixed bugs: +----------- + +* doesn't use deprectated methods anymore. + Changes from Ant 1.1 to Ant 1.2 +=============================== Changes that could break older environments: -------------------------------------------- diff --git a/docs/index.html b/docs/index.html index 9a0b47029..4a280028d 100644 --- a/docs/index.html +++ b/docs/index.html @@ -26,7 +26,7 @@
  • Dave Walend (dwalend@cs.tufts.edu)
  • -

    Version 1.2 - 2000/10/24

    +

    Version 1.3 - 2000/10/27


    Table of Contents

    diff --git a/src/main/org/apache/tools/ant/taskdefs/ExecTask.java b/src/main/org/apache/tools/ant/taskdefs/ExecTask.java index 181d2ab6e..a15e0ae72 100644 --- a/src/main/org/apache/tools/ant/taskdefs/ExecTask.java +++ b/src/main/org/apache/tools/ant/taskdefs/ExecTask.java @@ -101,7 +101,7 @@ public class ExecTask extends Task { } /** - * Only execute the process if os.name includes this string. + * Only execute the process if os.name is included in this string. */ public void setOs(String os) { this.os = os; diff --git a/src/main/org/apache/tools/ant/taskdefs/Javac.java b/src/main/org/apache/tools/ant/taskdefs/Javac.java index 754c3b11e..1e0622d15 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Javac.java +++ b/src/main/org/apache/tools/ant/taskdefs/Javac.java @@ -481,7 +481,9 @@ public class Javac extends MatchingTask { } } catch (ClassNotFoundException ex) { - throw new BuildException("Cannot use classic compiler, as it is not available", location); + throw new BuildException("Cannot use classic compiler, as it is not available"+ + " A common solution is to set the environment variable"+ + " JAVA_HOME to your jdk directory.", location); } catch (Exception ex) { if (ex instanceof BuildException) { diff --git a/src/main/org/apache/tools/ant/taskdefs/SignJar.java b/src/main/org/apache/tools/ant/taskdefs/SignJar.java index 16f409f73..9615ee2af 100644 --- a/src/main/org/apache/tools/ant/taskdefs/SignJar.java +++ b/src/main/org/apache/tools/ant/taskdefs/SignJar.java @@ -150,67 +150,57 @@ public class SignJar extends Task { final StringBuffer sb = new StringBuffer(); - sb.append("jarsigner "); - + final ExecTask cmd = (ExecTask) project.createTask("exec"); + cmd.setExecutable("jarsigner"); + if (null != keystore) { - sb.append("-keystore \""); - sb.append(keystore); - sb.append("\" "); + cmd.createArg().setValue("-keystore"); + cmd.createArg().setValue(keystore); } if (null != storepass) { - sb.append("-storepass \""); - sb.append(storepass); - sb.append("\" "); + cmd.createArg().setValue("-storepass"); + cmd.createArg().setValue(storepass); } if (null != storetype) { - sb.append("-storetype \""); - sb.append(storetype); - sb.append("\" "); + cmd.createArg().setValue("-storetype"); + cmd.createArg().setValue(storetype); } if (null != keypass) { - sb.append("-keypass \""); - sb.append(keypass); - sb.append("\" "); + cmd.createArg().setValue("-keypass"); + cmd.createArg().setValue(keypass); } if (null != sigfile) { - sb.append("-sigfile \""); - sb.append(sigfile); - sb.append("\" "); + cmd.createArg().setValue("-sigfile"); + cmd.createArg().setValue(sigfile); } if (null != signedjar) { - sb.append("-signedjar \""); - sb.append(signedjar); - sb.append("\" "); + cmd.createArg().setValue("-signedjar"); + cmd.createArg().setValue(signedjar); } if (verbose) { - sb.append("-verbose "); + cmd.createArg().setValue("-verbose"); } if (internalsf) { - sb.append("-internalsf "); + cmd.createArg().setValue("-internalsf"); } if (sectionsonly) { - sb.append("-sectionsonly "); + cmd.createArg().setValue("-sectionsonly"); } - sb.append('\"'); - sb.append(jar); - sb.append("\" "); + cmd.createArg().setValue(jar); - sb.append('\"'); - sb.append(alias); - sb.append("\" "); + + cmd.createArg().setValue(alias); log("Signing Jar : " + (new File(jar)).getAbsolutePath()); - final ExecTask cmd = (ExecTask) project.createTask("exec"); - cmd.setCommand(new Commandline(sb.toString())); cmd.setFailonerror(true); cmd.setTaskName( getTaskName() ); cmd.execute(); diff --git a/src/main/org/apache/tools/ant/types/Path.java b/src/main/org/apache/tools/ant/types/Path.java index 19814e3d0..a8080ec6e 100644 --- a/src/main/org/apache/tools/ant/types/Path.java +++ b/src/main/org/apache/tools/ant/types/Path.java @@ -60,6 +60,7 @@ import org.apache.tools.ant.Project; import org.apache.tools.ant.PathTokenizer; import java.io.File; +import java.io.IOException; import java.util.Enumeration; import java.util.StringTokenizer; import java.util.Stack; @@ -111,7 +112,16 @@ public class Path extends DataType implements Cloneable { private String[] parts; public void setLocation(File loc) { - parts = new String[] {translateFile(loc.getAbsolutePath())}; + try { + parts = new String[] {translateFile(loc.getCanonicalPath())}; + } catch(IOException e) { + // XXX I'd like to log something here but if I don't + // have a Project I can't + if (project != null) { + project.log(e.getMessage(), Project.MSG_WARN); + } + parts = new String[] {translateFile(loc.getAbsolutePath())}; + } } public void setPath(String path) { @@ -294,9 +304,15 @@ public class Path extends DataType implements Cloneable { String[] s = ds.getIncludedFiles(); File dir = fs.getDir(project); for (int j=0; j