diff --git a/src/etc/testcases/taskdefs/input.xml b/src/etc/testcases/taskdefs/input.xml
index 9e7942ea5..a2ec247fd 100644
--- a/src/etc/testcases/taskdefs/input.xml
+++ b/src/etc/testcases/taskdefs/input.xml
@@ -28,30 +28,4 @@
/>
-
- Press_Return_key_to_continue...
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
diff --git a/src/main/org/apache/tools/ant/taskdefs/compilers/CompilerAdapterFactory.java b/src/main/org/apache/tools/ant/taskdefs/compilers/CompilerAdapterFactory.java
index 29e4e61eb..e5d3a859c 100644
--- a/src/main/org/apache/tools/ant/taskdefs/compilers/CompilerAdapterFactory.java
+++ b/src/main/org/apache/tools/ant/taskdefs/compilers/CompilerAdapterFactory.java
@@ -62,8 +62,7 @@ public class CompilerAdapterFactory {
throws BuildException {
boolean isClassicCompilerSupported = true;
//as new versions of java come out, add them to this test
- if (!JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_1)
- && !JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_2)
+ if (!JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_2)
&& !JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_3)) {
isClassicCompilerSupported = false;
}
diff --git a/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java b/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java
index fdebd137e..71fddb2ce 100644
--- a/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java
+++ b/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java
@@ -529,11 +529,7 @@ public abstract class DefaultCompilerAdapter implements CompilerAdapter {
* @since Ant 1.5
*/
protected boolean assumeJava11() {
- return "javac1.1".equals(attributes.getCompilerVersion())
- || ("classic".equals(attributes.getCompilerVersion())
- && JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_1))
- || ("extJavac".equals(attributes.getCompilerVersion())
- && JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_1));
+ return "javac1.1".equals(attributes.getCompilerVersion());
}
/**
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/javah/SunJavah.java b/src/main/org/apache/tools/ant/taskdefs/optional/javah/SunJavah.java
index c71294b4f..6f7d57c25 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/javah/SunJavah.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/javah/SunJavah.java
@@ -24,7 +24,7 @@ import org.apache.tools.ant.taskdefs.ExecuteJava;
import org.apache.tools.ant.taskdefs.optional.Javah;
import org.apache.tools.ant.types.Commandline;
import org.apache.tools.ant.types.Path;
-import org.apache.tools.ant.util.JavaEnvUtils;
+
/**
* Adapter to com.sun.tools.javah.oldjavah.Main or com.sun.tools.javah.Main.
@@ -83,25 +83,18 @@ public class SunJavah implements JavahAdapter {
cmd.createArgument().setPath(javah.getClasspath());
}
- // JDK1.1 is rather simpler than JDK1.2
- if (JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_1)) {
- if (javah.getVerbose()) {
- cmd.createArgument().setValue("-v");
- }
- } else {
- if (javah.getVerbose()) {
- cmd.createArgument().setValue("-verbose");
- }
- if (javah.getOld()) {
- cmd.createArgument().setValue("-old");
- }
- if (javah.getForce()) {
- cmd.createArgument().setValue("-force");
- }
- if (javah.getStubs() && !javah.getOld()) {
- throw new BuildException("stubs only available in old mode.",
- javah.getLocation());
- }
+ if (javah.getVerbose()) {
+ cmd.createArgument().setValue("-verbose");
+ }
+ if (javah.getOld()) {
+ cmd.createArgument().setValue("-old");
+ }
+ if (javah.getForce()) {
+ cmd.createArgument().setValue("-force");
+ }
+ if (javah.getStubs() && !javah.getOld()) {
+ throw new BuildException("stubs only available in old mode.",
+ javah.getLocation());
}
if (javah.getStubs()) {
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/sitraka/Coverage.java b/src/main/org/apache/tools/ant/taskdefs/optional/sitraka/Coverage.java
index 661c1ab70..6d53b283b 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/sitraka/Coverage.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/sitraka/Coverage.java
@@ -332,12 +332,10 @@ public class Coverage extends CovBase {
// check for info, do your best to select the java executable.
// JProbe 3.0 fails if there is no javaexe option. So
if (javaExe == null && (vm == null || "java2".equals(vm))) {
- if (!JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_1)) {
- if (vm == null) {
- vm = "java2";
- }
- javaExe = new File(JavaEnvUtils.getJreExecutable("java"));
+ if (vm == null) {
+ vm = "java2";
}
+ javaExe = new File(JavaEnvUtils.getJreExecutable("java"));
}
}
diff --git a/src/main/org/apache/tools/ant/types/Path.java b/src/main/org/apache/tools/ant/types/Path.java
index 1c81e4a17..6e42d31d7 100644
--- a/src/main/org/apache/tools/ant/types/Path.java
+++ b/src/main/org/apache/tools/ant/types/Path.java
@@ -649,20 +649,15 @@ public class Path extends DataType implements Cloneable {
}
if (System.getProperty("java.vendor").toLowerCase(Locale.US).indexOf("microsoft") >= 0) {
+ // XXX is this code still necessary? is there any 1.2+ port?
// Pull in *.zip from packages directory
FileSet msZipFiles = new FileSet();
msZipFiles.setDir(new File(System.getProperty("java.home")
+ File.separator + "Packages"));
msZipFiles.setIncludes("*.ZIP");
addFileset(msZipFiles);
- } else if (JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_1)) {
- addExisting(new Path(null,
- System.getProperty("java.home")
- + File.separator + "lib"
- + File.separator
- + "classes.zip"));
} else {
- // JDK > 1.1 seems to set java.home to the JRE directory.
+ // JDK 1.2+ seems to set java.home to the JRE directory.
addExisting(new Path(null,
System.getProperty("java.home")
+ File.separator + "lib"
diff --git a/src/main/org/apache/tools/ant/util/JavaEnvUtils.java b/src/main/org/apache/tools/ant/util/JavaEnvUtils.java
index 03c32eb61..186b41152 100644
--- a/src/main/org/apache/tools/ant/util/JavaEnvUtils.java
+++ b/src/main/org/apache/tools/ant/util/JavaEnvUtils.java
@@ -138,6 +138,8 @@ public final class JavaEnvUtils {
* Compares the current Java version to the passed in String -
* assumes the argument is one of the constants defined in this
* class.
+ * Note that Ant now requires JDK 1.2+ so {@link #JAVA_1_0} and
+ * {@link #JAVA_1_1} need no longer be tested for.
* @param version the version to check against the current version.
* @return true if the version of Java is the same as the given version.
* @since Ant 1.5
diff --git a/src/testcases/org/apache/tools/ant/ProjectTest.java b/src/testcases/org/apache/tools/ant/ProjectTest.java
index 8524f3f35..79c555602 100644
--- a/src/testcases/org/apache/tools/ant/ProjectTest.java
+++ b/src/testcases/org/apache/tools/ant/ProjectTest.java
@@ -22,14 +22,10 @@ import org.apache.tools.ant.input.InputHandler;
import org.apache.tools.ant.input.PropertyFileInputHandler;
import org.apache.tools.ant.taskdefs.condition.Os;
import org.apache.tools.ant.types.*;
-import org.apache.tools.ant.util.JavaEnvUtils;
import java.io.File;
-
-import junit.framework.AssertionFailedError;
-import junit.framework.Test;
import junit.framework.TestCase;
-import junit.framework.TestSuite;
+
/**
* Very limited test class for Project. Waiting to be extended.
@@ -191,21 +187,8 @@ public class ProjectTest extends TestCase {
assertTaskDefFails(DummyTaskPrivate.class, DummyTaskPrivate.class + " is not public");
- try {
- assertTaskDefFails(DummyTaskProtected.class,
- DummyTaskProtected.class + " is not public");
- } catch (AssertionFailedError e) {
- /*
- * I don't understand this, but this is what happens with
- * > java -fullversion
- * java full version "Linux_JDK_1.1.8_v3_green_threads"
- * from time to time
- */
- assertTrue(JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_1));
- assertTaskDefFails(DummyTaskProtected.class,
- "No public no-arg constructor in "
- + DummyTaskProtected.class);
- }
+ assertTaskDefFails(DummyTaskProtected.class,
+ DummyTaskProtected.class + " is not public");
assertTaskDefFails(DummyTaskPackage.class, DummyTaskPackage.class + " is not public");
diff --git a/src/testcases/org/apache/tools/ant/taskdefs/CopyTest.java b/src/testcases/org/apache/tools/ant/taskdefs/CopyTest.java
index 553737b46..d71374163 100644
--- a/src/testcases/org/apache/tools/ant/taskdefs/CopyTest.java
+++ b/src/testcases/org/apache/tools/ant/taskdefs/CopyTest.java
@@ -19,7 +19,6 @@ package org.apache.tools.ant.taskdefs;
import org.apache.tools.ant.BuildFileTest;
import org.apache.tools.ant.util.FileUtils;
-import org.apache.tools.ant.util.JavaEnvUtils;
import java.io.File;
import java.io.IOException;
@@ -83,10 +82,8 @@ public class CopyTest extends BuildFileTest {
}
//file time checks for java1.2+
- if (!JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_1)) {
- assertTrue(file3a.lastModified()==file3.lastModified());
- assertTrue(file3c.lastModified()