checkstyle

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@477343 13f79535-47bb-0310-9956-ffa450edef68

src/main/org/apache/tools/ant/taskdefs/Length.java

@@ -295,7 +295,7 @@ public class Length extends Task implements Condition {
     }
 
     private class AllHandler extends Handler {
-        long accum = 0L;
+        private long accum = 0L;
         AllHandler(PrintStream ps) {
             super(ps);
         }

src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java

@@ -427,7 +427,7 @@ public class EmailTask extends Task {
                 }
             }
             // SMTP auth only allowed with MIME mail
-            if (autoFound == false && ((user != null) || (password != null))
+            if (!autoFound && ((user != null) || (password != null))
                 && (encoding.equals(UU) || encoding.equals(PLAIN))) {
                 throw new BuildException("SMTP auth only possible with MIME mail");
             }

src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java

@@ -58,7 +58,7 @@ import org.apache.tools.ant.BuildException;
  * @since Ant 1.5
  */
 public class MimeMailer extends Mailer {
-    private final static String SSL_FACTORY = "javax.net.ssl.SSLSocketFactory";
+    private static final String SSL_FACTORY = "javax.net.ssl.SSLSocketFactory";
 
     /** Default character set */
     private static final String DEFAULT_CHARSET

src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java

@@ -2531,7 +2531,7 @@ public class FTP
         private static final String[] VALID_LANGUAGE_CODES =
             getValidLanguageCodes();
 
-        private static final String[] getValidLanguageCodes() {
+        private static String[] getValidLanguageCodes() {
             Collection c = FTPClientConfig.getSupportedLanguageCodes();
             String[] ret = new String[c.size() + 1];
             int i = 0;

src/main/org/apache/tools/mail/SmtpResponseReader.java

@@ -32,8 +32,9 @@ import java.io.InputStreamReader;
  *
  */
 public class SmtpResponseReader {
-
+    // CheckStyle:VisibilityModifier OFF - bc
     protected BufferedReader reader = null;
+    // CheckStyle:VisibilityModifier ON
     private StringBuffer result = new StringBuffer();
 
     /**