From 0c132498a8026db624c2fcf7026538c52e47b312 Mon Sep 17 00:00:00 2001 From: Matthew Jason Benson Date: Fri, 11 Feb 2005 18:48:24 +0000 Subject: [PATCH] File inclusion: unnecessarily checked presence of selectors AND DirectoryScanner.isEverythingIncluded, which will be false if selectors cause omissions. git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277645 13f79535-47bb-0310-9956-ffa450edef68 --- src/main/org/apache/tools/ant/taskdefs/Copy.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/main/org/apache/tools/ant/taskdefs/Copy.java b/src/main/org/apache/tools/ant/taskdefs/Copy.java index 4222b7205..3127fdbb7 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Copy.java +++ b/src/main/org/apache/tools/ant/taskdefs/Copy.java @@ -415,10 +415,8 @@ public class Copy extends Task { String[] srcFiles = ds.getIncludedFiles(); String[] srcDirs = ds.getIncludedDirectories(); - boolean isEverythingIncluded = ds.isEverythingIncluded() - && (!fs.hasSelectors() && !fs.hasPatterns()); - if (isEverythingIncluded - && !flatten && mapperElement == null) { + if (!flatten && mapperElement == null + && ds.isEverythingIncluded() && !fs.hasPatterns()) { completeDirMap.put(fromDir, destDir); } scan(fromDir, destDir, srcFiles, srcDirs);