From 06f6d787d2c96939d850d1cd735d12dd4355d6fa Mon Sep 17 00:00:00 2001 From: Stefan Bodewig Date: Fri, 19 Jan 2001 14:55:54 +0000 Subject: [PATCH] Add some sanity checks. If we allow an empty token, we end up in an endless loop - as demonstrated by unittest test4. git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@268481 13f79535-47bb-0310-9956-ffa450edef68 --- src/main/org/apache/tools/ant/taskdefs/Replace.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/main/org/apache/tools/ant/taskdefs/Replace.java b/src/main/org/apache/tools/ant/taskdefs/Replace.java index 250c5eea0..9bab5f53d 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Replace.java +++ b/src/main/org/apache/tools/ant/taskdefs/Replace.java @@ -213,6 +213,15 @@ public class Replace extends MatchingTask { String message = "Property file " + propertyFile.getPath() + " does not exist."; throw new BuildException(message, location); } + if (token == null && replacefilters.size() == 0) { + String message = "Either token or a nested replacefilter " + + "must be specified"; + throw new BuildException(message, location); + } + if (token != null && "".equals(token.getText())) { + String message ="The token attribute must not be an empty string."; + throw new BuildException(message, location); + } } /**