checkstyle

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@565095 13f79535-47bb-0310-9956-ffa450edef68

src/main/org/apache/tools/ant/taskdefs/optional/EchoProperties.java

@@ -421,7 +421,7 @@ public class EchoProperties extends Task {
     /**
      * a tuple for the sort list.
      */
-    private static class Tuple implements Comparable {
+    private static final class Tuple implements Comparable {
         private String key;
         private String value;
 

src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java

@@ -225,7 +225,7 @@ public class Rpm extends Task {
      * @param sf the spec file name to use.
      */
     public void setSpecFile(String sf) {
-        if ((sf == null) || (sf.trim().length()==0)) {
+        if ((sf == null) || (sf.trim().length() == 0)) {
             throw new BuildException("You must specify a spec file", getLocation());
         }
         this.specFile = sf;

src/main/org/apache/tools/ant/taskdefs/optional/depend/ClassFileUtils.java

@@ -24,6 +24,7 @@ package org.apache.tools.ant.taskdefs.optional.depend;
  *
  *
  */
+// CheckStyle:HideUtilityClassConstructorCheck OFF (bc)
 public class ClassFileUtils {
 
     /**

src/main/org/apache/tools/ant/taskdefs/optional/extension/ExtensionUtil.java

@@ -34,7 +34,7 @@ import org.apache.tools.ant.types.FileSet;
  * A set of useful methods relating to extensions.
  *
  */
-public class ExtensionUtil {
+public final class ExtensionUtil {
     /**
      * Class is not meant to be instantiated.
      */

src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibResolveTask.java

@@ -230,7 +230,8 @@ public class JarLibResolveTask extends Task {
                     return;
                 }
             }
-            final String message = "File " + file + " skipped as it " + "does not satisfy extension";
+            final String message = "File " + file + " skipped as it "
+                + "does not satisfy extension";
             getProject().log(message, Project.MSG_VERBOSE);
             throw new BuildException(message);
         }

src/main/org/apache/tools/ant/taskdefs/optional/javah/JavahAdapterFactory.java

@@ -28,6 +28,7 @@ import org.apache.tools.ant.util.JavaEnvUtils;
  *
  * @since Ant 1.6.3
  */
+// CheckStyle:HideUtilityClassConstructorCheck OFF (bc)
 public class JavahAdapterFactory {
 
     /**

src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapter.java

@@ -26,6 +26,7 @@ import org.apache.tools.ant.taskdefs.optional.Native2Ascii;
  *
  * @since Ant 1.6.3
  */
+// CheckStyle:HideUtilityClassConstructorCheck OFF (bc)
 public interface Native2AsciiAdapter {
     /**
      * Convert the encoding of srcFile writing to destFile.

src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapterFactory.java

@@ -28,6 +28,7 @@ import org.apache.tools.ant.util.JavaEnvUtils;
  *
  * @since Ant 1.6.3
  */
+// CheckStyle:HideUtilityClassConstructorCheck OFF (bc)
 public class Native2AsciiAdapterFactory {
 
     /**

src/main/org/apache/tools/ant/taskdefs/optional/net/FTPConfigurator.java

@@ -28,6 +28,7 @@ import org.apache.tools.ant.Project;
  * upgrade to jakarta-commons-net 1.4.0, where FTPClientConfig was
  * introduced.
   */
+// CheckStyle:HideUtilityClassConstructorCheck OFF (bc)
 class FTPConfigurator {
     /**
      * configures the supplied FTPClient with the various

src/main/org/apache/tools/ant/taskdefs/optional/sos/SOSCmd.java

@@ -21,6 +21,7 @@ package org.apache.tools.ant.taskdefs.optional.sos;
  * Interface to hold constants used by the SOS tasks
  *
  */
+// CheckStyle:InterfaceIsTypeCheck OFF (bc)
 public interface SOSCmd {
     // soscmd Command options
     /** The sos executable */

src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSSConstants.java

@@ -21,6 +21,7 @@ package org.apache.tools.ant.taskdefs.optional.vss;
  *  Holds all the constants for the VSS tasks.
  *
  */
+// CheckStyle:InterfaceIsType OFF (bc)
 public interface MSVSSConstants {
     /**  Constant for the thing to execute  */
     String SS_EXE = "ss";