commit dece19d895
Merge: fdaa689ae764dafe
Author: Still Hsu <341464@gmail.com>
Date: Mon May 21 11:47:47 2018 +0800
Merge branch 'dev' into docs/faq-n-patches-offline
commit e764dafe08
Author: Quahu <quahuu@gmail.com>
Date: Sun May 13 15:34:40 2018 +0200
Add ViewChannel to Voice channel permissions (#1059)
Previously, Voice channels did not have ViewChannel in their "all" permissions
commit 32fc2df21b
Author: Alex Gravely <tcbskater@hotmail.com>
Date: Sat May 12 20:47:44 2018 -0400
Remove unused field in EmbedFieldBuilder. (#1018)
commit 39dffe8585
Author: Finite Reality <FiniteReality@users.noreply.github.com>
Date: Sun May 13 01:46:07 2018 +0100
Audit Logs implementation (#1055)
* Copy audit logs impl from old branch and clean up
I suck at using git, so I'm gonna use brute force.
* Remove unnecessary TODOs
Category channels do not provide any new information, and the other
I forgot to remove beforehand
* Add invite update data, clean up after feedback
* Remove TODOs, add WebhookType enum for future use
WebhookType is a future-use type, as currently audit logs are the only
thing which may return it.
commit fdaa689ae8
Author: Still Hsu <341464@gmail.com>
Date: Wed May 9 06:04:59 2018 +0800
Add explanation for RunMode
commit ea82c2537e
Author: Still Hsu <341464@gmail.com>
Date: Tue May 8 16:30:48 2018 +0800
Initial proofread of the articles
commit 124f1a267c
Merge: 2555721897c89310
Author: Still Hsu <341464@gmail.com>
Date: Tue May 8 05:02:01 2018 +0800
Merge branch 'dev' into docs/faq-n-patches-offline
commit 97c893107b
Author: Still Hsu <341464@gmail.com>
Date: Mon May 7 06:22:49 2018 +0800
Implement GetBanAsync (#1056)
commit 25557218db
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 16:11:19 2018 +0800
Add details to SpotifyGame
commit c7b236ddf5
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 15:58:23 2018 +0800
Add more IGuild docs
commit 1bb06cc37b
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 15:40:31 2018 +0800
Replace all langword placements with code block
commit ac47d84ea7
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 15:22:17 2018 +0800
Replace langword null to code block null instead
- Because DocFX sucks at rendering langword
commit 0b15bbc54d
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 15:20:34 2018 +0800
Add XML docs
commit 65d4e4360e
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 06:57:53 2018 +0800
Add BaseSocketClient docs
commit 8f64c04599
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 06:37:55 2018 +0800
Replace note block
commit d8bb9e7aaa
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 06:31:50 2018 +0800
Add warning for bulk-delete endpoint
commit adae5ffc9e
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 06:07:28 2018 +0800
Fix missing Username prop
commit 3e591972ca
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 06:01:34 2018 +0800
Add properties examples to overwrite
commit 0ad66f6765
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 04:55:15 2018 +0800
Fix minor consistencies & redundant impl
commit 124efdf7e6
Author: Still Hsu <341464@gmail.com>
Date: Sun May 6 04:40:14 2018 +0800
XML Docs
commit 3aa5d363de
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 18:22:46 2018 +0800
Add 'last modified' plugin
Source: https://github.com/Still34/DocFx.Plugin.LastModified
Licensed under MIT License
commit 2014870dc0
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 15:57:40 2018 +0800
Fix letter-casing for files
commit f27d659ebe
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 15:50:00 2018 +0800
Document exposed TypeReaders
commit 5a824a5695
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 15:44:15 2018 +0800
Add missing exceptions
commit c2de0c055f
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 15:40:16 2018 +0800
Fix seealso for preconditions and add missing descriptions
commit 3a7d7ee955
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 15:36:22 2018 +0800
Minor fixes in documentations
+ Fix unescaped '<'
+ Fix typo
commit 45839bd982
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 15:29:47 2018 +0800
Add XML Docs
commit 9e6254600c
Merge: aea06788bb4bb138
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 14:48:13 2018 +0800
Merge branch 'dev' into docs/faq-n-patches-offline
commit aea067884c
Merge: 27dc48319ddd7090
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 13:51:07 2018 +0800
Merge branch 'docs/faq-n-patches-offline' of https://github.com/Still34/Discord.Net into docs/faq-n-patches-offline
commit 27dc4831e8
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 13:50:27 2018 +0800
Add XML Docs
commit baa8beb382
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 13:49:42 2018 +0800
Add XML Docs
commit 089f97a010
Author: Still Hsu <341464@gmail.com>
Date: Sat May 5 13:43:04 2018 +0800
Add details regarding userbot support
commit bb4bb13846
Author: Finite Reality <FiniteReality@users.noreply.github.com>
Date: Fri May 4 11:42:54 2018 +0100
Fix issues with #984, remove extraneous whitespace (#1051)
- Removed unnecessary parameter in SocketVoiceServer
- Moved SocketVoiceServer into Entities/Voice
- Fixed a bug where trying to download the cached guild would throw
- Fixed a potential bug where Discord might not give us a port when
connecting to voice
commit 9ddd70906a
Merge: f197174f7cfed7ff
Author: Still Hsu <341464@gmail.com>
Date: Fri May 4 09:37:04 2018 +0800
Merge branch 'dev' into docs/faq-n-patches-offline
commit f197174fcc
Author: Still Hsu <341464@gmail.com>
Date: Fri May 4 09:36:53 2018 +0800
Fix embed docs consistency
commit 7cfed7ff67
Author: Alex Gravely <tcbskater@hotmail.com>
Date: Thu May 3 21:30:13 2018 -0400
Fix nullref when passing null to GetShardIdFor. (#1049)
commit e775853b1b
Author: Luke <dev@crimsonxv.pro>
Date: Fri May 4 02:29:51 2018 +0100
Expose VoiceServerUpdate events (#984)
* Expose VoiceServerUpdate events
* Amend based on feedback
* Move this out of guild entity
* Fix namespace issue
* Adjust based on feedback #2
* Use cacheable instead
* Change based on feedback
commit 157acc4695
Author: Still Hsu <341464@gmail.com>
Date: Thu May 3 23:03:35 2018 +0800
Add tag examples
commit 57ea571a81
Author: Still Hsu <341464@gmail.com>
Date: Thu May 3 22:48:33 2018 +0800
Fix sample link & add missing pictures
commit 6769c37ad7
Author: Still Hsu <341464@gmail.com>
Date: Thu May 3 22:39:26 2018 +0800
Compress some assets & add OAuth2 URL generator
+ Rename Guides.Concepts.Logging title from 'Logging' to 'Logging Events/Data'.
+ Rewrite various sections of Guides.GettingStarted.FirstBot and Guides.GettingStarted.Installing based on suggested changes from #1027.
+ Rename project.csproj example to project.xml to avoid auto-compilation from Visual Studio Code.
+ Rename 'samples\intro' to 'samples\first-bot' to reflect on the article name change.
+ Clean first-bot samples.
* Improve the Command Service documentation
The following changes have been added to this PR:
• Fix minor grammatical errors.
• Capitalize terms such as Commands, Modules and such, as the context is specific to the lib.
• Wrap methods and properties in code blocks.
The docs page currently has several issues that remains to be fixed.
1.
```md
>[!WARNING]
>This article is out of date and has not been rewritten yet.
Information is not guaranteed to be accurate.
```
The docs doesn't necessarily seem "out of date" as the warning claims. The basics seem pretty relevant to the latest version of the lib.
2.
>“To manually load a module, invoke [CommandService.AddModuleAsync], by passing in the generic type of your module and optionally, a dependency map.”
The latter part of the sentence seems off. Where should the user pass the dependency map to? It seems to suggest that `AddModuleAsync` has an argument to pass the dependency to. If it is referring to `AddModuleAsync(Type type)`, then I feel like it should be clarified here - or perhaps change the wording of the sentence.
3.
>“First, you need to create an @System.IServiceProvider You may create your own IServiceProvider if you wish.”
Any mention of @System.IServiceProvider is currently broken on the docs.
4.
>“Submodules are Modules that reside within another one. Typically, submodules are used to create nested groups (although not required to create nested groups).”
Clarification on the part after "although?"
5.
>“Finally, pass the map into the LoadAssembly method. Your modules will automatically be loaded with this dependency map.”
Where is this `LoadAssembly` method?
6.
```md
>[!NOTE]
>Preconditions can be applied to Modules, Groups, or Commands.
```
The docs should mention `ParameterPreconditionAttribute`'s existence.
* Update line breaks to comply with docs standard
* Change "you should..." to "instead, ..."
* Trim trailing spaces
* Change "inherits" to "inherit"
* Fix Context warning note and add ReplyAsync xref
* Fix broken xrefs
* Fix [Command Service] xref
* Fix consistency between TypeReaders and Preconditions returns
* Add missing semi-colons in ServiceProvider sample
* Change CommandContext to SocketCommandContext & change variable naming
* Cleanup TypeReader section
* Wrap [DontInject] in code block
* Fix commands docs linking in intro
* Improve Getting Started - Installation
- Fix character misalignment to comply with docs standard.
- Fix image numbering issues by moving the tooltips above some of the steps.
- Add codeblocks to search terms like `Discord.Net`.
- Remove broken `addons` reference.
- Specify `.NET 4.6.1` as `.NET Framework 4.6.1`.
- Minor cross-reference cleanup.
* Fix Getting Started - Intro
- Minor grammartical fixes.
- Wrap mentions of the methods, properties, and events in code block.
- Replace `Discord.Net` to `Discord.NET`.
- Fix steps numbering under `Creating a Discord Bot` and `Adding your bot to a server`.
- Change `Task-based Asynchronous Pattern ([TAP])` linking to mark the entire term instead.
- Change code block of `Pong!` to quotation mark instead.
* Fix cross references in Sending Voice
* Mention parameter precondition attribute
* Change `Discord.NET` to `Discord.Net` for consistency
* Wrap project names in code blocks & minor fixes in Terminology
* Change `add-ons` to `addons` for consistency
* Fix cross references in Logging
* Fix minor grammatical issues in "Working with Events"
* Missed a tilda
* Remove out-of-date warning in Commands
* Minor grammatical fixes for Entities
* Fix broken xref in Logging
* Adjust service collection sample
...according to f89aecb7bf (r141530227)
* Update Command Handler sample
- Update Main for C# 7.1.
- Inject CommandService and DiscordSocketClient into the service collection.
- Add Async suffix to asynchronous methods.
* Minor grammatical fixes in Events
* Revert 2 incorrect grammar corrections
* Revert async Main sample
* Add hardcode token notice in sample
* Fix missing method for Command Handler
* Modify module samples to use SocketCommandContext instead
* Emphasize CommandContext and SocketCommandContext
* Fix formatting for module sample
* Add SocketCommandContext for Groups sample
* Remove comma
* Fix DepMap sample formatting
* Replace [DontInject] with DontInjectAttribute with cross reference
* Remove connection logic note
There is no reason that this note should still be here since Ready event exists.
* Add a new warning message informing the users the existence of CommandService
* Make command handler private
excellent change
Still Hsu
Benjamin
Christopher F