Browse Source

fix: strip trailing slash from ratelimit bucket IDs (#1163)

* fix: strip trailing slash from ratelimit bucket IDs

This resolves #1125.

fixes a bug where some ratelimit buckets would include a trailing slash,
while others wouldn't; this would cause them to be treated as separate
ratelimits, even though they are the same

ideally this fix should change the ratelimit generator, but that code is
pretty complicated and this was an easier fix that seems less likely to
break things in the future.

tested against normal bot function, all routes are assigned the proper
buckets from my testing, so this should be good to go.

* lint: use more performant algorithm, operate on StringBuilder
tags/2.0
Christopher F GitHub 6 years ago
parent
commit
fe07a83f1f
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
  1. +4
    -0
      src/Discord.Net.Rest/DiscordRestApiClient.cs

+ 4
- 0
src/Discord.Net.Rest/DiscordRestApiClient.cs View File

@@ -1,3 +1,4 @@

#pragma warning disable CS1591
using Discord.API.Rest;
using Discord.Net;
@@ -1426,8 +1427,11 @@ namespace Discord.API

lastIndex = rightIndex + 1;
}
if (builder[builder.Length - 1] == '/')
builder.Remove(builder.Length - 1, 1);

format = builder.ToString();

return x => string.Format(format, x.ToArray());
}
catch (Exception ex)


Loading…
Cancel
Save