From fbe8ccb5da69e467fce4288ffe5d5155f903b721 Mon Sep 17 00:00:00 2001 From: Paulo Anjos Date: Sun, 15 Jan 2017 23:44:47 -0200 Subject: [PATCH] Better handling of Success/Error --- src/Discord.Net.Commands/Readers/NullableTypeReader.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Discord.Net.Commands/Readers/NullableTypeReader.cs b/src/Discord.Net.Commands/Readers/NullableTypeReader.cs index ce5ad611a..1a8e21e47 100644 --- a/src/Discord.Net.Commands/Readers/NullableTypeReader.cs +++ b/src/Discord.Net.Commands/Readers/NullableTypeReader.cs @@ -24,10 +24,12 @@ namespace Discord.Commands public override Task Read(ICommandContext context, string input) { + if(input == null) + return Task.FromResult(TypeReaderResult.FromSuccess(new Nullable())); T value; if (_tryParse(input, out value)) return Task.FromResult(TypeReaderResult.FromSuccess(new Nullable(value))); - return Task.FromResult(TypeReaderResult.FromSuccess(new Nullable())); + return Task.FromResult(TypeReaderResult.FromError(CommandError.ParseFailed, $"Failed to parse {typeof(T).Name}")); } } }