diff --git a/src/Discord.Net.Modules/ModuleManager.cs b/src/Discord.Net.Modules/ModuleManager.cs index 0172e15c1..af70d0967 100644 --- a/src/Discord.Net.Modules/ModuleManager.cs +++ b/src/Discord.Net.Modules/ModuleManager.cs @@ -17,10 +17,7 @@ namespace Discord.Modules public event EventHandler ServerUpdated = delegate { }; public event EventHandler ServerUnavailable = delegate { }; public event EventHandler ServerAvailable = delegate { }; - - public event EventHandler UserBanned = delegate { }; - public event EventHandler UserUnbanned = delegate { }; - + public event EventHandler ChannelCreated = delegate { }; public event EventHandler ChannelDestroyed = delegate { }; public event EventHandler ChannelUpdated = delegate { }; @@ -29,11 +26,13 @@ namespace Discord.Modules public event EventHandler RoleUpdated = delegate { }; public event EventHandler RoleDeleted = delegate { }; + public event EventHandler UserBanned = delegate { }; public event EventHandler UserJoined = delegate { }; public event EventHandler UserLeft = delegate { }; public event EventHandler UserUpdated = delegate { }; public event EventHandler UserPresenceUpdated = delegate { }; public event EventHandler UserVoiceStateUpdated = delegate { }; + public event EventHandler UserUnbanned = delegate { }; public event EventHandler UserIsTypingUpdated = delegate { }; public event EventHandler MessageReceived = delegate { }; diff --git a/src/Discord.Net.Net45/Discord.Net.csproj b/src/Discord.Net.Net45/Discord.Net.csproj index 713ea4180..91b4c8477 100644 --- a/src/Discord.Net.Net45/Discord.Net.csproj +++ b/src/Discord.Net.Net45/Discord.Net.csproj @@ -419,9 +419,6 @@ Enums\UserStatus.cs - - Events\BanEventArgs.cs - Events\ChannelEventArgs.cs diff --git a/src/Discord.Net/API/Client/GatewaySocket/Events/GuildBanAdd.cs b/src/Discord.Net/API/Client/GatewaySocket/Events/GuildBanAdd.cs index a89d19619..f3829ae70 100644 --- a/src/Discord.Net/API/Client/GatewaySocket/Events/GuildBanAdd.cs +++ b/src/Discord.Net/API/Client/GatewaySocket/Events/GuildBanAdd.cs @@ -3,11 +3,7 @@ using Newtonsoft.Json; namespace Discord.API.Client.GatewaySocket { - public sealed class GuildBanAddEvent + public sealed class GuildBanAddEvent : MemberReference { - [JsonProperty("guild_id"), JsonConverter(typeof(LongStringConverter))] - public ulong GuildId { get; set; } - [JsonProperty("user_id"), JsonConverter(typeof(LongStringConverter))] - public ulong UserId { get; set; } } } diff --git a/src/Discord.Net/API/Client/GatewaySocket/Events/GuildBanRemove.cs b/src/Discord.Net/API/Client/GatewaySocket/Events/GuildBanRemove.cs index c490fdc9a..00f3d2de3 100644 --- a/src/Discord.Net/API/Client/GatewaySocket/Events/GuildBanRemove.cs +++ b/src/Discord.Net/API/Client/GatewaySocket/Events/GuildBanRemove.cs @@ -3,11 +3,7 @@ using Newtonsoft.Json; namespace Discord.API.Client.GatewaySocket { - public sealed class GuildBanRemoveEvent + public sealed class GuildBanRemoveEvent : MemberReference { - [JsonProperty("guild_id"), JsonConverter(typeof(LongStringConverter))] - public ulong GuildId { get; set; } - [JsonProperty("user_id"), JsonConverter(typeof(LongStringConverter))] - public ulong UserId { get; set; } } } diff --git a/src/Discord.Net/DiscordClient.Events.cs b/src/Discord.Net/DiscordClient.Events.cs index bbb1d5e56..d078b3105 100644 --- a/src/Discord.Net/DiscordClient.Events.cs +++ b/src/Discord.Net/DiscordClient.Events.cs @@ -24,13 +24,13 @@ namespace Discord public event EventHandler ServerAvailable = delegate { }; public event EventHandler ServerUpdated = delegate { }; public event EventHandler ServerUnavailable = delegate { }; - public event EventHandler UserBanned = delegate { }; + public event EventHandler UserBanned = delegate { }; public event EventHandler UserIsTypingUpdated = delegate { }; public event EventHandler UserJoined = delegate { }; public event EventHandler UserLeft = delegate { }; public event EventHandler UserPresenceUpdated = delegate { }; public event EventHandler UserUpdated = delegate { }; - public event EventHandler UserUnbanned = delegate { }; + public event EventHandler UserUnbanned = delegate { }; public event EventHandler UserVoiceStateUpdated = delegate { }; private void OnConnected() @@ -77,8 +77,8 @@ namespace Discord private void OnServerUnavailable(Server server) => OnEvent(ServerUnavailable, new ServerEventArgs(server)); - private void OnUserBanned(Server server, ulong userId) - => OnEvent(UserBanned, new BanEventArgs(server, userId)); + private void OnUserBanned(User user) + => OnEvent(UserBanned, new UserEventArgs(user)); private void OnUserIsTypingUpdated(Channel channel, User user) => OnEvent(UserIsTypingUpdated, new ChannelUserEventArgs(channel, user)); private void OnUserJoined(User user) @@ -87,8 +87,8 @@ namespace Discord => OnEvent(UserLeft, new UserEventArgs(user)); private void OnUserPresenceUpdated(User user) => OnEvent(UserPresenceUpdated, new UserEventArgs(user)); - private void OnUserUnbanned(Server server, ulong userId) - => OnEvent(UserUnbanned, new BanEventArgs(server, userId)); + private void OnUserUnbanned(User user) + => OnEvent(UserUnbanned, new UserEventArgs(user)); private void OnUserUpdated(User user) => OnEvent(UserUpdated, new UserEventArgs(user)); private void OnUserVoiceStateUpdated(User user) diff --git a/src/Discord.Net/DiscordClient.cs b/src/Discord.Net/DiscordClient.cs index dc4ac5637..18e02ed85 100644 --- a/src/Discord.Net/DiscordClient.cs +++ b/src/Discord.Net/DiscordClient.cs @@ -718,24 +718,30 @@ namespace Discord case "GUILD_BAN_ADD": { var data = e.Payload.ToObject(_serializer); - var server = GetServer(data.GuildId); + var server = GetServer(data.GuildId.Value); if (server != null) { - if (Config.LogEvents) - Logger.Info($"User Banned: {server.Name}/{data.UserId}"); - OnUserBanned(server, data.UserId); + var user = server.GetUser(data.User.Id); + if (user != null) + { + if (Config.LogEvents) + Logger.Info($"User Banned: {server.Name}/{user.Name}"); + OnUserBanned(user); + } } } break; case "GUILD_BAN_REMOVE": { var data = e.Payload.ToObject(_serializer); - var server = GetServer(data.GuildId); + var server = GetServer(data.GuildId.Value); if (server != null) { + var user = new User(this, data.User.Id, server); + user.Update(data.User); if (Config.LogEvents) - Logger.Info($"User Unbanned: {server.Name}/{data.UserId}"); - OnUserUnbanned(server, data.UserId); + Logger.Info($"User Unbanned: {server.Name}/{user.Name}"); + OnUserUnbanned(user); } } break; diff --git a/src/Discord.Net/Events/BanEventArgs.cs b/src/Discord.Net/Events/BanEventArgs.cs deleted file mode 100644 index 0bddc38ea..000000000 --- a/src/Discord.Net/Events/BanEventArgs.cs +++ /dev/null @@ -1,16 +0,0 @@ -using System; - -namespace Discord -{ - public class BanEventArgs : EventArgs - { - public Server Server { get; } - public ulong UserId { get; } - - public BanEventArgs(Server server, ulong userId) - { - Server = server; - UserId = userId; - } - } -}