Cleaned up MentionUtils

src/Discord.Net/Entities/Messages/Message.cs

@@ -114,7 +114,7 @@ namespace Discord
                 
                 if (guildChannel != null)
                 {
-                    MentionedUsers = MentionUtils.GetUserMentions(text, Channel.IsAttached ? Channel : null, MentionedUsers);
+                    MentionedUsers = MentionUtils.GetUserMentions(text, Channel, MentionedUsers);
                     MentionedChannelIds = MentionUtils.GetChannelMentions(text, guildChannel.Guild);
                     MentionedRoles = MentionUtils.GetRoleMentions(text, guildChannel.Guild);
                 }
@@ -173,8 +173,7 @@ namespace Discord
             text = MentionUtils.ResolveUserMentions(text, Channel, MentionedUsers, userMode);
             if (guild != null)
             {
-                if  (guild.IsAttached)  //It's too expensive to do a channel lookup in REST mode
-                    text = MentionUtils.ResolveChannelMentions(text, guild);
+                text = MentionUtils.ResolveChannelMentions(text, guild);
                 text = MentionUtils.ResolveRoleMentions(text, guild, MentionedRoles);
             }
             return text;

src/Discord.Net/Utilities/MentionUtils.cs

@@ -99,7 +99,7 @@ namespace Discord
                 if (ulong.TryParse(match.Groups[1].Value, NumberStyles.None, CultureInfo.InvariantCulture, out id))
                 {
                     IUser user = null;
-                    if (channel != null)
+                    if (channel.IsAttached) //Waiting this sync is safe because it's using a cache
                         user = channel.GetUserAsync(id).GetAwaiter().GetResult() as IUser;
                     if (user == null)
                     {
@@ -195,18 +195,22 @@ namespace Discord
         }
         internal static string ResolveChannelMentions(string text, IGuild guild)
         {
-            return _channelRegex.Replace(text, new MatchEvaluator(e =>
+            if (guild.IsAttached) //It's too expensive to do a channel lookup in REST mode
             {
-                ulong id;
-                if (ulong.TryParse(e.Groups[1].Value, NumberStyles.None, CultureInfo.InvariantCulture, out id))
+                return _channelRegex.Replace(text, new MatchEvaluator(e =>
                 {
-                    IGuildChannel channel = null;
-                    channel = guild.GetChannelAsync(id).GetAwaiter().GetResult();
-                    if (channel != null)
-                        return '#' + channel.Name;
-                }
-                return e.Value;
-            }));
+                    ulong id;
+                    if (ulong.TryParse(e.Groups[1].Value, NumberStyles.None, CultureInfo.InvariantCulture, out id))
+                    {
+                        IGuildChannel channel = null;
+                        channel = guild.GetChannelAsync(id).GetAwaiter().GetResult();
+                        if (channel != null)
+                            return '#' + channel.Name;
+                    }
+                    return e.Value;
+                }));
+            }
+            return text;
         }
         internal static string ResolveRoleMentions(string text, IGuild guild, IReadOnlyCollection<IRole> mentions)
         {