Browse Source

Fix null ref for emotes

pull/1923/head
quin lynch 4 years ago
parent
commit
dbc13d58b6
5 changed files with 27 additions and 27 deletions
  1. +5
    -5
      src/Discord.Net.Rest/API/Common/ButtonComponent.cs
  2. +1
    -1
      src/Discord.Net.Rest/Discord.Net.Rest.csproj
  3. +5
    -5
      src/Discord.Net.Rest/Entities/Messages/RestMessage.cs
  4. +6
    -6
      src/Discord.Net.WebSocket/Entities/Messages/SocketMessage.cs
  5. +10
    -10
      src/Discord.Net/Discord.Net.nuspec

+ 5
- 5
src/Discord.Net.Rest/API/Common/ButtonComponent.cs View File

@@ -16,19 +16,19 @@ namespace Discord.API
public ButtonStyle Style { get; set; }

[JsonProperty("label")]
public string Label { get; set; }
public Optional<string> Label { get; set; }

[JsonProperty("emoji")]
public Emoji Emote { get; set; }
public Optional<Emoji> Emote { get; set; }

[JsonProperty("custom_id")]
public string CustomId { get; set; }
public Optional<string> CustomId { get; set; }

[JsonProperty("url")]
public string Url { get; set; }
public Optional<string> Url { get; set; }

[JsonProperty("disabled")]
public bool Disabled { get; set; }
public Optional<bool> Disabled { get; set; }


public ButtonComponent() { }


+ 1
- 1
src/Discord.Net.Rest/Discord.Net.Rest.csproj View File

@@ -9,7 +9,7 @@
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netstandard2.0;netstandard2.1</TargetFrameworks>
<PackageIcon>Temporary.png</PackageIcon>
<PackageProjectUrl>https://github.com/Discord-Net-Labs/Discord.Net-Labs</PackageProjectUrl>
<Version>2.3.3</Version>
<Version>2.3.4</Version>
<PackageId>Discord.Net.Labs.Rest</PackageId>
<RepositoryUrl>https://github.com/Discord-Net-Labs/Discord.Net-Labs</RepositoryUrl>
</PropertyGroup>


+ 5
- 5
src/Discord.Net.Rest/Entities/Messages/RestMessage.cs View File

@@ -132,11 +132,11 @@ namespace Discord.Rest
Components = model.Components.Value.Select(x => new ActionRowComponent(x.Components.Select(x =>
new ButtonComponent(
x.Style,
x.Label,
x.Emote.Id.HasValue ? new Emote(x.Emote.Id.Value, x.Emote.Name, x.Emote.Animated.GetValueOrDefault()) : new Emoji(x.Emote.Name),
x.CustomId,
x.Url,
x.Disabled)
x.Label.GetValueOrDefault(),
x.Emote.IsSpecified ? x.Emote.Value.Id.HasValue ? new Emote(x.Emote.Value.Id.Value, x.Emote.Value.Name, x.Emote.Value.Animated.GetValueOrDefault()) : new Emoji(x.Emote.Value.Name) : null,
x.CustomId.GetValueOrDefault(),
x.Url.GetValueOrDefault(),
x.Disabled.GetValueOrDefault())
).ToList()
)).ToList();
}


+ 6
- 6
src/Discord.Net.WebSocket/Entities/Messages/SocketMessage.cs View File

@@ -163,13 +163,13 @@ namespace Discord.WebSocket
if (model.Components.IsSpecified)
{
Components = model.Components.Value.Select(x => new ActionRowComponent(x.Components.Select(x =>
new ButtonComponent(
new ButtonComponent(
x.Style,
x.Label,
x.Emote.Id.HasValue ? new Emote(x.Emote.Id.Value, x.Emote.Name, x.Emote.Animated.GetValueOrDefault()) : new Emoji(x.Emote.Name),
x.CustomId,
x.Url,
x.Disabled)
x.Label.GetValueOrDefault(),
x.Emote.IsSpecified ? x.Emote.Value.Id.HasValue ? new Emote(x.Emote.Value.Id.Value, x.Emote.Value.Name, x.Emote.Value.Animated.GetValueOrDefault()) : new Emoji(x.Emote.Value.Name) : null,
x.CustomId.GetValueOrDefault(),
x.Url.GetValueOrDefault(),
x.Disabled.GetValueOrDefault())
).ToList()
)).ToList();
}


+ 10
- 10
src/Discord.Net/Discord.Net.nuspec View File

@@ -2,7 +2,7 @@
<package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
<metadata>
<id>Discord.Net.Labs</id>
<version>2.3.1$suffix$</version>
<version>2.3.2$suffix$</version>
<title>Discord.Net Labs</title>
<authors>Discord.Net Contributors</authors>
<owners>quinchs</owners>
@@ -14,23 +14,23 @@
<iconUrl>https://avatars.githubusercontent.com/u/84047264</iconUrl>
<dependencies>
<group targetFramework="net461">
<dependency id="Discord.Net.Labs.Core" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.Rest" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.WebSocket" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.Core" version="2.3.4$suffix$" />
<dependency id="Discord.Net.Labs.Rest" version="2.3.4$suffix$" />
<dependency id="Discord.Net.Labs.WebSocket" version="2.3.3$suffix$" />
<dependency id="Discord.Net.Labs.Commands" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.Webhook" version="2.3.1$suffix$" />
</group>
<group targetFramework="netstandard2.0">
<dependency id="Discord.Net.Labs.Core" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.Rest" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.WebSocket" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.Core" version="2.3.4$suffix$" />
<dependency id="Discord.Net.Labs.Rest" version="2.3.4$suffix$" />
<dependency id="Discord.Net.Labs.WebSocket" version="2.3.3$suffix$" />
<dependency id="Discord.Net.Labs.Commands" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.Webhook" version="2.3.1$suffix$" />
</group>
<group targetFramework="netstandard2.1">
<dependency id="Discord.Net.Labs.Core" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.Rest" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.WebSocket" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.Core" version="2.3.4$suffix$" />
<dependency id="Discord.Net.Labs.Rest" version="2.3.4$suffix$" />
<dependency id="Discord.Net.Labs.WebSocket" version="2.3.3$suffix$" />
<dependency id="Discord.Net.Labs.Commands" version="2.3.1$suffix$" />
<dependency id="Discord.Net.Labs.Webhook" version="2.3.1$suffix$" />
</group>


Loading…
Cancel
Save