From ce2b5da6dea1f8fe5a32371ff01569d5ed607871 Mon Sep 17 00:00:00 2001 From: RogueException Date: Sat, 1 Apr 2017 11:38:37 -0300 Subject: [PATCH] LogManager should never leak exceptions --- src/Discord.Net.Core/Logging/LogManager.cs | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/Discord.Net.Core/Logging/LogManager.cs b/src/Discord.Net.Core/Logging/LogManager.cs index 21f956b99..6f87d1229 100644 --- a/src/Discord.Net.Core/Logging/LogManager.cs +++ b/src/Discord.Net.Core/Logging/LogManager.cs @@ -19,19 +19,31 @@ namespace Discord.Logging public async Task LogAsync(LogSeverity severity, string source, Exception ex) { - if (severity <= Level) - await _messageEvent.InvokeAsync(new LogMessage(severity, source, null, ex)).ConfigureAwait(false); + try + { + if (severity <= Level) + await _messageEvent.InvokeAsync(new LogMessage(severity, source, null, ex)).ConfigureAwait(false); + } + catch { } } public async Task LogAsync(LogSeverity severity, string source, string message, Exception ex = null) { - if (severity <= Level) + try + { + if (severity <= Level) await _messageEvent.InvokeAsync(new LogMessage(severity, source, message, ex)).ConfigureAwait(false); + } + catch { } } #if NETSTANDARD1_3 public async Task LogAsync(LogSeverity severity, string source, FormattableString message, Exception ex = null) { - if (severity <= Level) - await _messageEvent.InvokeAsync(new LogMessage(severity, source, message.ToString(), ex)).ConfigureAwait(false); + try + { + if (severity <= Level) + await _messageEvent.InvokeAsync(new LogMessage(severity, source, message.ToString(), ex)).ConfigureAwait(false); + } + catch { } } #endif