Browse Source

added missing nullchecks

pull/2347/head
Misha133 3 years ago
parent
commit
b8a247885e
9 changed files with 18 additions and 15 deletions
  1. +1
    -1
      src/Discord.Net.Core/Entities/Messages/Embed.cs
  2. +2
    -2
      src/Discord.Net.Core/Entities/Messages/EmbedAuthor.cs
  3. +3
    -0
      src/Discord.Net.Core/Entities/Messages/EmbedBuilder.cs
  4. +2
    -2
      src/Discord.Net.Core/Entities/Messages/EmbedField.cs
  5. +2
    -2
      src/Discord.Net.Core/Entities/Messages/EmbedFooter.cs
  6. +2
    -2
      src/Discord.Net.Core/Entities/Messages/EmbedImage.cs
  7. +2
    -2
      src/Discord.Net.Core/Entities/Messages/EmbedProvider.cs
  8. +2
    -2
      src/Discord.Net.Core/Entities/Messages/EmbedThumbnail.cs
  9. +2
    -2
      src/Discord.Net.Core/Entities/Messages/EmbedVideo.cs

+ 1
- 1
src/Discord.Net.Core/Entities/Messages/Embed.cs View File

@@ -119,7 +119,7 @@ namespace Discord
/// <param name="embed">The <see cref="Embed"/> to compare with the current <see cref="Embed"/></param>
/// <returns></returns>
public bool Equals(Embed embed)
=> GetHashCode() == embed.GetHashCode();
=> GetHashCode() == embed?.GetHashCode();

/// <inheritdoc />
public override int GetHashCode()


+ 2
- 2
src/Discord.Net.Core/Entities/Messages/EmbedAuthor.cs View File

@@ -66,8 +66,8 @@ namespace Discord
/// </summary>
/// <param name="embedAuthor">The <see cref="EmbedAuthor"/> to compare with the current <see cref="EmbedAuthor"/></param>
/// <returns></returns>
public bool Equals(EmbedAuthor embedAuthor)
=> GetHashCode() == embedAuthor.GetHashCode();
public bool Equals(EmbedAuthor? embedAuthor)
=> GetHashCode() == embedAuthor?.GetHashCode();

/// <inheritdoc />
public override int GetHashCode()


+ 3
- 0
src/Discord.Net.Core/Entities/Messages/EmbedBuilder.cs View File

@@ -507,6 +507,9 @@ namespace Discord
/// <returns></returns>
public bool Equals(EmbedBuilder embedBuilder)
{
if (embedBuilder is null)
return false;

if (Fields.Count != embedBuilder.Fields.Count)
return false;



+ 2
- 2
src/Discord.Net.Core/Entities/Messages/EmbedField.cs View File

@@ -61,8 +61,8 @@ namespace Discord
/// </summary>
/// <param name="embedField"></param>
/// <returns></returns>
public bool Equals(EmbedField embedField)
=> GetHashCode() == embedField.GetHashCode();
public bool Equals(EmbedField? embedField)
=> GetHashCode() == embedField?.GetHashCode();

/// <inheritdoc />
public override int GetHashCode()


+ 2
- 2
src/Discord.Net.Core/Entities/Messages/EmbedFooter.cs View File

@@ -68,8 +68,8 @@ namespace Discord
/// </summary>
/// <param name="embedFooter">The <see cref="EmbedFooter"/> to compare with the current <see cref="EmbedFooter"/></param>
/// <returns></returns>
public bool Equals(EmbedFooter embedFooter)
=> GetHashCode() == embedFooter.GetHashCode();
public bool Equals(EmbedFooter? embedFooter)
=> GetHashCode() == embedFooter?.GetHashCode();

/// <inheritdoc />
public override int GetHashCode()


+ 2
- 2
src/Discord.Net.Core/Entities/Messages/EmbedImage.cs View File

@@ -78,8 +78,8 @@ namespace Discord
/// </summary>
/// <param name="embedImage">The <see cref="EmbedImage"/> to compare with the current <see cref="EmbedImage"/></param>
/// <returns></returns>
public bool Equals(EmbedImage embedImage)
=> GetHashCode() == embedImage.GetHashCode();
public bool Equals(EmbedImage? embedImage)
=> GetHashCode() == embedImage?.GetHashCode();

/// <inheritdoc />
public override int GetHashCode()


+ 2
- 2
src/Discord.Net.Core/Entities/Messages/EmbedProvider.cs View File

@@ -60,8 +60,8 @@ namespace Discord
/// </summary>
/// <param name="embedProvider">The <see cref="EmbedProvider"/> to compare with the current <see cref="EmbedProvider"/></param>
/// <returns></returns>
public bool Equals(EmbedProvider embedProvider)
=> GetHashCode() == embedProvider.GetHashCode();
public bool Equals(EmbedProvider? embedProvider)
=> GetHashCode() == embedProvider?.GetHashCode();

/// <inheritdoc />
public override int GetHashCode()


+ 2
- 2
src/Discord.Net.Core/Entities/Messages/EmbedThumbnail.cs View File

@@ -78,8 +78,8 @@ namespace Discord
/// </summary>
/// <param name="embedThumbnail">The <see cref="EmbedThumbnail"/> to compare with the current <see cref="EmbedThumbnail"/></param>
/// <returns></returns>
public bool Equals(EmbedThumbnail embedThumbnail)
=> GetHashCode() == embedThumbnail.GetHashCode();
public bool Equals(EmbedThumbnail? embedThumbnail)
=> GetHashCode() == embedThumbnail?.GetHashCode();

/// <inheritdoc />
public override int GetHashCode()


+ 2
- 2
src/Discord.Net.Core/Entities/Messages/EmbedVideo.cs View File

@@ -72,8 +72,8 @@ namespace Discord
/// </summary>
/// <param name="embedVideo">The <see cref="EmbedVideo"/> to compare with the current <see cref="EmbedVideo"/></param>
/// <returns></returns>
public bool Equals(EmbedVideo embedVideo)
=> GetHashCode() == embedVideo.GetHashCode();
public bool Equals(EmbedVideo? embedVideo)
=> GetHashCode() == embedVideo?.GetHashCode();

/// <inheritdoc />
public override int GetHashCode()


Loading…
Cancel
Save