Browse Source

Stop crashing on reconnect

tags/docs-0.9
Brandon Smith 9 years ago
parent
commit
a7fa1e48d6
2 changed files with 14 additions and 16 deletions
  1. +10
    -13
      src/Discord.Net/DiscordClient.cs
  2. +4
    -3
      src/Discord.Net/DiscordWebSocket.cs

+ 10
- 13
src/Discord.Net/DiscordClient.cs View File

@@ -66,7 +66,7 @@ namespace Discord
/// <summary> Initializes a new instance of the DiscordClient class. </summary> /// <summary> Initializes a new instance of the DiscordClient class. </summary>
public DiscordClient(DiscordClientConfig config = null) public DiscordClient(DiscordClientConfig config = null)
{ {
_blockEvent = new ManualResetEventSlim(false);
_blockEvent = new ManualResetEventSlim(true);


_config = config ?? new DiscordClientConfig(); _config = config ?? new DiscordClientConfig();
_rand = new Random(); _rand = new Random();
@@ -278,7 +278,7 @@ namespace Discord


_webSocket = new DiscordWebSocket(_config.WebSocketInterval); _webSocket = new DiscordWebSocket(_config.WebSocketInterval);
_webSocket.Connected += (s, e) => RaiseConnected(); _webSocket.Connected += (s, e) => RaiseConnected();
_webSocket.Disconnected += async (s, e) =>
_webSocket.Disconnected += async (s, e) =>
{ {
//Reconnect if we didn't cause the disconnect //Reconnect if we didn't cause the disconnect
RaiseDisconnected(); RaiseDisconnected();
@@ -869,13 +869,6 @@ namespace Discord
{ {
await _webSocket.DisconnectAsync(); await _webSocket.DisconnectAsync();


//Do not clean up until all tasks have ended
_webSocket.Dispose();
_webSocket = null;
_blockEvent.Dispose();
_blockEvent = null;
_tasks = null;

//Clear send queue //Clear send queue
Message ignored; Message ignored;
while (_pendingMessages.TryDequeue(out ignored)) { } while (_pendingMessages.TryDequeue(out ignored)) { }
@@ -885,7 +878,10 @@ namespace Discord
_roles.Clear(); _roles.Clear();
_servers.Clear(); _servers.Clear();
_users.Clear(); _users.Clear();
});

_blockEvent.Set();
_tasks = null;
}).Unwrap();
_isConnected = true; _isConnected = true;
} }
else else
@@ -895,10 +891,11 @@ namespace Discord
/// <summary> Disconnects from the Discord server, canceling any pending requests. </summary> /// <summary> Disconnects from the Discord server, canceling any pending requests. </summary>
public async Task Disconnect() public async Task Disconnect()
{ {
_blockEvent.Set();

if (_tasks != null) if (_tasks != null)
await _tasks;
{
try { _disconnectToken.Cancel(); } catch (NullReferenceException) { }
try { await _tasks; } catch (NullReferenceException) { }
}
} }


//Servers //Servers


+ 4
- 3
src/Discord.Net/DiscordWebSocket.cs View File

@@ -58,7 +58,6 @@ namespace Discord
_webSocket = null; _webSocket = null;
_disconnectToken.Dispose(); _disconnectToken.Dispose();
_disconnectToken = null; _disconnectToken = null;
_tasks = null;


//Clear send queue //Clear send queue
byte[] ignored; byte[] ignored;
@@ -69,6 +68,8 @@ namespace Discord
_isConnected = false; _isConnected = false;
RaiseDisconnected(); RaiseDisconnected();
} }

_tasks = null;
}); });


if (autoLogin) if (autoLogin)
@@ -109,8 +110,8 @@ namespace Discord
{ {
if (_tasks != null) if (_tasks != null)
{ {
_disconnectToken.Cancel();
await _tasks;
try { _disconnectToken.Cancel(); } catch (NullReferenceException) { }
try { await _tasks; } catch (NullReferenceException) { }
} }
} }




Loading…
Cancel
Save