From 6bdc0c09cafb9f542db2745f85c56a36b1471f4e Mon Sep 17 00:00:00 2001 From: RogueException Date: Sat, 8 Oct 2016 18:44:59 -0300 Subject: [PATCH] Cleaned up TODOs --- src/Discord.Net.Core/IDiscordClient.cs | 2 -- src/Discord.Net.Core/Net/Queue/Requests/IQueuedRequest.cs | 2 -- src/Discord.Net.Core/Net/Rest/IRestClient.cs | 1 - src/Discord.Net.Rest/Entities/Channels/ChannelHelper.cs | 4 +++- .../Entities/Channels/RestGuildChannel.cs | 8 ++++---- .../Entities/Channels/RestVirtualMessageChannel.cs | 1 - .../Entities/Channels/SocketGuildChannel.cs | 4 ++-- 7 files changed, 9 insertions(+), 13 deletions(-) diff --git a/src/Discord.Net.Core/IDiscordClient.cs b/src/Discord.Net.Core/IDiscordClient.cs index 92dc6b7ba..4131b1796 100644 --- a/src/Discord.Net.Core/IDiscordClient.cs +++ b/src/Discord.Net.Core/IDiscordClient.cs @@ -6,8 +6,6 @@ using System.Threading.Tasks; namespace Discord { - //TODO: Add docstrings - //TODO: Docstrings should explain when REST requests are sent and how many public interface IDiscordClient : IDisposable { ConnectionState ConnectionState { get; } diff --git a/src/Discord.Net.Core/Net/Queue/Requests/IQueuedRequest.cs b/src/Discord.Net.Core/Net/Queue/Requests/IQueuedRequest.cs index cacc58bb7..492b3a77d 100644 --- a/src/Discord.Net.Core/Net/Queue/Requests/IQueuedRequest.cs +++ b/src/Discord.Net.Core/Net/Queue/Requests/IQueuedRequest.cs @@ -4,8 +4,6 @@ using System.Threading.Tasks; namespace Discord.Net.Queue { - //TODO: Allow user-supplied canceltoken - //TODO: Allow specifying timeout via DiscordApiClient public interface IQueuedRequest { CancellationToken CancelToken { get; } diff --git a/src/Discord.Net.Core/Net/Rest/IRestClient.cs b/src/Discord.Net.Core/Net/Rest/IRestClient.cs index 7f90060b6..aa53bea5b 100644 --- a/src/Discord.Net.Core/Net/Rest/IRestClient.cs +++ b/src/Discord.Net.Core/Net/Rest/IRestClient.cs @@ -5,7 +5,6 @@ using System.Threading.Tasks; namespace Discord.Net.Rest { - //TODO: Add docstrings public interface IRestClient { void SetHeader(string key, string value); diff --git a/src/Discord.Net.Rest/Entities/Channels/ChannelHelper.cs b/src/Discord.Net.Rest/Entities/Channels/ChannelHelper.cs index b8843802a..ccd24e5dd 100644 --- a/src/Discord.Net.Rest/Entities/Channels/ChannelHelper.cs +++ b/src/Discord.Net.Rest/Entities/Channels/ChannelHelper.cs @@ -71,7 +71,9 @@ namespace Discord.Rest public static IAsyncEnumerable> GetMessagesAsync(IChannel channel, BaseDiscordClient client, ulong? fromMessageId, Direction dir, int limit, IGuild guild, RequestOptions options) { - //TODO: Test this with Around direction + if (dir == Direction.Around) + throw new NotImplementedException(); //TODO: Impl + return new PagedAsyncEnumerable( DiscordConfig.MaxMessagesPerBatch, async (info, ct) => diff --git a/src/Discord.Net.Rest/Entities/Channels/RestGuildChannel.cs b/src/Discord.Net.Rest/Entities/Channels/RestGuildChannel.cs index 63e2ec509..2607a2d96 100644 --- a/src/Discord.Net.Rest/Entities/Channels/RestGuildChannel.cs +++ b/src/Discord.Net.Rest/Entities/Channels/RestGuildChannel.cs @@ -144,14 +144,14 @@ namespace Discord.Rest => await RemovePermissionOverwriteAsync(user, options).ConfigureAwait(false); IAsyncEnumerable> IGuildChannel.GetUsersAsync(CacheMode mode, RequestOptions options) - => AsyncEnumerable.Empty>(); //Overriden //Overriden in Text/Voice //TODO: Does this actually override? + => AsyncEnumerable.Empty>(); //Overriden //Overriden in Text/Voice Task IGuildChannel.GetUserAsync(ulong id, CacheMode mode, RequestOptions options) - => Task.FromResult(null); //Overriden in Text/Voice //TODO: Does this actually override? + => Task.FromResult(null); //Overriden in Text/Voice //IChannel IAsyncEnumerable> IChannel.GetUsersAsync(CacheMode mode, RequestOptions options) - => AsyncEnumerable.Empty>(); //Overriden in Text/Voice //TODO: Does this actually override? + => AsyncEnumerable.Empty>(); //Overriden in Text/Voice Task IChannel.GetUserAsync(ulong id, CacheMode mode, RequestOptions options) - => Task.FromResult(null); //Overriden in Text/Voice //TODO: Does this actually override? + => Task.FromResult(null); //Overriden in Text/Voice } } diff --git a/src/Discord.Net.Rest/Entities/Channels/RestVirtualMessageChannel.cs b/src/Discord.Net.Rest/Entities/Channels/RestVirtualMessageChannel.cs index d9fcfb358..97a0a93e6 100644 --- a/src/Discord.Net.Rest/Entities/Channels/RestVirtualMessageChannel.cs +++ b/src/Discord.Net.Rest/Entities/Channels/RestVirtualMessageChannel.cs @@ -7,7 +7,6 @@ using System.Threading.Tasks; namespace Discord.Rest { - //TODO: Review this class [DebuggerDisplay(@"{DebuggerDisplay,nq}")] internal class RestVirtualMessageChannel : RestEntity, IMessageChannel { diff --git a/src/Discord.Net.WebSocket/Entities/Channels/SocketGuildChannel.cs b/src/Discord.Net.WebSocket/Entities/Channels/SocketGuildChannel.cs index 36a372735..4253b3c51 100644 --- a/src/Discord.Net.WebSocket/Entities/Channels/SocketGuildChannel.cs +++ b/src/Discord.Net.WebSocket/Entities/Channels/SocketGuildChannel.cs @@ -153,8 +153,8 @@ namespace Discord.WebSocket //IChannel IAsyncEnumerable> IChannel.GetUsersAsync(CacheMode mode, RequestOptions options) - => ImmutableArray.Create>(Users).ToAsyncEnumerable(); //Overriden in Text/Voice //TODO: Does this actually override? + => ImmutableArray.Create>(Users).ToAsyncEnumerable(); //Overriden in Text/Voice Task IChannel.GetUserAsync(ulong id, CacheMode mode, RequestOptions options) - => Task.FromResult(GetUser(id)); //Overriden in Text/Voice //TODO: Does this actually override? + => Task.FromResult(GetUser(id)); //Overriden in Text/Voice } }