From 57cf5fe2b9c86326a0d84b1d163b24256a1d4c36 Mon Sep 17 00:00:00 2001 From: Joe4evr Date: Mon, 20 Apr 2020 16:04:36 +0200 Subject: [PATCH] Fallback on the default value on a failed read --- src/Discord.Net.Commands/Info/ParameterInfo.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Discord.Net.Commands/Info/ParameterInfo.cs b/src/Discord.Net.Commands/Info/ParameterInfo.cs index b435b301a..7090ff59d 100644 --- a/src/Discord.Net.Commands/Info/ParameterInfo.cs +++ b/src/Discord.Net.Commands/Info/ParameterInfo.cs @@ -90,7 +90,10 @@ namespace Discord.Commands public async Task ParseAsync(ICommandContext context, string input, IServiceProvider services = null) { services = services ?? EmptyServiceProvider.Instance; - return await _reader.ReadAsync(context, input, services).ConfigureAwait(false); + var readerResult = await _reader.ReadAsync(context, input, services).ConfigureAwait(false); + return (!readerResult.IsSuccess && IsOptional) + ? TypeReaderResult.FromSuccess(DefaultValue) + : readerResult; } public override string ToString() => Name;