From 492cd35fe3ad3b4accd42a85b57d6775325ead7e Mon Sep 17 00:00:00 2001 From: Finite Reality Date: Fri, 5 Aug 2016 01:13:42 +0100 Subject: [PATCH] Remove IEquatable implementation for IRole After a discussion, ends up this was a design choice. Maybe we can get ContainsId to stay? --- src/Discord.Net/Entities/Roles/IRole.cs | 2 +- src/Discord.Net/Rest/Entities/Roles/Role.cs | 19 ------------------- 2 files changed, 1 insertion(+), 20 deletions(-) diff --git a/src/Discord.Net/Entities/Roles/IRole.cs b/src/Discord.Net/Entities/Roles/IRole.cs index f34f3f69c..29975be46 100644 --- a/src/Discord.Net/Entities/Roles/IRole.cs +++ b/src/Discord.Net/Entities/Roles/IRole.cs @@ -5,7 +5,7 @@ using Discord.API.Rest; namespace Discord { - public interface IRole : IDeletable, ISnowflakeEntity, IEquatable + public interface IRole : IDeletable, ISnowflakeEntity { /// Gets the color given to users of this role. Color Color { get; } diff --git a/src/Discord.Net/Rest/Entities/Roles/Role.cs b/src/Discord.Net/Rest/Entities/Roles/Role.cs index d96525b4a..cbcceb0cf 100644 --- a/src/Discord.Net/Rest/Entities/Roles/Role.cs +++ b/src/Discord.Net/Rest/Entities/Roles/Role.cs @@ -57,25 +57,6 @@ namespace Discord await Discord.ApiClient.DeleteGuildRoleAsync(Guild.Id, Id).ConfigureAwait(false); } - public override bool Equals(object other) - { - if (other == null) return false; - Role otherAsRole = other as Role; - if (otherAsRole == null) return false; - else return Equals(otherAsRole); - } - - public bool Equals(IRole other) - { - if (other == null) return false; - else return (Id.Equals(other.Id)); - } - - public override int GetHashCode() - { - return Id.GetHashCode(); - } - public Role Clone() => MemberwiseClone() as Role; public override string ToString() => Name;