From 479361bbea4f7baebbb55ceb211ce9f02368b91e Mon Sep 17 00:00:00 2001 From: Mark Gross Date: Tue, 29 Aug 2017 16:38:34 -0700 Subject: [PATCH] Condense redundant AddField overloads in EmbedBuilder (#790) * Remove extra AddField overload in EmbedBuilder * Remove AddInlineField() --- .../Entities/Messages/EmbedBuilder.cs | 25 +++---------------- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/src/Discord.Net.Rest/Entities/Messages/EmbedBuilder.cs b/src/Discord.Net.Rest/Entities/Messages/EmbedBuilder.cs index 7a111d34b..f5663cea3 100644 --- a/src/Discord.Net.Rest/Entities/Messages/EmbedBuilder.cs +++ b/src/Discord.Net.Rest/Entities/Messages/EmbedBuilder.cs @@ -171,24 +171,16 @@ namespace Discord return this; } - public EmbedBuilder AddField(string name, object value) + public EmbedBuilder AddField(string name, object value, bool inline = false) { var field = new EmbedFieldBuilder() - .WithIsInline(false) - .WithName(name) - .WithValue(value); - AddField(field); - return this; - } - public EmbedBuilder AddInlineField(string name, object value) - { - var field = new EmbedFieldBuilder() - .WithIsInline(true) + .WithIsInline(inline) .WithName(name) .WithValue(value); AddField(field); return this; } + public EmbedBuilder AddField(EmbedFieldBuilder field) { if (Fields.Count >= MaxFieldCount) @@ -206,17 +198,6 @@ namespace Discord this.AddField(field); return this; } - public EmbedBuilder AddField(string title, string text, bool inline = false) - { - var field = new EmbedFieldBuilder - { - Name = title, - Value = text, - IsInline = inline - }; - _fields.Add(field); - return this; - } public Embed Build() {