Browse Source

Fix a bug in EmbedBuilder.Length when there is an EmbedField with no Value (#2345)

* Update EmbedBuilder.cs

Fixes a bug where 'EmbedBuilder.Length' will throw an exception of type 'System.NullReferenceException' when a field doesn't have a value.

* Update EmbedBuilder.cs

Fixed an incorrect assuption that `Value` was a `string?`

* Update EmbedBuilder.cs

Fixed one more null check

* Update EmbedBuilder.cs

Co-authored-by: Quin Lynch <49576606+quinchs@users.noreply.github.com>
tags/3.8.1
Proddy GitHub 2 years ago
parent
commit
2b86a79f70
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
  1. +1
    -1
      src/Discord.Net.Core/Entities/Messages/EmbedBuilder.cs

+ 1
- 1
src/Discord.Net.Core/Entities/Messages/EmbedBuilder.cs View File

@@ -150,7 +150,7 @@ namespace Discord
int authorLength = Author?.Name?.Length ?? 0;
int descriptionLength = Description?.Length ?? 0;
int footerLength = Footer?.Text?.Length ?? 0;
int fieldSum = Fields.Sum(f => f.Name.Length + f.Value.ToString().Length);
int fieldSum = Fields.Sum(f => f.Name.Length + (f.Value?.ToString()?.Length ?? 0));

return titleLength + authorLength + descriptionLength + footerLength + fieldSum;
}


Loading…
Cancel
Save