From 19e2528affe6084cdd0459e23ae572083b7064d7 Mon Sep 17 00:00:00 2001 From: RogueException Date: Mon, 15 Feb 2016 19:27:54 -0400 Subject: [PATCH] Removed redundant casts in MessageQueue and improved error logging --- src/Discord.Net/MessageQueue.cs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/Discord.Net/MessageQueue.cs b/src/Discord.Net/MessageQueue.cs index dc3d27327..b5de885b0 100644 --- a/src/Discord.Net/MessageQueue.cs +++ b/src/Discord.Net/MessageQueue.cs @@ -103,7 +103,7 @@ namespace Discord.Net } private Task RunSendQueue(CancellationToken cancelToken) { - return Task.Run((Func)(async () => + return Task.Run(async () => { try { @@ -134,7 +134,7 @@ namespace Discord.Net catch (Exception ex) { msg.State = MessageState.Failed; - _logger.Error("Failed to send message", ex); + _logger.Error($"Failed to send message to {msg.Channel.Path}", ex); } } } @@ -142,11 +142,11 @@ namespace Discord.Net } } catch (OperationCanceledException) { } - })); + }); } private Task RunEditQueue(CancellationToken cancelToken) { - return Task.Run((Func)(async () => + return Task.Run(async () => { try { @@ -168,7 +168,7 @@ namespace Discord.Net }; await _rest.Send(request).ConfigureAwait(false); } - catch (Exception ex) { _logger.Error("Failed to edit message", ex); } + catch (Exception ex) { _logger.Error($"Failed to edit message {edit.Message.Path}", ex); } } } } @@ -176,11 +176,11 @@ namespace Discord.Net } } catch (OperationCanceledException) { } - })); + }); } private Task RunDeleteQueue(CancellationToken cancelToken) { - return Task.Run((Func)(async () => + return Task.Run(async () => { try { @@ -200,7 +200,7 @@ namespace Discord.Net await _rest.Send(request).ConfigureAwait(false); } catch (HttpException ex) when (ex.StatusCode == HttpStatusCode.NotFound) { } //Ignore - catch (Exception ex) { _logger.Error("Failed to delete message", ex); } + catch (Exception ex) { _logger.Error($"Failed to delete message {msg.Path}", ex); } } } } @@ -209,7 +209,7 @@ namespace Discord.Net } } catch (OperationCanceledException) { } - })); + }); } private void IncrementCount()