From 196cce05afc0a784e7f40be0cfb0f7281a0ac9f7 Mon Sep 17 00:00:00 2001 From: FiniteReality Date: Fri, 18 Nov 2016 09:24:31 +0000 Subject: [PATCH] Clean up attribute checking and extraneous casts This probably isn't all of them. This is what I get for copy+pasting code. --- src/Discord.Net.Commands/Utilities/ModuleClassBuilder.cs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Discord.Net.Commands/Utilities/ModuleClassBuilder.cs b/src/Discord.Net.Commands/Utilities/ModuleClassBuilder.cs index 2280d9246..85cd9a664 100644 --- a/src/Discord.Net.Commands/Utilities/ModuleClassBuilder.cs +++ b/src/Discord.Net.Commands/Utilities/ModuleClassBuilder.cs @@ -91,8 +91,9 @@ namespace Discord.Commands builder.AddAliases((attribute as AliasAttribute).Aliases); else if (attribute is GroupAttribute) { - builder.Name = builder.Name ?? (attribute as GroupAttribute).Prefix; - builder.AddAliases((attribute as GroupAttribute).Prefix); + var groupAttr = attribute as GroupAttribute; + builder.Name = builder.Name ?? groupAttr.Prefix; + builder.AddAliases(groupAttr.Prefix); } else if (attribute is PreconditionAttribute) builder.AddPrecondition(attribute as PreconditionAttribute); @@ -132,8 +133,6 @@ namespace Discord.Commands builder.Remarks = (attribute as RemarksAttribute).Text; else if (attribute is AliasAttribute) builder.AddAliases((attribute as AliasAttribute).Aliases); - else if (attribute is GroupAttribute) - builder.AddAliases((attribute as GroupAttribute).Prefix); else if (attribute is PreconditionAttribute) builder.AddPrecondition(attribute as PreconditionAttribute); }