diff --git a/src/Discord.Net.Core/Entities/Users/IUser.cs b/src/Discord.Net.Core/Entities/Users/IUser.cs
index 45d8862f1..e3f270f6f 100644
--- a/src/Discord.Net.Core/Entities/Users/IUser.cs
+++ b/src/Discord.Net.Core/Entities/Users/IUser.cs
@@ -20,8 +20,6 @@ namespace Discord
string Username { get; }
/// Returns a private message channel to this user, creating one if it does not already exist.
- Task GetDMChannelAsync(CacheMode mode = CacheMode.AllowDownload, RequestOptions options = null);
- /// Returns a private message channel to this user, creating one if it does not already exist.
- Task CreateDMChannelAsync(RequestOptions options = null);
+ Task GetOrCreateDMChannelAsync(RequestOptions options = null);
}
}
diff --git a/src/Discord.Net.Rest/Entities/Users/RestUser.cs b/src/Discord.Net.Rest/Entities/Users/RestUser.cs
index cded876c8..d8ade3a6b 100644
--- a/src/Discord.Net.Rest/Entities/Users/RestUser.cs
+++ b/src/Discord.Net.Rest/Entities/Users/RestUser.cs
@@ -54,7 +54,7 @@ namespace Discord.Rest
Update(model);
}
- public Task CreateDMChannelAsync(RequestOptions options = null)
+ public Task GetOrCreateDMChannelAsync(RequestOptions options = null)
=> UserHelper.CreateDMChannelAsync(this, Discord, options);
public string GetAvatarUrl(ImageFormat format = ImageFormat.Auto, ushort size = 128)
@@ -64,9 +64,7 @@ namespace Discord.Rest
private string DebuggerDisplay => $"{Username}#{Discriminator} ({Id}{(IsBot ? ", Bot" : "")})";
//IUser
- Task IUser.GetDMChannelAsync(CacheMode mode, RequestOptions options)
- => Task.FromResult(null);
- async Task IUser.CreateDMChannelAsync(RequestOptions options)
- => await CreateDMChannelAsync(options).ConfigureAwait(false);
+ async Task IUser.GetOrCreateDMChannelAsync(RequestOptions options)
+ => await GetOrCreateDMChannelAsync(options);
}
}
diff --git a/src/Discord.Net.Rpc/Entities/Users/RpcUser.cs b/src/Discord.Net.Rpc/Entities/Users/RpcUser.cs
index 7ed11e57d..c6b0b2fd8 100644
--- a/src/Discord.Net.Rpc/Entities/Users/RpcUser.cs
+++ b/src/Discord.Net.Rpc/Entities/Users/RpcUser.cs
@@ -49,7 +49,7 @@ namespace Discord.Rpc
Username = model.Username.Value;
}
- public Task CreateDMChannelAsync(RequestOptions options = null)
+ public Task GetOrCreateDMChannelAsync(RequestOptions options = null)
=> UserHelper.CreateDMChannelAsync(this, Discord, options);
public string GetAvatarUrl(ImageFormat format = ImageFormat.Auto, ushort size = 128)
@@ -59,9 +59,7 @@ namespace Discord.Rpc
private string DebuggerDisplay => $"{Username}#{Discriminator} ({Id}{(IsBot ? ", Bot" : "")})";
//IUser
- Task IUser.GetDMChannelAsync(CacheMode mode, RequestOptions options)
- => Task.FromResult(null);
- async Task IUser.CreateDMChannelAsync(RequestOptions options)
- => await CreateDMChannelAsync(options).ConfigureAwait(false);
+ async Task IUser.GetOrCreateDMChannelAsync(RequestOptions options)
+ => await GetOrCreateDMChannelAsync(options);
}
}
diff --git a/src/Discord.Net.WebSocket/DiscordSocketClient.cs b/src/Discord.Net.WebSocket/DiscordSocketClient.cs
index 4476b78c4..d42df7b55 100644
--- a/src/Discord.Net.WebSocket/DiscordSocketClient.cs
+++ b/src/Discord.Net.WebSocket/DiscordSocketClient.cs
@@ -1634,6 +1634,9 @@ namespace Discord.WebSocket
{
var channel = SocketChannel.CreatePrivate(this, state, model);
state.AddChannel(channel as SocketChannel);
+ if (channel is SocketDMChannel dm)
+ dm.Recipient.GlobalUser.DMChannel = dm;
+
return channel;
}
internal ISocketPrivateChannel RemovePrivateChannel(ulong id)
@@ -1641,6 +1644,9 @@ namespace Discord.WebSocket
var channel = State.RemoveChannel(id) as ISocketPrivateChannel;
if (channel != null)
{
+ if (channel is SocketDMChannel dmChannel)
+ dmChannel.Recipient.GlobalUser.DMChannel = null;
+
foreach (var recipient in channel.Recipients)
recipient.GlobalUser.RemoveRef(this);
}
diff --git a/src/Discord.Net.WebSocket/Entities/Users/SocketGlobalUser.cs b/src/Discord.Net.WebSocket/Entities/Users/SocketGlobalUser.cs
index 0cd5f749e..3117eb14c 100644
--- a/src/Discord.Net.WebSocket/Entities/Users/SocketGlobalUser.cs
+++ b/src/Discord.Net.WebSocket/Entities/Users/SocketGlobalUser.cs
@@ -1,4 +1,5 @@
using System.Diagnostics;
+using System.Linq;
using Model = Discord.API.User;
using PresenceModel = Discord.API.Presence;
@@ -51,6 +52,7 @@ namespace Discord.WebSocket
internal void Update(ClientState state, PresenceModel model)
{
Presence = SocketPresence.Create(model);
+ DMChannel = state.DMChannels.FirstOrDefault(x => x.Recipient.Id == Id);
}
internal new SocketGlobalUser Clone() => MemberwiseClone() as SocketGlobalUser;
diff --git a/src/Discord.Net.WebSocket/Entities/Users/SocketGuildUser.cs b/src/Discord.Net.WebSocket/Entities/Users/SocketGuildUser.cs
index b92559a40..05aa132a5 100644
--- a/src/Discord.Net.WebSocket/Entities/Users/SocketGuildUser.cs
+++ b/src/Discord.Net.WebSocket/Entities/Users/SocketGuildUser.cs
@@ -146,11 +146,7 @@ namespace Discord.WebSocket
IGuild IGuildUser.Guild => Guild;
ulong IGuildUser.GuildId => Guild.Id;
IReadOnlyCollection IGuildUser.RoleIds => _roleIds;
-
- //IUser
- Task IUser.GetDMChannelAsync(CacheMode mode, RequestOptions options)
- => Task.FromResult(GlobalUser.DMChannel);
-
+
//IVoiceState
IVoiceChannel IVoiceState.VoiceChannel => VoiceChannel;
}
diff --git a/src/Discord.Net.WebSocket/Entities/Users/SocketUser.cs b/src/Discord.Net.WebSocket/Entities/Users/SocketUser.cs
index 1b599bf7e..a0c78b93f 100644
--- a/src/Discord.Net.WebSocket/Entities/Users/SocketUser.cs
+++ b/src/Discord.Net.WebSocket/Entities/Users/SocketUser.cs
@@ -53,10 +53,10 @@ namespace Discord.WebSocket
hasChanges = true;
}
return hasChanges;
- }
+ }
- public Task CreateDMChannelAsync(RequestOptions options = null)
- => UserHelper.CreateDMChannelAsync(this, Discord, options);
+ public async Task GetOrCreateDMChannelAsync(RequestOptions options = null)
+ => GlobalUser.DMChannel ?? await UserHelper.CreateDMChannelAsync(this, Discord, options) as IDMChannel;
public string GetAvatarUrl(ImageFormat format = ImageFormat.Auto, ushort size = 128)
=> CDN.GetUserAvatarUrl(Id, AvatarId, size, format);
@@ -64,11 +64,5 @@ namespace Discord.WebSocket
public override string ToString() => $"{Username}#{Discriminator}";
private string DebuggerDisplay => $"{Username}#{Discriminator} ({Id}{(IsBot ? ", Bot" : "")})";
internal SocketUser Clone() => MemberwiseClone() as SocketUser;
-
- //IUser
- Task IUser.GetDMChannelAsync(CacheMode mode, RequestOptions options)
- => Task.FromResult(GlobalUser.DMChannel);
- async Task IUser.CreateDMChannelAsync(RequestOptions options)
- => await CreateDMChannelAsync(options).ConfigureAwait(false);
}
}