Browse Source

Remove unnecessary code and check for null

pull/1542/head
Paulo 5 years ago
parent
commit
0c9e1617df
2 changed files with 4 additions and 13 deletions
  1. +1
    -11
      src/Discord.Net.WebSocket/DiscordSocketClient.cs
  2. +3
    -2
      src/Discord.Net.WebSocket/Entities/Guilds/SocketGuild.cs

+ 1
- 11
src/Discord.Net.WebSocket/DiscordSocketClient.cs View File

@@ -1771,17 +1771,7 @@ namespace Discord.WebSocket
return guild;
}
internal SocketGuild RemoveGuild(ulong id)
{
var guild = State.RemoveGuild(id);
if (guild != null)
{
foreach (var _ in guild.Channels)
State.RemoveChannel(id);
foreach (var user in guild.Users)
user.GlobalUser.RemoveRef(this);
}
return guild;
}
=> State.RemoveGuild(id);

/// <exception cref="InvalidOperationException">Unexpected channel type is created.</exception>
internal ISocketPrivateChannel AddPrivateChannel(API.Channel model, ClientState state)


+ 3
- 2
src/Discord.Net.WebSocket/Entities/Guilds/SocketGuild.cs View File

@@ -809,13 +809,14 @@ namespace Discord.WebSocket
var members = Users;
var self = CurrentUser;
_members.Clear();
_members.TryAdd(self.Id, self);
if (self != null)
_members.TryAdd(self.Id, self);

DownloadedMemberCount = _members.Count;

foreach (var member in members)
{
if (member.Id != self.Id)
if (member.Id != self?.Id)
member.GlobalUser.RemoveRef(Discord);
}
}


Loading…
Cancel
Save