!337 fix coverity

Merge pull request !337 from wangjiming/feature

metadef

@@ -1 +1 @@
-Subproject commit 2f89122e1fa26b3633a8efa4bf0a0269bebf537e
+Subproject commit 84e7ab39b0daf7ca2b2f5549e3279647da7875e2

parser/caffe/caffe_parser.cc

@@ -203,11 +203,9 @@ const int32_t kAnchorIndexTwo = 2;
 const int32_t kAnchorIndexThree = 3;
 const int32_t kNumOne = 1;
 const size_t kTensorNum = 2;
-const int kMaxParseDepth = 5;
 const int32_t kMinLineWorldSize = 3;
 const int32_t kMaxIdentifier = 536870911; // 2^29 - 1
 const int32_t kBase = 10;
-const uint32_t kInteval = 2;
 const char *const kPython = "Python";
 const char *const kProposalLayer = "ProposalLayer";
 const char *const kDetectionOutput = "DetectionOutput";

parser/func_to_graph/func2graph.py

@@ -1,4 +1,4 @@
-#!/usr/bin/python3
+#!/usr/bin/env python3
 # -*- coding: utf-8 -*-
 #-------------------------------------------------------------------
 # Purpose:

parser/onnx/onnx_data_parser.h

@@ -42,7 +42,7 @@ class PARSER_FUNC_VISIBILITY OnnxDataParser : public OnnxOpParser {
 
   std::vector<int64_t> user_input_dims_v_;
 
-  bool is_subgraph_data_op_;
+  bool is_subgraph_data_op_ = false;
 };
 }  // namespace ge
 

parser/onnx/subgraph_adapter/subgraph_adapter_factory.h

@@ -55,7 +55,7 @@ public:
    */
   std::shared_ptr<SubgraphAdapter> CreateSubgraphAdapter(const std::string &op_type);
 
-
+  ~SubgraphAdapterFactory() = default;
 protected:
   /**
    * @brief SubgraphAdapter creation function

parser/tensorflow/tensorflow_frameworkop_parser.cc

@@ -75,9 +75,9 @@ Status ParseParams(const Message *op_src, FrameworkOpOperator *op) {
     op->TfOpDef(attr_v.s());
   } else {
     GE_CHK_BOOL_EXEC(type == "_Retval",
-                     GE_DELETE_NEW_SINGLE(pkg_node);
                      REPORT_INNER_ERROR("E19999", "In NodeDef:%s Attr:opdef is not exist, check invalid",
                                         pkg_node->name().c_str());
+                     GE_DELETE_NEW_SINGLE(pkg_node);
                      return PARAM_INVALID, "In NodeDef %s Attr opdef is not exist.", pkg_node->name().c_str());
   }
 

tests/ut/parser/testcase/onnx_parser_testcase/onnx_model/if.py

@@ -1,3 +1,10 @@
+#!/usr/bin/env python3
+# -*- coding: UTF-8 -*-
+#-------------------------------------------------------------------
+# Purpose:
+# Copyright 2021 Huawei Technologies Co., Ltd. All rights reserved.
+#-------------------------------------------------------------------
+
 # Given a bool scalar input cond.
 # return constant tensor x if cond is True, otherwise return constant tensor y.
 import numpy as np