From 069dac4ea8d67c9c4ad486e86b9a580c7e610110 Mon Sep 17 00:00:00 2001
From: isaacxr <xurui23@huawei.com>
Date: Thu, 23 Dec 2021 15:56:06 +0800
Subject: [PATCH] codecheck clean

---
 parser/caffe/caffe_parser.h                             | 1 +
 parser/common/acl_graph_parser_util.h                   | 2 +-
 parser/common/op_def/arg_op.cc                          | 5 -----
 parser/common/op_def/arg_op.h                           | 2 --
 parser/common/op_def/constant_op.cc                     | 5 -----
 parser/common/op_def/constant_op.h                      | 1 -
 parser/common/op_def/frameworkop_op.cc                  | 6 ------
 parser/common/op_def/frameworkop_op.h                   | 2 --
 parser/common/op_def/no_op_op.cc                        | 5 -----
 parser/common/op_def/no_op_op.h                         | 2 --
 parser/common/op_def/operator.h                         | 2 +-
 parser/common/op_def/ref_switch_op.cc                   | 5 -----
 parser/common/op_def/ref_switch_op.h                    | 2 --
 parser/common/op_def/shape_n_op.cc                      | 5 -----
 parser/common/op_def/shape_n_op.h                       | 2 --
 parser/common/op_def/var_is_initialized_op_op.cc        | 5 -----
 parser/common/op_def/var_is_initialized_op_op.h         | 1 -
 parser/common/op_def/variable_op.cc                     | 5 -----
 parser/common/op_def/variable_op.h                      | 2 --
 parser/onnx/subgraph_adapter/subgraph_adapter_factory.h | 1 +
 20 files changed, 4 insertions(+), 57 deletions(-)

diff --git a/parser/caffe/caffe_parser.h b/parser/caffe/caffe_parser.h
index 36b2a16..f645aaf 100644
--- a/parser/caffe/caffe_parser.h
+++ b/parser/caffe/caffe_parser.h
@@ -50,6 +50,7 @@ using std::set;
 using std::string;
 using std::unordered_map;
 using std::vector;
+using domi::Status;
 static std::map<std::vector<std::string>, std::vector<std::string>> params_share_map;
 
 class PARSER_FUNC_VISIBILITY CaffeModelParser : public domi::ModelParser {
diff --git a/parser/common/acl_graph_parser_util.h b/parser/common/acl_graph_parser_util.h
index c133915..abc65a6 100644
--- a/parser/common/acl_graph_parser_util.h
+++ b/parser/common/acl_graph_parser_util.h
@@ -157,7 +157,7 @@ bool ValidateStr(const std::string &filePath, const std::string &mode);
 std::string CurrentTimeInStr();
 
 template <typename T, typename... Args>
-static inline std::shared_ptr<T> MakeShared(Args &&... args) {
+inline std::shared_ptr<T> MakeShared(Args &&... args) {
   using T_nc = typename std::remove_const<T>::type;
   std::shared_ptr<T> ret(new (std::nothrow) T_nc(std::forward<Args>(args)...));
   return ret;
diff --git a/parser/common/op_def/arg_op.cc b/parser/common/op_def/arg_op.cc
index 7dda8b1..2eb0ff6 100644
--- a/parser/common/op_def/arg_op.cc
+++ b/parser/common/op_def/arg_op.cc
@@ -23,11 +23,6 @@ FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY ArgOpOperator::ArgOpOperator()
 
 ArgOpOperator::~ArgOpOperator() {}
 
-FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY ArgOpOperator &ArgOpOperator::Name(const std::string &name) {
-  (void)ParserOperator::Name(name);
-  return *this;
-}
-
 FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY ArgOpOperator &ArgOpOperator::Index(int64_t index) {
   Attr("index", static_cast<int64_t>(index));
 
diff --git a/parser/common/op_def/arg_op.h b/parser/common/op_def/arg_op.h
index ed0a2db..7258422 100644
--- a/parser/common/op_def/arg_op.h
+++ b/parser/common/op_def/arg_op.h
@@ -25,8 +25,6 @@ class ArgOpOperator : public ParserOperator {
 
   ~ArgOpOperator() override;
 
-  ArgOpOperator &Name(const std::string &name);
-
   ArgOpOperator &Index(int64_t index);
 
   int64_t GetIndex() const;
diff --git a/parser/common/op_def/constant_op.cc b/parser/common/op_def/constant_op.cc
index a9993f7..cca55c5 100644
--- a/parser/common/op_def/constant_op.cc
+++ b/parser/common/op_def/constant_op.cc
@@ -25,11 +25,6 @@ FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY ConstantOperator::ConstantOpera
 
 FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY ConstantOperator::~ConstantOperator() {}
 
-FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY ConstantOperator &ConstantOperator::Name(const std::string &name) {
-  ParserOperator::Name(name);
-  return *this;
-}
-
 FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY ConstantOperator &ConstantOperator::VectorAttr(
     std::string key, std::vector<int64_t> &value) {
   Attr(key, value);
diff --git a/parser/common/op_def/constant_op.h b/parser/common/op_def/constant_op.h
index 59d586b..e329ac1 100644
--- a/parser/common/op_def/constant_op.h
+++ b/parser/common/op_def/constant_op.h
@@ -26,7 +26,6 @@ class ConstantOperator : public ParserOperator {
   ConstantOperator();
   ~ConstantOperator() override;
 
-  ConstantOperator &Name(const std::string &name);
   ConstantOperator &VectorAttr(std::string key, std::vector<int64_t> &value);
 
   ConstantOperator &DType(ge::DataType t);
diff --git a/parser/common/op_def/frameworkop_op.cc b/parser/common/op_def/frameworkop_op.cc
index a762599..7810147 100644
--- a/parser/common/op_def/frameworkop_op.cc
+++ b/parser/common/op_def/frameworkop_op.cc
@@ -24,12 +24,6 @@ FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY FrameworkOpOperator::FrameworkO
 
 FrameworkOpOperator::~FrameworkOpOperator() {}
 
-FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY FrameworkOpOperator &FrameworkOpOperator::Name(
-    const std::string &name) {
-  ParserOperator::Name(name);
-  return *this;
-}
-
 FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY FrameworkOpOperator &FrameworkOpOperator::Index(int64_t index) {
   Attr(RETVAL_ATTR_NAME_INDEX, static_cast<int64_t>(index));
   return *this;
diff --git a/parser/common/op_def/frameworkop_op.h b/parser/common/op_def/frameworkop_op.h
index ad88c47..9a1a54c 100644
--- a/parser/common/op_def/frameworkop_op.h
+++ b/parser/common/op_def/frameworkop_op.h
@@ -26,8 +26,6 @@ class FrameworkOpOperator : public ParserOperator {
 
   ~FrameworkOpOperator() override;
 
-  FrameworkOpOperator &Name(const std::string &name);
-
   FrameworkOpOperator &OriginalType(const std::string &type);
 
   FrameworkOpOperator &NodeDefPkg(const std::string &nodedef_pkg);
diff --git a/parser/common/op_def/no_op_op.cc b/parser/common/op_def/no_op_op.cc
index 472242a..d9706ef 100644
--- a/parser/common/op_def/no_op_op.cc
+++ b/parser/common/op_def/no_op_op.cc
@@ -22,9 +22,4 @@ namespace ge {
 FMK_FUNC_HOST_VISIBILITY NoOpOperator::NoOpOperator() : ParserOperator("NoOp") {}
 
 FMK_FUNC_HOST_VISIBILITY NoOpOperator::~NoOpOperator() {}
-
-FMK_FUNC_HOST_VISIBILITY NoOpOperator &NoOpOperator::Name(const std::string &name) {
-  ParserOperator::Name(name);
-  return *this;
-}
 }  // namespace ge
diff --git a/parser/common/op_def/no_op_op.h b/parser/common/op_def/no_op_op.h
index f0fe684..f3bfea8 100644
--- a/parser/common/op_def/no_op_op.h
+++ b/parser/common/op_def/no_op_op.h
@@ -25,8 +25,6 @@ class NoOpOperator : public ParserOperator {
  public:
   NoOpOperator();
   ~NoOpOperator() override;
-
-  NoOpOperator &Name(const std::string &name);
 };
 }  // namespace ge
 
diff --git a/parser/common/op_def/operator.h b/parser/common/op_def/operator.h
index 1718659..a97580f 100644
--- a/parser/common/op_def/operator.h
+++ b/parser/common/op_def/operator.h
@@ -45,7 +45,7 @@ class FMK_FUNC_HOST_VISIBILITY ParserOperator {
   ParserOperator &AttrVector(std::string key, std::vector<int32_t> &value);
   ParserOperator &AttrVector(std::string key, std::vector<int64_t> &value);
 
-  ParserOperator &Name(const std::string &name);
+  virtual ParserOperator &Name(const std::string &name);
 
   ParserOperator &Type(const std::string &type);
 
diff --git a/parser/common/op_def/ref_switch_op.cc b/parser/common/op_def/ref_switch_op.cc
index 6a45868..a584cc5 100644
--- a/parser/common/op_def/ref_switch_op.cc
+++ b/parser/common/op_def/ref_switch_op.cc
@@ -22,11 +22,6 @@ FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY RefSwitchOperator::RefSwitchOpe
 
 FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY RefSwitchOperator::~RefSwitchOperator() {}
 
-FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY RefSwitchOperator &RefSwitchOperator::Name(const std::string &name) {
-  ParserOperator::Name(name);
-  return *this;
-}
-
 FMK_FUNC_HOST_VISIBILITY FMK_FUNC_DEV_VISIBILITY RefSwitchOperator &RefSwitchOperator::T(ge::DataType t) {
   Attr("T", (int64_t)t);
   return *this;
diff --git a/parser/common/op_def/ref_switch_op.h b/parser/common/op_def/ref_switch_op.h
index de17756..6a09bea 100644
--- a/parser/common/op_def/ref_switch_op.h
+++ b/parser/common/op_def/ref_switch_op.h
@@ -25,8 +25,6 @@ class RefSwitchOperator : public ParserOperator {
  public:
   RefSwitchOperator();
   ~RefSwitchOperator() override;
-
-  RefSwitchOperator &Name(const std::string &name);
   RefSwitchOperator &T(ge::DataType  t);
 };
 }  // namespace ge
diff --git a/parser/common/op_def/shape_n_op.cc b/parser/common/op_def/shape_n_op.cc
index 0e6e14f..7369345 100644
--- a/parser/common/op_def/shape_n_op.cc
+++ b/parser/common/op_def/shape_n_op.cc
@@ -24,11 +24,6 @@ FMK_FUNC_HOST_VISIBILITY ShapeNOperator::ShapeNOperator() : ParserOperator("Shap
 
 FMK_FUNC_HOST_VISIBILITY ShapeNOperator::~ShapeNOperator() {}
 
-FMK_FUNC_HOST_VISIBILITY ShapeNOperator &ShapeNOperator::Name(const std::string &name) {
-  ParserOperator::Name(name);
-  return *this;
-}
-
 FMK_FUNC_HOST_VISIBILITY ShapeNOperator &ShapeNOperator::N(int64_t n) {
   Attr(SHAPEN_ATTR_N, n);
   return *this;
diff --git a/parser/common/op_def/shape_n_op.h b/parser/common/op_def/shape_n_op.h
index 2211ea4..e60c70c 100644
--- a/parser/common/op_def/shape_n_op.h
+++ b/parser/common/op_def/shape_n_op.h
@@ -26,8 +26,6 @@ class ShapeNOperator : public ParserOperator {
   ShapeNOperator();
   ~ShapeNOperator() override;
 
-  ShapeNOperator &Name(const std::string &name);
-
   ShapeNOperator &N(int64_t n);
   int64_t GetN() const;
   ShapeNOperator &InType(ge::DataType t);
diff --git a/parser/common/op_def/var_is_initialized_op_op.cc b/parser/common/op_def/var_is_initialized_op_op.cc
index e0e3d62..ad3013d 100644
--- a/parser/common/op_def/var_is_initialized_op_op.cc
+++ b/parser/common/op_def/var_is_initialized_op_op.cc
@@ -24,11 +24,6 @@ VarIsInitializedOpOperator::VarIsInitializedOpOperator() : ParserOperator(ge::pa
 
 VarIsInitializedOpOperator::~VarIsInitializedOpOperator() {}
 
-VarIsInitializedOpOperator &VarIsInitializedOpOperator::Name(const std::string &name) {
-  ParserOperator::Name(name);
-  return *this;
-}
-
 VarIsInitializedOpOperator &VarIsInitializedOpOperator::VectorAttr(const std::string &key,
                                                                    std::vector<int64_t> &value) {
   Attr(key, value);
diff --git a/parser/common/op_def/var_is_initialized_op_op.h b/parser/common/op_def/var_is_initialized_op_op.h
index ee586e3..1c8ac5e 100644
--- a/parser/common/op_def/var_is_initialized_op_op.h
+++ b/parser/common/op_def/var_is_initialized_op_op.h
@@ -26,7 +26,6 @@ class VarIsInitializedOpOperator : public ParserOperator {
   VarIsInitializedOpOperator();
   ~VarIsInitializedOpOperator() override;
 
-  VarIsInitializedOpOperator &Name(const std::string &name);
   VarIsInitializedOpOperator &VectorAttr(const std::string &key, std::vector<int64_t> &value);
 };
 }  // namespace ge
diff --git a/parser/common/op_def/variable_op.cc b/parser/common/op_def/variable_op.cc
index 6000a2e..5be9600 100644
--- a/parser/common/op_def/variable_op.cc
+++ b/parser/common/op_def/variable_op.cc
@@ -23,11 +23,6 @@ VariableOperator::VariableOperator() : ParserOperator(ge::parser::VARIABLE) {}
 
 VariableOperator::~VariableOperator() {}
 
-VariableOperator &VariableOperator::Name(const std::string &name) {
-  ParserOperator::Name(name);
-  return *this;
-}
-
 VariableOperator &VariableOperator::Container(const std::string &container) {
   Attr(VAR_ATTR_CONTAINER, container);
   return *this;
diff --git a/parser/common/op_def/variable_op.h b/parser/common/op_def/variable_op.h
index ded8cac..3326657 100644
--- a/parser/common/op_def/variable_op.h
+++ b/parser/common/op_def/variable_op.h
@@ -27,8 +27,6 @@ class VariableOperator : public ParserOperator {
   VariableOperator();
   ~VariableOperator() override;
 
-  VariableOperator &Name(const std::string &name);
-
   VariableOperator &Container(const std::string &container);
 
   VariableOperator &SharedName(const std::string &sharedname);
diff --git a/parser/onnx/subgraph_adapter/subgraph_adapter_factory.h b/parser/onnx/subgraph_adapter/subgraph_adapter_factory.h
index 350f23e..26f18c3 100644
--- a/parser/onnx/subgraph_adapter/subgraph_adapter_factory.h
+++ b/parser/onnx/subgraph_adapter/subgraph_adapter_factory.h
@@ -32,6 +32,7 @@
 #endif
 
 #include <map>
+#include <memory>
 #include <functional>
 #include "subgraph_adapter.h"